From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org Cc: kernel test robot <lkp@intel.com>, Nick Desaulniers <ndesaulniers@google.com>, clang-built-linux@googlegroups.com, Andrew Morton <akpm@linux-foundation.org>, Christophe Leroy <christophe.leroy@c-s.fr>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/8xx: export 'cpm_setbrg' for modules Date: Fri, 22 Jan 2021 06:51:26 +0100 [thread overview] Message-ID: <91159e78-4eea-c645-9171-a5b90271710f@csgroup.eu> (raw) In-Reply-To: <20210122010819.30986-1-rdunlap@infradead.org> Le 22/01/2021 à 02:08, Randy Dunlap a écrit : > Fix missing export for a loadable module build: > > ERROR: modpost: "cpm_setbrg" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! > > Fixes: 4128a89ac80d ("powerpc/8xx: move CPM1 related files from sysdev/ to platforms/8xx") I don't understand. Before that commit cpm_setbrg() wasn't exported either. For me, it fixes the commit that brought the capability to build the cpm uart driver as a module, that is commit 1da177e4c3f4 ("Linux-2.6.12-rc") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: clang-built-linux@googlegroups.com > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Christophe Leroy <christophe.leroy@c-s.fr> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/platforms/8xx/cpm1.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210121.orig/arch/powerpc/platforms/8xx/cpm1.c > +++ linux-next-20210121/arch/powerpc/platforms/8xx/cpm1.c > @@ -280,6 +280,7 @@ cpm_setbrg(uint brg, uint rate) > out_be32(bp, (((BRG_UART_CLK_DIV16 / rate) - 1) << 1) | > CPM_BRG_EN | CPM_BRG_DIV16); > } > +EXPORT_SYMBOL(cpm_setbrg); > > struct cpm_ioport16 { > __be16 dir, par, odr_sor, dat, intr; >
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org Cc: Christophe Leroy <christophe.leroy@c-s.fr>, kernel test robot <lkp@intel.com>, Nick Desaulniers <ndesaulniers@google.com>, clang-built-linux@googlegroups.com, Paul Mackerras <paulus@samba.org>, Andrew Morton <akpm@linux-foundation.org>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/8xx: export 'cpm_setbrg' for modules Date: Fri, 22 Jan 2021 06:51:26 +0100 [thread overview] Message-ID: <91159e78-4eea-c645-9171-a5b90271710f@csgroup.eu> (raw) In-Reply-To: <20210122010819.30986-1-rdunlap@infradead.org> Le 22/01/2021 à 02:08, Randy Dunlap a écrit : > Fix missing export for a loadable module build: > > ERROR: modpost: "cpm_setbrg" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! > > Fixes: 4128a89ac80d ("powerpc/8xx: move CPM1 related files from sysdev/ to platforms/8xx") I don't understand. Before that commit cpm_setbrg() wasn't exported either. For me, it fixes the commit that brought the capability to build the cpm uart driver as a module, that is commit 1da177e4c3f4 ("Linux-2.6.12-rc") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: clang-built-linux@googlegroups.com > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Christophe Leroy <christophe.leroy@c-s.fr> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/platforms/8xx/cpm1.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210121.orig/arch/powerpc/platforms/8xx/cpm1.c > +++ linux-next-20210121/arch/powerpc/platforms/8xx/cpm1.c > @@ -280,6 +280,7 @@ cpm_setbrg(uint brg, uint rate) > out_be32(bp, (((BRG_UART_CLK_DIV16 / rate) - 1) << 1) | > CPM_BRG_EN | CPM_BRG_DIV16); > } > +EXPORT_SYMBOL(cpm_setbrg); > > struct cpm_ioport16 { > __be16 dir, par, odr_sor, dat, intr; >
next prev parent reply other threads:[~2021-01-22 5:52 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-22 1:08 [PATCH] powerpc/8xx: export 'cpm_setbrg' for modules Randy Dunlap 2021-01-22 1:08 ` Randy Dunlap 2021-01-22 5:51 ` Christophe Leroy [this message] 2021-01-22 5:51 ` Christophe Leroy 2021-01-22 6:11 ` Randy Dunlap 2021-01-22 6:11 ` Randy Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=91159e78-4eea-c645-9171-a5b90271710f@csgroup.eu \ --to=christophe.leroy@csgroup.eu \ --cc=akpm@linux-foundation.org \ --cc=benh@kernel.crashing.org \ --cc=christophe.leroy@c-s.fr \ --cc=clang-built-linux@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lkp@intel.com \ --cc=mpe@ellerman.id.au \ --cc=ndesaulniers@google.com \ --cc=paulus@samba.org \ --cc=rdunlap@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.