From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: broonie@kernel.org, simon@lineageos.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, b.zolnierkie@samsung.com,
m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add sound support to Midas
Date: Mon, 27 Jul 2020 18:32:52 +0200 [thread overview]
Message-ID: <9171a38d-a77e-a936-7311-34c4f6c70d6b@samsung.com> (raw)
In-Reply-To: <20200720143458.GB22554@kozik-lap>
On 20.07.2020 16:34, Krzysztof Kozlowski wrote:
> On Fri, Jul 10, 2020 at 07:35:00PM +0200, Sylwester Nawrocki wrote:
>> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> @@ -175,3 +175,41 @@
>> gpio = <&gpm0 0 GPIO_ACTIVE_HIGH>;
>> status = "okay";
>> };
>> +
>> +&submic_bias_reg {
>
> Put them in alphabetical order against oder phandle overrides. Same for
> n710x.dts.
>> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
>> @@ -102,6 +102,30 @@
>> status = "disabled";
>> };
>>
>> + vbatt_reg: voltage-regulator-9 {
>
> Since this is the basic DTSI for multiple boards, the numbering here
> should be consistent. You will have to rename the ones in Galaxy S3 and
> N710 DTSI.
>> @@ -266,16 +290,18 @@
>> + cpu {
>> + sound-dai = <&i2s0 0>;
>
> Double space after '='.
Thanks for your review, I have addressed all these issues in just
posted v2.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: simon@lineageos.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
b.zolnierkie@samsung.com, robh+dt@kernel.org, broonie@kernel.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add sound support to Midas
Date: Mon, 27 Jul 2020 18:32:52 +0200 [thread overview]
Message-ID: <9171a38d-a77e-a936-7311-34c4f6c70d6b@samsung.com> (raw)
In-Reply-To: <20200720143458.GB22554@kozik-lap>
On 20.07.2020 16:34, Krzysztof Kozlowski wrote:
> On Fri, Jul 10, 2020 at 07:35:00PM +0200, Sylwester Nawrocki wrote:
>> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>> @@ -175,3 +175,41 @@
>> gpio = <&gpm0 0 GPIO_ACTIVE_HIGH>;
>> status = "okay";
>> };
>> +
>> +&submic_bias_reg {
>
> Put them in alphabetical order against oder phandle overrides. Same for
> n710x.dts.
>> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
>> @@ -102,6 +102,30 @@
>> status = "disabled";
>> };
>>
>> + vbatt_reg: voltage-regulator-9 {
>
> Since this is the basic DTSI for multiple boards, the numbering here
> should be consistent. You will have to rename the ones in Galaxy S3 and
> N710 DTSI.
>> @@ -266,16 +290,18 @@
>> + cpu {
>> + sound-dai = <&i2s0 0>;
>
> Double space after '='.
Thanks for your review, I have addressed all these issues in just
posted v2.
--
Regards,
Sylwester
next prev parent reply other threads:[~2020-07-27 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200710173512eucas1p101c03994a728150f18428295192edf25@eucas1p1.samsung.com>
2020-07-10 17:34 ` [PATCH 1/3] ASoC: samsung: Document DT bindings for Midas sound subsystem Sylwester Nawrocki
2020-07-10 17:34 ` Sylwester Nawrocki
[not found] ` <CGME20200710173517eucas1p20c325719e385995f9f094f12d87e1dcb@eucas1p2.samsung.com>
2020-07-10 17:34 ` [PATCH 2/3] ASoC: samsung: Add sound support for Midas boards Sylwester Nawrocki
2020-07-10 17:34 ` Sylwester Nawrocki
2020-07-20 14:30 ` Krzysztof Kozlowski
2020-07-20 14:30 ` Krzysztof Kozlowski
[not found] ` <CGME20200710173518eucas1p1eeaaadd2359da3c863c43cd368a84213@eucas1p1.samsung.com>
2020-07-10 17:35 ` [PATCH 3/3] ARM: dts: exynos: Add sound support to Midas Sylwester Nawrocki
2020-07-10 17:35 ` Sylwester Nawrocki
2020-07-20 14:34 ` Krzysztof Kozlowski
2020-07-20 14:34 ` Krzysztof Kozlowski
2020-07-27 16:32 ` Sylwester Nawrocki [this message]
2020-07-27 16:32 ` Sylwester Nawrocki
2020-07-13 14:59 ` [PATCH 1/3] ASoC: samsung: Document DT bindings for Midas sound subsystem Rob Herring
2020-07-13 14:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9171a38d-a77e-a936-7311-34c4f6c70d6b@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.