From: Arnd Bergmann <arnd@arndb.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Murali Karicheri <m-karicheri2@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] drivers/pci: make host/pci-keystone-dw.c modular
Date: Mon, 08 Feb 2016 10:59:26 +0100 [thread overview]
Message-ID: <91848876.ZYig6qgHLq@wuerfel> (raw)
In-Reply-To: <1454889644-27830-5-git-send-email-paul.gortmaker@windriver.com>
On Sunday 07 February 2016 19:00:43 Paul Gortmaker wrote:
> Export the symbols that this driver requires in order for it to
> be modular. In addition to the one use case of a dw_pci sym, it
> has many instances of its own ks_dw_pci syms that need exporting
> in order to modpost w/o error.
>
> Cc: Murali Karicheri <m-karicheri2@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
Could we just have one module for the driver instead of two?
Something like below (untested)
Arnd
diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
index 7b2f20c6ccc6..0b472c680348 100644
--- a/drivers/pci/host/Makefile
+++ b/drivers/pci/host/Makefile
@@ -8,7 +8,8 @@ obj-$(CONFIG_PCI_RCAR_GEN2) += pci-rcar-gen2.o
obj-$(CONFIG_PCI_RCAR_GEN2_PCIE) += pcie-rcar.o
obj-$(CONFIG_PCI_HOST_GENERIC) += pci-host-generic.o
obj-$(CONFIG_PCIE_SPEAR13XX) += pcie-spear13xx.o
-obj-$(CONFIG_PCI_KEYSTONE) += pci-keystone-dw.o pci-keystone.o
+obj-$(CONFIG_PCI_KEYSTONE) pci-keystone-mod.o
+pci-keystone-mod-objs := pci-keystone-dw.o pci-keystone.o
obj-$(CONFIG_PCIE_XILINX) += pcie-xilinx.o
obj-$(CONFIG_PCI_XGENE) += pci-xgene.o
obj-$(CONFIG_PCI_XGENE_MSI) += pci-xgene-msi.o
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] drivers/pci: make host/pci-keystone-dw.c modular
Date: Mon, 08 Feb 2016 10:59:26 +0100 [thread overview]
Message-ID: <91848876.ZYig6qgHLq@wuerfel> (raw)
In-Reply-To: <1454889644-27830-5-git-send-email-paul.gortmaker@windriver.com>
On Sunday 07 February 2016 19:00:43 Paul Gortmaker wrote:
> Export the symbols that this driver requires in order for it to
> be modular. In addition to the one use case of a dw_pci sym, it
> has many instances of its own ks_dw_pci syms that need exporting
> in order to modpost w/o error.
>
> Cc: Murali Karicheri <m-karicheri2@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-pci at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
Could we just have one module for the driver instead of two?
Something like below (untested)
Arnd
diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
index 7b2f20c6ccc6..0b472c680348 100644
--- a/drivers/pci/host/Makefile
+++ b/drivers/pci/host/Makefile
@@ -8,7 +8,8 @@ obj-$(CONFIG_PCI_RCAR_GEN2) += pci-rcar-gen2.o
obj-$(CONFIG_PCI_RCAR_GEN2_PCIE) += pcie-rcar.o
obj-$(CONFIG_PCI_HOST_GENERIC) += pci-host-generic.o
obj-$(CONFIG_PCIE_SPEAR13XX) += pcie-spear13xx.o
-obj-$(CONFIG_PCI_KEYSTONE) += pci-keystone-dw.o pci-keystone.o
+obj-$(CONFIG_PCI_KEYSTONE) pci-keystone-mod.o
+pci-keystone-mod-objs := pci-keystone-dw.o pci-keystone.o
obj-$(CONFIG_PCIE_XILINX) += pcie-xilinx.o
obj-$(CONFIG_PCI_XGENE) += pci-xgene.o
obj-$(CONFIG_PCI_XGENE_MSI) += pci-xgene-msi.o
next prev parent reply other threads:[~2016-02-08 10:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 0:00 [PATCH 0/5] Modularize PCI_DW related drivers Paul Gortmaker
2016-02-08 0:00 ` Paul Gortmaker
2016-02-08 0:00 ` Paul Gortmaker
2016-02-08 0:00 ` [PATCH 1/5] ARM: add EXPORT_SYMBOL of hook_fault_code for PCI host modularization Paul Gortmaker
2016-02-08 0:00 ` Paul Gortmaker
2016-02-08 9:53 ` Arnd Bergmann
2016-02-08 9:53 ` Arnd Bergmann
2016-02-08 16:39 ` Paul Gortmaker
2016-02-08 16:39 ` Paul Gortmaker
2016-02-08 17:27 ` Russell King - ARM Linux
2016-02-08 17:27 ` Russell King - ARM Linux
2016-02-08 17:34 ` Russell King - ARM Linux
2016-02-08 17:34 ` Russell King - ARM Linux
2016-02-08 0:00 ` [PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count Paul Gortmaker
2016-02-08 0:00 ` Paul Gortmaker
2016-02-08 9:56 ` Arnd Bergmann
2016-02-08 9:56 ` Arnd Bergmann
2016-02-08 15:54 ` Paul Gortmaker
2016-02-08 15:54 ` Paul Gortmaker
2016-02-08 0:00 ` [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate Paul Gortmaker
2016-02-08 9:57 ` Arnd Bergmann
2016-02-08 15:53 ` Paul Gortmaker
2016-02-08 0:00 ` [PATCH 4/5] drivers/pci: make host/pci-keystone-dw.c modular Paul Gortmaker
2016-02-08 0:00 ` Paul Gortmaker
2016-02-08 9:59 ` Arnd Bergmann [this message]
2016-02-08 9:59 ` Arnd Bergmann
2016-02-08 15:53 ` Paul Gortmaker
2016-02-08 15:53 ` Paul Gortmaker
2016-02-08 19:03 ` Murali Karicheri
2016-02-08 19:03 ` Murali Karicheri
2016-02-08 0:00 ` [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular Paul Gortmaker
2016-02-08 0:00 ` Paul Gortmaker
2016-02-08 10:00 ` Arnd Bergmann
2016-02-08 15:51 ` Paul Gortmaker
2016-02-08 15:51 ` Paul Gortmaker
2016-02-24 6:09 ` [PATCH 0/5] Modularize PCI_DW related drivers Kishon Vijay Abraham I
2016-02-24 6:09 ` Kishon Vijay Abraham I
2016-02-24 6:09 ` Kishon Vijay Abraham I
2016-02-24 9:04 ` Arnd Bergmann
2016-02-24 9:04 ` Arnd Bergmann
2016-02-25 8:13 ` Kishon Vijay Abraham I
2016-02-25 8:13 ` Kishon Vijay Abraham I
2016-02-25 8:13 ` Kishon Vijay Abraham I
2016-02-25 8:35 ` Arnd Bergmann
2016-02-25 8:35 ` Arnd Bergmann
2016-02-29 9:29 ` Kishon Vijay Abraham I
2016-02-29 9:29 ` Kishon Vijay Abraham I
2016-02-29 9:29 ` Kishon Vijay Abraham I
2016-03-01 21:35 ` Arnd Bergmann
2016-03-01 21:35 ` Arnd Bergmann
2016-03-15 20:50 ` Murali Karicheri
2016-03-15 20:50 ` Murali Karicheri
2016-03-15 20:50 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91848876.ZYig6qgHLq@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=paul.gortmaker@windriver.com \
--cc=svarbanov@mm-sol.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.