From: Bart Van Assche <bvanassche@acm.org> To: Po-Wen Kao <powen.kao@mediatek.com>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com, stanley.chu@mediatek.com, alice.chao@mediatek.com, naomi.chu@mediatek.com, chun-hung.wu@mediatek.com, cc.chou@mediatek.com, eddie.huang@mediatek.com, mason.zhang@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com Subject: Re: [PATCH] scsi: ufs: core: Make UFS_MCQ_NUM_DEV_CMD_QUEUES a module parameter Date: Tue, 28 Mar 2023 20:17:19 -0700 [thread overview] Message-ID: <9266aa1b-2d63-43d5-f06e-5a228bc131be@acm.org> (raw) In-Reply-To: <20230328103000.10757-1-powen.kao@mediatek.com> On 3/28/23 03:29, Po-Wen Kao wrote: > A dedicated queue for dev commands is not mandatory, hence let > UFS_MCQ_NUM_DEV_CMD_QUEUES become module parameter `dev_cmd_queues` > to allow sharing first hw queue for dev commands. Which queue is selected for device management commands? What is the impact of this change? If a device command is queued on a queue with multiple pending commands, does that mean that it can take long for the device command to reach the UFS device? The answer to the above questions should be in the patch description. Please expand the patch description. > +unsigned int dev_cmd_queues = 1; > +module_param_cb(dev_cmd_queues, &dev_cmd_queue_count_ops, &dev_cmd_queues, 0644); > +MODULE_PARM_DESC(dev_cmd_queues, > + "Number of queues used for dev command. Default value is 1"); I prefer a solution that does not require any new kernel module parameters. That means either a dedicated device command queue for all host controllers or no dedicated device command queue for any host controller. Thanks, Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org> To: Po-Wen Kao <powen.kao@mediatek.com>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com, stanley.chu@mediatek.com, alice.chao@mediatek.com, naomi.chu@mediatek.com, chun-hung.wu@mediatek.com, cc.chou@mediatek.com, eddie.huang@mediatek.com, mason.zhang@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com Subject: Re: [PATCH] scsi: ufs: core: Make UFS_MCQ_NUM_DEV_CMD_QUEUES a module parameter Date: Tue, 28 Mar 2023 20:17:19 -0700 [thread overview] Message-ID: <9266aa1b-2d63-43d5-f06e-5a228bc131be@acm.org> (raw) In-Reply-To: <20230328103000.10757-1-powen.kao@mediatek.com> On 3/28/23 03:29, Po-Wen Kao wrote: > A dedicated queue for dev commands is not mandatory, hence let > UFS_MCQ_NUM_DEV_CMD_QUEUES become module parameter `dev_cmd_queues` > to allow sharing first hw queue for dev commands. Which queue is selected for device management commands? What is the impact of this change? If a device command is queued on a queue with multiple pending commands, does that mean that it can take long for the device command to reach the UFS device? The answer to the above questions should be in the patch description. Please expand the patch description. > +unsigned int dev_cmd_queues = 1; > +module_param_cb(dev_cmd_queues, &dev_cmd_queue_count_ops, &dev_cmd_queues, 0644); > +MODULE_PARM_DESC(dev_cmd_queues, > + "Number of queues used for dev command. Default value is 1"); I prefer a solution that does not require any new kernel module parameters. That means either a dedicated device command queue for all host controllers or no dedicated device command queue for any host controller. Thanks, Bart. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-29 3:17 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-28 10:29 [PATCH] scsi: ufs: core: Make UFS_MCQ_NUM_DEV_CMD_QUEUES a module parameter Po-Wen Kao 2023-03-28 10:29 ` Po-Wen Kao 2023-03-29 1:29 ` Stanley Chu 2023-03-29 1:29 ` Stanley Chu 2023-03-29 3:17 ` Bart Van Assche [this message] 2023-03-29 3:17 ` Bart Van Assche 2023-03-30 2:52 ` Powen Kao (高伯文) 2023-03-30 2:52 ` Powen Kao (高伯文)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9266aa1b-2d63-43d5-f06e-5a228bc131be@acm.org \ --to=bvanassche@acm.org \ --cc=alice.chao@mediatek.com \ --cc=alim.akhtar@samsung.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=avri.altman@wdc.com \ --cc=cc.chou@mediatek.com \ --cc=chaotian.jing@mediatek.com \ --cc=chun-hung.wu@mediatek.com \ --cc=eddie.huang@mediatek.com \ --cc=jejb@linux.ibm.com \ --cc=jiajie.hao@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=mason.zhang@mediatek.com \ --cc=matthias.bgg@gmail.com \ --cc=naomi.chu@mediatek.com \ --cc=peter.wang@mediatek.com \ --cc=powen.kao@mediatek.com \ --cc=stanley.chu@mediatek.com \ --cc=wsd_upstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.