From: Julien Grall <julien.grall@arm.com>
To: Wei Liu <wei.liu2@citrix.com>, Andrii Anisov <andrii.anisov@gmail.com>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.
Date: Wed, 23 Nov 2016 14:34:04 +0000 [thread overview]
Message-ID: <927c0018-b217-00be-b699-8be386ec8488@arm.com> (raw)
In-Reply-To: <20161123142949.GD23528@citrix.com>
Hi Wei,
On 23/11/16 14:29, Wei Liu wrote:
> On Wed, Nov 23, 2016 at 04:12:28PM +0200, Andrii Anisov wrote:
>>> But before you write any code, let me try to understand the real issue
>>> first: you're trying to cross-build ARM tools on x86, but x86
>>> iasl doesn't support ARM ACPI definition(s), right?
>> Well, as I stated here [1], I'm pretty far from ACPI and understanding
>> of what's going wrong with the compilation. But I have a strong
>> feeling that this option should be optional.
>>
>> [1] https://lists.xenproject.org/archives/html/xen-devel/2016-11/msg01903.html
>
> What is the exact rune you got when compiling mk_dsdt ?
>
> If everything it set up properly you should be using a cross-build gcc
> which should have the correct architecture?
>
> Can you try this (untested) patch?
>
>
> diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
> index ccc32c9..2b9d5b8 100644
> --- a/tools/libacpi/Makefile
> +++ b/tools/libacpi/Makefile
> @@ -44,7 +44,7 @@ $(H_SRC): $(ACPI_BUILD_DIR)/%.h: %.asl iasl
> rm -f $(addprefix $(ACPI_BUILD_DIR)/, $*.aml $*.hex)
>
> $(MK_DSDT): mk_dsdt.c
> - $(HOSTCC) $(HOSTCFLAGS) $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -o $@ mk_dsdt.c
> + $(CC) $(CFLAGS) $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -o $@ mk_dsdt.c
That will not work, CC will build an ARM binary. However mk_dsdt is used
to generate the static ACPI table integrated in the libxl, so mk_dsdt
needs to be built with HOSTCC.
I think the code should use CONFIG_ARM_64/CONFIG_ARM_32 rather than
__*__ one.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-23 14:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 12:25 [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable Andrii Anisov
2016-11-23 12:45 ` Julien Grall
2016-11-23 13:03 ` Andrii Anisov
2016-11-23 13:12 ` Wei Liu
2016-11-23 13:59 ` Andrii Anisov
2016-11-23 14:05 ` Wei Liu
2016-11-23 14:12 ` Andrii Anisov
2016-11-23 14:29 ` Wei Liu
2016-11-23 14:34 ` Julien Grall [this message]
2016-11-23 14:37 ` Wei Liu
2016-11-23 15:10 ` Julien Grall
2016-11-23 15:47 ` Andrii Anisov
2016-11-23 19:28 ` Julien Grall
2016-11-23 19:32 ` Andrew Cooper
2016-11-28 9:32 ` Andrii Anisov
2016-11-23 14:22 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927c0018-b217-00be-b699-8be386ec8488@arm.com \
--to=julien.grall@arm.com \
--cc=andrii.anisov@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.