All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Andrii Anisov <andrii.anisov@gmail.com>, xen-devel@lists.xen.org
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, zhaoshenglong@huawei.com
Subject: Re: [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.
Date: Wed, 23 Nov 2016 12:45:36 +0000	[thread overview]
Message-ID: <f97b431c-7f25-bf85-a2ee-d833e6c525b0@arm.com> (raw)
In-Reply-To: <1479903908-13579-1-git-send-email-andrii.anisov@gmail.com>

Hello,

On 23/11/16 12:25, Andrii Anisov wrote:
> Make the libxl ACPI support build configurable by the same config
> option as the hypervisor side support.

This will not work because Kconfig support only exists for the hypervisor.

Furthermore, people may want to disable ACPI for the host but still 
support ACPI for guest.

The way forward is to have an option in the configure to opt-out the 
support of guest ACPI and also remove the iasl check.

Regards,

>
> Signed-off-by: Andrii Anisov <andrii.anisov@gmail.com>
> ---
>  tools/libxl/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index f5053a0..a4e9319 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -90,7 +90,7 @@ acpi:
>
>  LIBXL_OBJS-$(CONFIG_X86) += libxl_cpuid.o libxl_x86.o libxl_psr.o libxl_x86_acpi.o
>  LIBXL_OBJS-$(CONFIG_ARM) += libxl_nocpuid.o libxl_arm.o libxl_libfdt_compat.o
> -ifeq ($(CONFIG_ARM_64),y)
> +ifeq ($(CONFIG_ACPI),y)
>  DSDT_FILES-y = dsdt_anycpu_arm.c
>  LIBXL_OBJS-y += libxl_arm_acpi.o $(patsubst %.c,%.o,$(DSDT_FILES-y))
>  dsdt_anycpu_arm.c:
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-11-23 12:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 12:25 [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable Andrii Anisov
2016-11-23 12:45 ` Julien Grall [this message]
2016-11-23 13:03   ` Andrii Anisov
2016-11-23 13:12     ` Wei Liu
2016-11-23 13:59       ` Andrii Anisov
2016-11-23 14:05         ` Wei Liu
2016-11-23 14:12           ` Andrii Anisov
2016-11-23 14:29             ` Wei Liu
2016-11-23 14:34               ` Julien Grall
2016-11-23 14:37                 ` Wei Liu
2016-11-23 15:10             ` Julien Grall
2016-11-23 15:47               ` Andrii Anisov
2016-11-23 19:28                 ` Julien Grall
2016-11-23 19:32                   ` Andrew Cooper
2016-11-28  9:32                   ` Andrii Anisov
2016-11-23 14:22           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f97b431c-7f25-bf85-a2ee-d833e6c525b0@arm.com \
    --to=julien.grall@arm.com \
    --cc=andrii.anisov@gmail.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.