All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@linux-m68k.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-spi@vger.kernel.org,
	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
	kernel@pengutronix.de, fabio.estevam@nxp.com,
	shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] spi: imx: fix use of native chip-selects with devicetree
Date: Tue, 21 Mar 2017 21:53:52 +1000	[thread overview]
Message-ID: <942cfc4b-445b-ca51-1823-2391cea62abf@linux-m68k.org> (raw)
In-Reply-To: <20170321080551.ie4xm5hr3fki365s@pengutronix.de>

On 21/03/17 18:05, Uwe Kleine-König wrote:
> On Tue, Mar 21, 2017 at 12:05:20PM +1000, Greg Ungerer wrote:
>> On 20/03/17 23:22, Vladimir Zapolskiy wrote:
>>> For that type of bindings locally I have a hackish spi-imx driver change,
>>> which supports this option, but I'm unsure if it is universal enough.
>>
>> Do you mean supporting no cs-gpios tag?
>> That would be nice, but it would seem not many users of this are
>> using native chip selects.
>
> The reason for this is that the native chip selects are less flexible
> than gpios because you cannot control when they deassert. IIRC they do
> it too much for some chips. So the only reason to stick to them is that
> on some SoCs not all pins have a GPIO function. Not sure if transfer
> speed is another reason, but I would expect that the gain isn't that
> big.

For the particular SPI device I am using, a Silicon Labs 32260,
it actually wants the assertion and de-assertion of the chip-select
between each byte. So it is the only way it can work for me.

Regards
Greg

WARNING: multiple messages have this Message-ID (diff)
From: gerg@linux-m68k.org (Greg Ungerer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] spi: imx: fix use of native chip-selects with devicetree
Date: Tue, 21 Mar 2017 21:53:52 +1000	[thread overview]
Message-ID: <942cfc4b-445b-ca51-1823-2391cea62abf@linux-m68k.org> (raw)
In-Reply-To: <20170321080551.ie4xm5hr3fki365s@pengutronix.de>

On 21/03/17 18:05, Uwe Kleine-K?nig wrote:
> On Tue, Mar 21, 2017 at 12:05:20PM +1000, Greg Ungerer wrote:
>> On 20/03/17 23:22, Vladimir Zapolskiy wrote:
>>> For that type of bindings locally I have a hackish spi-imx driver change,
>>> which supports this option, but I'm unsure if it is universal enough.
>>
>> Do you mean supporting no cs-gpios tag?
>> That would be nice, but it would seem not many users of this are
>> using native chip selects.
>
> The reason for this is that the native chip selects are less flexible
> than gpios because you cannot control when they deassert. IIRC they do
> it too much for some chips. So the only reason to stick to them is that
> on some SoCs not all pins have a GPIO function. Not sure if transfer
> speed is another reason, but I would expect that the gain isn't that
> big.

For the particular SPI device I am using, a Silicon Labs 32260,
it actually wants the assertion and de-assertion of the chip-select
between each byte. So it is the only way it can work for me.

Regards
Greg

  reply	other threads:[~2017-03-21 11:53 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17  5:03 [PATCH 0/2] spi: imx: native chip selects and devicetree Greg Ungerer
2017-03-17  5:03 ` Greg Ungerer
2017-03-17  5:03 ` [PATCH 1/2] spi: imx: set correct chip_select in platform setup Greg Ungerer
2017-03-17  5:03   ` Greg Ungerer
     [not found]   ` <1489726983-17706-2-git-send-email-gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-03-20  7:38     ` Shawn Guo
2017-03-20  7:38       ` Shawn Guo
2017-03-20 11:52       ` Greg Ungerer
2017-03-20 11:52         ` Greg Ungerer
     [not found] ` <1489726983-17706-1-git-send-email-gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-03-17  5:03   ` [PATCH 2/2] spi: imx: fix use of native chip-selects with devicetree Greg Ungerer
2017-03-17  5:03     ` Greg Ungerer
2017-03-20  7:39     ` Shawn Guo
2017-03-20  7:39       ` Shawn Guo
     [not found]     ` <1489726983-17706-3-git-send-email-gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-03-20 13:22       ` Vladimir Zapolskiy
2017-03-20 13:22         ` Vladimir Zapolskiy
2017-03-21  2:05         ` Greg Ungerer
2017-03-21  2:05           ` Greg Ungerer
     [not found]           ` <4a8449d9-cc38-d642-0853-246f46ee7059-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-03-21  8:05             ` Uwe Kleine-König
2017-03-21  8:05               ` Uwe Kleine-König
2017-03-21 11:53               ` Greg Ungerer [this message]
2017-03-21 11:53                 ` Greg Ungerer
     [not found]                 ` <942cfc4b-445b-ca51-1823-2391cea62abf-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-03-21 12:11                   ` Uwe Kleine-König
2017-03-21 12:11                     ` Uwe Kleine-König
     [not found]                     ` <20170321121133.jcmhhbszj2d42h3w-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-03-21 13:22                       ` Greg Ungerer
2017-03-21 13:22                         ` Greg Ungerer
     [not found]                         ` <20678cef-f667-9915-aa00-8877ad152a8c-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-03-21 19:23                           ` Uwe Kleine-König
2017-03-21 19:23                             ` Uwe Kleine-König
2017-03-21 20:15                             ` Geert Uytterhoeven
2017-03-21 20:15                               ` Geert Uytterhoeven
     [not found]                               ` <CAMuHMdW+KcPCAweneu4pTg1Pb-uAvYGz1+Z=oEDYoOt4gWrjhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-22  0:50                                 ` Greg Ungerer
2017-03-22  0:50                                   ` Greg Ungerer
2017-03-22  7:09                                   ` Geert Uytterhoeven
2017-03-22  7:09                                     ` Geert Uytterhoeven
2017-09-04 12:47       ` Applied "spi: imx: fix use of native chip-selects with devicetree" to the spi tree Mark Brown
2017-09-04 12:47         ` Mark Brown
2017-10-10 20:38       ` [2/2] spi: imx: fix use of native chip-selects with devicetree Trent Piepho
2017-10-10 20:38         ` Trent Piepho
2017-10-12  6:26         ` Greg Ungerer
2017-10-12  6:26           ` Greg Ungerer
     [not found]           ` <209bb901-875e-8007-06f8-3ae9698a0e41-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-10-12 20:41             ` Trent Piepho
2017-10-12 20:41               ` Trent Piepho
2017-03-20  7:35   ` [PATCH 0/2] spi: imx: native chip selects and devicetree Shawn Guo
2017-03-20  7:35     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=942cfc4b-445b-ca51-1823-2391cea62abf@linux-m68k.org \
    --to=gerg@linux-m68k.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.