Re: [PATCH v3 0/7] kselftest/alsa: pcm-test improvements

From: Jaroslav Kysela <perex@perex.cz>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>,
	Shuah Khan <shuah@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 0/7] kselftest/alsa: pcm-test improvements
Date: Fri, 2 Dec 2022 09:58:00 +0100	[thread overview]
Message-ID: <9501fe01-4a3f-f83a-f9aa-153410a94f7e@perex.cz> (raw)
In-Reply-To: <20221202001749.3321187-1-broonie@kernel.org>

On 02. 12. 22 1:17, Mark Brown wrote:
> This series provides a bunch of quick updates which should make the
> coverage from pcm-test a bit more useful, it adds some support for
> skipping tests when the hardware/driver is unable to support the
> requested configuration, support for providing user visible descriptions
> and then expands the set of cases we cover to include more sample rates
> and channel counts.  This should exercise switching between 8kHz and
> 44.1kHz based rates and ensure that clocking doesn't get confused by
> non-stereo channel counts, both of which are I expect common real world
> errors, at least for embedded cards.
> 
> v3:
>   - "Rebase" onto Takashi's current tree (with a revert).
>   - Include Jaroslav's changes to specify all tests in the configuration
>     file parsing.
>   - Add a new "description" field to the configuration instead of trying
>     to name the tests.
>   - Always run both default and per-system tests, logging our success at
>     setting the per-system configurations as a separate test since they
>     shouldn't fail.
> v2:
>   - Rebase onto Takashi's current tree.
>   - Tweak the buffer sizes for the newly added cases, don't be quite
>     so ambitious in how big a buffer we request for 96kHz and don't
>     go quite so small for 8kHz since some devices start hitting lower
>     limits on period size and struggle to deliver accurate timing.
> 
> Jaroslav Kysela (1):
>    kselftest/alsa: pcm - move more configuration to configuration files
> 
> Mark Brown (6):
>    kselftest/alsa: pcm - Drop recent coverage improvement changes
>    kselftest/alsa: pcm - Always run the default set of tests
>    kselftest/alsa: pcm - skip tests when we fail to set params
>    kselftest/alsa: pcm - Support optional description for tests
>    kselftest/alsa: pcm - Provide descriptions for the default tests
>    kselftest/alsa: pcm - Add more coverage by default
> 
>   tools/testing/selftests/alsa/Makefile         |   2 +-
>   tools/testing/selftests/alsa/alsa-local.h     |   3 +
>   tools/testing/selftests/alsa/conf.c           |  26 ++-
>   .../alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf  |  43 ++--
>   tools/testing/selftests/alsa/pcm-test.c       | 205 ++++++++++++------
>   tools/testing/selftests/alsa/pcm-test.conf    |  63 ++++++
>   6 files changed, 250 insertions(+), 92 deletions(-)
>   create mode 100644 tools/testing/selftests/alsa/pcm-test.conf
> 
> 
> base-commit: 7d721baea138696d5a6746fb5bce0a510a91bd65

All looks good. I would probably do some things differently, but the goal is 
same. I am fine with all changes.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.