All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
	Shuah Khan <shuah@kernel.org>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	linux-kselftest@vger.kernel.org
Subject: [PATCH v3 0/7] kselftest/alsa: pcm-test improvements
Date: Fri,  2 Dec 2022 00:17:42 +0000	[thread overview]
Message-ID: <20221202001749.3321187-1-broonie@kernel.org> (raw)

This series provides a bunch of quick updates which should make the
coverage from pcm-test a bit more useful, it adds some support for
skipping tests when the hardware/driver is unable to support the
requested configuration, support for providing user visible descriptions
and then expands the set of cases we cover to include more sample rates
and channel counts.  This should exercise switching between 8kHz and
44.1kHz based rates and ensure that clocking doesn't get confused by
non-stereo channel counts, both of which are I expect common real world
errors, at least for embedded cards.

v3:
 - "Rebase" onto Takashi's current tree (with a revert).
 - Include Jaroslav's changes to specify all tests in the configuration
   file parsing.
 - Add a new "description" field to the configuration instead of trying
   to name the tests.
 - Always run both default and per-system tests, logging our success at
   setting the per-system configurations as a separate test since they
   shouldn't fail.
v2:
 - Rebase onto Takashi's current tree.
 - Tweak the buffer sizes for the newly added cases, don't be quite
   so ambitious in how big a buffer we request for 96kHz and don't
   go quite so small for 8kHz since some devices start hitting lower
   limits on period size and struggle to deliver accurate timing.

Jaroslav Kysela (1):
  kselftest/alsa: pcm - move more configuration to configuration files

Mark Brown (6):
  kselftest/alsa: pcm - Drop recent coverage improvement changes
  kselftest/alsa: pcm - Always run the default set of tests
  kselftest/alsa: pcm - skip tests when we fail to set params
  kselftest/alsa: pcm - Support optional description for tests
  kselftest/alsa: pcm - Provide descriptions for the default tests
  kselftest/alsa: pcm - Add more coverage by default

 tools/testing/selftests/alsa/Makefile         |   2 +-
 tools/testing/selftests/alsa/alsa-local.h     |   3 +
 tools/testing/selftests/alsa/conf.c           |  26 ++-
 .../alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf  |  43 ++--
 tools/testing/selftests/alsa/pcm-test.c       | 205 ++++++++++++------
 tools/testing/selftests/alsa/pcm-test.conf    |  63 ++++++
 6 files changed, 250 insertions(+), 92 deletions(-)
 create mode 100644 tools/testing/selftests/alsa/pcm-test.conf


base-commit: 7d721baea138696d5a6746fb5bce0a510a91bd65
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
	Shuah Khan <shuah@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
	Mark Brown <broonie@kernel.org>
Subject: [PATCH v3 0/7] kselftest/alsa: pcm-test improvements
Date: Fri,  2 Dec 2022 00:17:42 +0000	[thread overview]
Message-ID: <20221202001749.3321187-1-broonie@kernel.org> (raw)

This series provides a bunch of quick updates which should make the
coverage from pcm-test a bit more useful, it adds some support for
skipping tests when the hardware/driver is unable to support the
requested configuration, support for providing user visible descriptions
and then expands the set of cases we cover to include more sample rates
and channel counts.  This should exercise switching between 8kHz and
44.1kHz based rates and ensure that clocking doesn't get confused by
non-stereo channel counts, both of which are I expect common real world
errors, at least for embedded cards.

v3:
 - "Rebase" onto Takashi's current tree (with a revert).
 - Include Jaroslav's changes to specify all tests in the configuration
   file parsing.
 - Add a new "description" field to the configuration instead of trying
   to name the tests.
 - Always run both default and per-system tests, logging our success at
   setting the per-system configurations as a separate test since they
   shouldn't fail.
v2:
 - Rebase onto Takashi's current tree.
 - Tweak the buffer sizes for the newly added cases, don't be quite
   so ambitious in how big a buffer we request for 96kHz and don't
   go quite so small for 8kHz since some devices start hitting lower
   limits on period size and struggle to deliver accurate timing.

Jaroslav Kysela (1):
  kselftest/alsa: pcm - move more configuration to configuration files

Mark Brown (6):
  kselftest/alsa: pcm - Drop recent coverage improvement changes
  kselftest/alsa: pcm - Always run the default set of tests
  kselftest/alsa: pcm - skip tests when we fail to set params
  kselftest/alsa: pcm - Support optional description for tests
  kselftest/alsa: pcm - Provide descriptions for the default tests
  kselftest/alsa: pcm - Add more coverage by default

 tools/testing/selftests/alsa/Makefile         |   2 +-
 tools/testing/selftests/alsa/alsa-local.h     |   3 +
 tools/testing/selftests/alsa/conf.c           |  26 ++-
 .../alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf  |  43 ++--
 tools/testing/selftests/alsa/pcm-test.c       | 205 ++++++++++++------
 tools/testing/selftests/alsa/pcm-test.conf    |  63 ++++++
 6 files changed, 250 insertions(+), 92 deletions(-)
 create mode 100644 tools/testing/selftests/alsa/pcm-test.conf


base-commit: 7d721baea138696d5a6746fb5bce0a510a91bd65
-- 
2.30.2


             reply	other threads:[~2022-12-02  0:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02  0:17 Mark Brown [this message]
2022-12-02  0:17 ` [PATCH v3 0/7] kselftest/alsa: pcm-test improvements Mark Brown
2022-12-02  0:17 ` [PATCH v3 1/7] kselftest/alsa: pcm - Drop recent coverage improvement changes Mark Brown
2022-12-02  0:17   ` Mark Brown
2022-12-02  0:17 ` [PATCH v3 2/7] kselftest/alsa: pcm - move more configuration to configuration files Mark Brown
2022-12-02  0:17   ` Mark Brown
2022-12-02  0:17 ` [PATCH v3 3/7] kselftest/alsa: pcm - Always run the default set of tests Mark Brown
2022-12-02  0:17   ` Mark Brown
2022-12-02  0:17 ` [PATCH v3 4/7] kselftest/alsa: pcm - skip tests when we fail to set params Mark Brown
2022-12-02  0:17   ` Mark Brown
2022-12-02  0:17 ` [PATCH v3 5/7] kselftest/alsa: pcm - Support optional description for tests Mark Brown
2022-12-02  0:17   ` Mark Brown
2022-12-02  0:17 ` [PATCH v3 6/7] kselftest/alsa: pcm - Provide descriptions for the default tests Mark Brown
2022-12-02  0:17   ` Mark Brown
2022-12-02  0:17 ` [PATCH v3 7/7] kselftest/alsa: pcm - Add more coverage by default Mark Brown
2022-12-02  0:17   ` Mark Brown
2022-12-02  8:58 ` [PATCH v3 0/7] kselftest/alsa: pcm-test improvements Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221202001749.3321187-1-broonie@kernel.org \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=shuah@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.