Re: [PATCH v3 0/8] interconnect: Add imx support via devfreq

From: Chanwoo Choi <cw00.choi@samsung.com>
To: Georgi Djakov <georgi.djakov@linaro.org>,
	Leonard Crestez <leonard.crestez@nxp.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Alexandre Bailon" <abailon@baylibre.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Jacky Bai" <ping.bai@nxp.com>,
	"Anson Huang" <Anson.Huang@nxp.com>,
	"Artur Świgoń" <a.swigon@samsung.com>,
	"Abel Vesa" <abel.vesa@nxp.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Saravana Kannan" <saravanak@google.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Dong Aisheng" <aisheng.dong@nxp.com>,
	"Fabio Estevam" <fabio.estevam@nxp.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Matthias Kaehlcke" <mka@chromium.org>,
	"Angus Ainslie" <angus@akkea.ca>,
	"Martin Kepplinger" <martink@posteo.de>,
	"Silvano di Ninno" <silvano.dininno@nxp.com>,
	linux-pm@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/8] interconnect: Add imx support via devfreq
Date: Thu, 7 May 2020 09:02:21 +0900	[thread overview]
Message-ID: <955b0a73-617f-0974-74c3-e1d92db918b7@samsung.com> (raw)
In-Reply-To: <86c1596c-d3c2-0c2d-4a7c-016f9cd7d4c4@linaro.org>

Hi,

On 4/29/20 4:30 PM, Georgi Djakov wrote:
> Hi,
> 
> On 4/6/20 15:03, Leonard Crestez wrote:
>> This series adds interconnect scaling support for imx8m series chips. It uses a
>> per-SOC interconnect provider layered on top of multiple instances of devfreq
>> for scalable nodes along the interconnect.
>>
>> Existing qcom interconnect providers mostly translate bandwidth requests into
>> firmware calls but equivalent firmware on imx8m is much thinner. Scaling
>> support for individual nodes is implemented as distinct devfreq drivers
>> instead.
>>
>> The imx interconnect provider doesn't communicate with devfreq directly
>> but rather computes "minimum frequencies" for nodes along the path and
>> creates dev_pm_qos requests.
>>
>> Since there is no single devicetree node that can represent the
>> "interconnect" the main NOC is picked as the "interconnect provider" and
>> will probe the interconnect platform device if #interconnect-cells is
>> present. This avoids introducing "virtual" devices but it means that DT
>> bindings of main NOC includes properties for both devfreq and
>> interconnect.
> 
> Thank you for your work Leonard! There is no build dependency between the
> devfreq and interconnect patches, so i can apply patches 1,4-7.
> 
> Chanwoo, should i take also the two devfreq patches with your Ack?

As you commented, if there are no build dependency,
I think it better to be merged to devfreq.git for the history.

I'll apply patch2,3 to devfreq git for v5.8-rc1.

Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics