From: David Laight <David.Laight@ACULAB.COM>
To: 'Rasmus Villemoes' <linux@rasmusvillemoes.dk>,
Petr Mladek <pmladek@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Marco Elver <elver@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Alexander Potapenko <glider@google.com>,
"Dmitry Vyukov" <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: RE: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends
Date: Tue, 8 Aug 2023 11:17:49 +0000 [thread overview]
Message-ID: <96476d194c324092807a1c49f42d44bb@AcuMS.aculab.com> (raw)
In-Reply-To: <fdd7eb5d-2b76-d326-f059-5cdf652b5848@rasmusvillemoes.dk>
From: Rasmus Villemoes
> Sent: 07 August 2023 20:32
...
> No, please. Let's have a separate header for the functions defined in
> vsprintf.c. We really need to trim our headers down to something more
> manageable, and stop including everything from everywhere just because
> $this little macro needs $that little inline function.
The problem I see isn't things like kernel.h defining a few 'library'
functions, but deep nested includes that means that pretty much all
of the headers get pulled into all the compiles.
Some nested includes sequences can go through an "asm" header
that you might expect to be architecture specific stuff and then
include something like ioctl.h.
Add something like #define IO_WR @@@ to the top a C file
and then see where the compiler finds the duplicate definition.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-08-08 18:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 17:50 [PATCH v2 0/3] lib/vsprintf: Rework header inclusions Andy Shevchenko
2023-08-05 17:50 ` [PATCH v2 1/3] lib/vsprintf: Sort headers alphabetically Andy Shevchenko
2023-08-07 14:31 ` Petr Mladek
2023-08-07 14:53 ` Sergey Senozhatsky
2023-08-07 15:00 ` Andy Shevchenko
2023-08-07 14:58 ` Andy Shevchenko
2023-08-07 19:47 ` Rasmus Villemoes
2023-08-14 15:33 ` Petr Mladek
2023-08-05 17:50 ` [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Andy Shevchenko
2023-08-05 18:43 ` Andrew Morton
2023-08-05 21:31 ` Andy Shevchenko
2023-08-08 12:55 ` Andy Shevchenko
2023-08-07 15:03 ` Petr Mladek
2023-08-07 15:09 ` Andy Shevchenko
2023-08-07 15:11 ` Andy Shevchenko
2023-08-07 15:13 ` Andy Shevchenko
2023-08-08 6:41 ` Petr Mladek
2023-08-08 12:47 ` Andy Shevchenko
2023-08-10 8:15 ` Petr Mladek
2023-08-10 9:09 ` Rasmus Villemoes
2023-08-10 13:17 ` Andy Shevchenko
2023-08-10 14:17 ` Rasmus Villemoes
2023-08-11 19:28 ` Steven Rostedt
2023-08-14 11:16 ` Andy Shevchenko
2023-08-14 15:16 ` Petr Mladek
2023-08-15 9:58 ` David Laight
2023-08-09 8:48 ` David Laight
2023-08-10 13:13 ` Andy Shevchenko
2023-08-14 8:12 ` David Laight
2023-08-14 12:28 ` 'Andy Shevchenko'
2023-08-08 2:24 ` Steven Rostedt
2023-08-08 12:49 ` Andy Shevchenko
2023-08-07 19:31 ` Rasmus Villemoes
2023-08-08 11:17 ` David Laight [this message]
2023-08-05 17:50 ` [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in sprintf.h Andy Shevchenko
2023-08-07 6:00 ` Marco Elver
2023-08-07 15:06 ` Petr Mladek
2023-08-07 15:27 ` Andy Shevchenko
2023-08-14 15:38 ` [PATCH v2 0/3] lib/vsprintf: Rework header inclusions Petr Mladek
2023-08-14 16:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96476d194c324092807a1c49f42d44bb@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.