From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: alex.bennee@linaro.org, masami.hiramatsu@linaro.org,
ehem+xen@m5p.com, bertrand.marquis@arm.com,
andre.przywara@arm.com, Rahul.Singh@arm.com,
"Julien Grall" <jgrall@amazon.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <iwj@xenproject.org>, "Wei Liu" <wl@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 1/7] xen/acpi: Rework acpi_os_map_memory() and acpi_os_unmap_memory()
Date: Fri, 20 Nov 2020 17:03:53 +0100 [thread overview]
Message-ID: <96a97d2f-90dd-c4a7-5747-825c832ce56d@suse.com> (raw)
In-Reply-To: <20201023154156.6593-2-julien@xen.org>
On 23.10.2020 17:41, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The functions acpi_os_{un,}map_memory() are meant to be arch-agnostic
> while the __acpi_os_{un,}map_memory() are meant to be arch-specific.
>
> Currently, the former are still containing x86 specific code.
>
> To avoid this rather strange split, the generic helpers are reworked so
> they are arch-agnostic. This requires the introduction of a new helper
> __acpi_os_unmap_memory() that will undo any mapping done by
> __acpi_os_map_memory().
>
> Currently, the arch-helper for unmap is basically a no-op so it only
> returns whether the mapping was arch specific. But this will change
> in the future.
>
> Note that the x86 version of acpi_os_map_memory() was already able to
> able the 1MB region. Hence why there is no addition of new code.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> Tested-by: Rahul Singh <rahul.singh@arm.com>
This change breaks shutdown on x86. Either Dom0 no longer requests S5
(in which case I'd expect some data collection there to fail), or Xen
refuses the request. As a result, things go the machine_halt() path
instead. I've looked over the change again, but couldn't spot anything
yet which might explain the behavior. Yet reverting (just the non-Arm
parts, so I wouldn't have to revert multiple commits) made things
work again.
Jan
next prev parent reply other threads:[~2020-11-20 16:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:41 [PATCH v2 0/7] xen/arm: Unbreak ACPI Julien Grall
2020-10-23 15:41 ` [PATCH v2 1/7] xen/acpi: Rework acpi_os_map_memory() and acpi_os_unmap_memory() Julien Grall
2020-10-23 15:47 ` Jan Beulich
2020-10-24 0:06 ` Stefano Stabellini
2020-11-20 16:03 ` Jan Beulich [this message]
2020-11-20 17:44 ` Julien Grall
2020-11-23 8:31 ` Jan Beulich
2020-10-23 15:41 ` [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap Julien Grall
2020-10-24 0:16 ` Stefano Stabellini
2020-10-30 18:21 ` Julien Grall
2020-10-30 18:28 ` Stefano Stabellini
2020-10-30 18:29 ` Julien Grall
2020-10-30 18:34 ` Stefano Stabellini
2020-10-23 15:41 ` [PATCH v2 3/7] xen/arm: Check if the platform is not using ACPI before initializing Dom0less Julien Grall
2020-10-23 15:41 ` [PATCH v2 4/7] xen/arm: Introduce fw_unreserved_regions() and use it Julien Grall
2020-10-24 0:17 ` Stefano Stabellini
2020-10-23 15:41 ` [PATCH v2 5/7] xen/arm: acpi: add BAD_MADT_GICC_ENTRY() macro Julien Grall
2020-10-24 0:32 ` Stefano Stabellini
2020-10-30 18:46 ` Julien Grall
2020-10-23 15:41 ` [PATCH v2 6/7] xen/arm: gic-v2: acpi: Use the correct length for the GICC structure Julien Grall
2020-10-24 0:32 ` Stefano Stabellini
2020-10-24 0:45 ` Stefano Stabellini
2020-10-30 19:13 ` Julien Grall
2020-10-23 15:41 ` [PATCH v2 7/7] xen/arm: acpi: Allow Xen to boot with ACPI 5.1 Julien Grall
2020-10-24 0:33 ` Stefano Stabellini
2020-10-23 21:24 ` [PATCH v2 0/7] xen/arm: Unbreak ACPI Elliott Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96a97d2f-90dd-c4a7-5747-825c832ce56d@suse.com \
--to=jbeulich@suse.com \
--cc=Rahul.Singh@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=alex.bennee@linaro.org \
--cc=andre.przywara@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=ehem+xen@m5p.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=masami.hiramatsu@linaro.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.