From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org, alex.bennee@linaro.org,
masami.hiramatsu@linaro.org, ehem+xen@m5p.com,
bertrand.marquis@arm.com, andre.przywara@arm.com,
Rahul.Singh@arm.com, Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v2 7/7] xen/arm: acpi: Allow Xen to boot with ACPI 5.1
Date: Fri, 23 Oct 2020 17:33:11 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2010231732150.12247@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20201023154156.6593-8-julien@xen.org>
On Fri, 23 Oct 2020, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
>
> At the moment Xen requires the FADT ACPI table to be at least version
> 6.0, apparently because of some reliance on other ACPI v6.0 features.
>
> But actually this is overzealous, and Xen works now fine with ACPI v5.1.
>
> Let's relax the version check for the FADT table to allow QEMU to
> run the hypervisor with ACPI.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Changes in v2:
> - Patch added
> ---
> xen/arch/arm/acpi/boot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c
> index 55c3e5cbc834..7ea2990cb82c 100644
> --- a/xen/arch/arm/acpi/boot.c
> +++ b/xen/arch/arm/acpi/boot.c
> @@ -181,8 +181,8 @@ static int __init acpi_parse_fadt(struct acpi_table_header *table)
> * we only deal with ACPI 6.0 or newer revision to get GIC and SMP
> * boot protocol configuration data, or we will disable ACPI.
> */
> - if ( table->revision > 6
> - || (table->revision == 6 && fadt->minor_revision >= 0) )
> + if ( table->revision > 5
> + || (table->revision == 5 && fadt->minor_revision >= 1) )
> return 0;
>
> printk("Unsupported FADT revision %d.%d, should be 6.0+, will disable ACPI\n",
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-10-24 0:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:41 [PATCH v2 0/7] xen/arm: Unbreak ACPI Julien Grall
2020-10-23 15:41 ` [PATCH v2 1/7] xen/acpi: Rework acpi_os_map_memory() and acpi_os_unmap_memory() Julien Grall
2020-10-23 15:47 ` Jan Beulich
2020-10-24 0:06 ` Stefano Stabellini
2020-11-20 16:03 ` Jan Beulich
2020-11-20 17:44 ` Julien Grall
2020-11-23 8:31 ` Jan Beulich
2020-10-23 15:41 ` [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap Julien Grall
2020-10-24 0:16 ` Stefano Stabellini
2020-10-30 18:21 ` Julien Grall
2020-10-30 18:28 ` Stefano Stabellini
2020-10-30 18:29 ` Julien Grall
2020-10-30 18:34 ` Stefano Stabellini
2020-10-23 15:41 ` [PATCH v2 3/7] xen/arm: Check if the platform is not using ACPI before initializing Dom0less Julien Grall
2020-10-23 15:41 ` [PATCH v2 4/7] xen/arm: Introduce fw_unreserved_regions() and use it Julien Grall
2020-10-24 0:17 ` Stefano Stabellini
2020-10-23 15:41 ` [PATCH v2 5/7] xen/arm: acpi: add BAD_MADT_GICC_ENTRY() macro Julien Grall
2020-10-24 0:32 ` Stefano Stabellini
2020-10-30 18:46 ` Julien Grall
2020-10-23 15:41 ` [PATCH v2 6/7] xen/arm: gic-v2: acpi: Use the correct length for the GICC structure Julien Grall
2020-10-24 0:32 ` Stefano Stabellini
2020-10-24 0:45 ` Stefano Stabellini
2020-10-30 19:13 ` Julien Grall
2020-10-23 15:41 ` [PATCH v2 7/7] xen/arm: acpi: Allow Xen to boot with ACPI 5.1 Julien Grall
2020-10-24 0:33 ` Stefano Stabellini [this message]
2020-10-23 21:24 ` [PATCH v2 0/7] xen/arm: Unbreak ACPI Elliott Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010231732150.12247@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Rahul.Singh@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=alex.bennee@linaro.org \
--cc=andre.przywara@arm.com \
--cc=bertrand.marquis@arm.com \
--cc=ehem+xen@m5p.com \
--cc=jgrall@amazon.com \
--cc=julien.grall@arm.com \
--cc=julien@xen.org \
--cc=masami.hiramatsu@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.