From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"William Zhang" <william.zhang@broadcom.com>,
"Linux ARM List" <linux-arm-kernel@lists.infradead.org>
Cc: Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
kursad.oney@broadcom.com, f.fainelli@gmail.com,
anand.gore@broadcom.com, Ray Jui <rjui@broadcom.com>,
Russell King <linux@armlinux.org.uk>,
Scott Branden <sbranden@broadcom.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/8] arm: bcmbca: Move BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA
Date: Wed, 13 Jul 2022 09:36:37 -0700 [thread overview]
Message-ID: <97256a3a-6d54-9d60-06e9-480a8f2aa9e5@gmail.com> (raw)
In-Reply-To: <3cc9a340-1403-9a90-0d2b-49f719ca31fd@gmail.com>
On 7/13/22 08:31, Rafał Miłecki wrote:
> On 7.07.2022 09:00, William Zhang wrote:
>> Remove ARCH_BCM_63XX Kconfig for BCM63138 and merge its selections to
>> ARCH_BCMBCA. Delete bcm63xx.c as it is no longer needed.
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>
> What about ARCH_BCM_63XX references in
> 1. arch/arm/Kconfig.debug
That one was dealt with:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fa0ef5a086a05306fc5322bbda73459725eda923
> 2. arch/arm/configs/multi_v7_defconfig
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a65ee523a9e41d0bf046cf0107e6bbf05d068af2
patch 8/8 of this series
>
> Did you handle them in some other patchset?
>
>
> This change is probably going to break "make oldconfig" for users. Is
> there any kernel policy for that? Do we care about it? Should we leave
> old symbol as hidden and make ARCH_BCMBCA auto-selected if it's set?
I do not believe anyone but me was enabling CONFIG_ARCH_BCM_63XX so this
did not have any users until the BCA team decided to take over.
>
>
> Finally it'd probably be more clean to first introduce
> ARCH_BCMBCA_CORTEXA9 and then get rid of ARCH_BCM_63XX.
That is fair, however a bit late now that the pull requests have been
accepted by the soc maintainers.
Thanks!
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"William Zhang" <william.zhang@broadcom.com>,
"Linux ARM List" <linux-arm-kernel@lists.infradead.org>
Cc: Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
kursad.oney@broadcom.com, f.fainelli@gmail.com,
anand.gore@broadcom.com, Ray Jui <rjui@broadcom.com>,
Russell King <linux@armlinux.org.uk>,
Scott Branden <sbranden@broadcom.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/8] arm: bcmbca: Move BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA
Date: Wed, 13 Jul 2022 09:36:37 -0700 [thread overview]
Message-ID: <97256a3a-6d54-9d60-06e9-480a8f2aa9e5@gmail.com> (raw)
In-Reply-To: <3cc9a340-1403-9a90-0d2b-49f719ca31fd@gmail.com>
On 7/13/22 08:31, Rafał Miłecki wrote:
> On 7.07.2022 09:00, William Zhang wrote:
>> Remove ARCH_BCM_63XX Kconfig for BCM63138 and merge its selections to
>> ARCH_BCMBCA. Delete bcm63xx.c as it is no longer needed.
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>
> What about ARCH_BCM_63XX references in
> 1. arch/arm/Kconfig.debug
That one was dealt with:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fa0ef5a086a05306fc5322bbda73459725eda923
> 2. arch/arm/configs/multi_v7_defconfig
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a65ee523a9e41d0bf046cf0107e6bbf05d068af2
patch 8/8 of this series
>
> Did you handle them in some other patchset?
>
>
> This change is probably going to break "make oldconfig" for users. Is
> there any kernel policy for that? Do we care about it? Should we leave
> old symbol as hidden and make ARCH_BCMBCA auto-selected if it's set?
I do not believe anyone but me was enabling CONFIG_ARCH_BCM_63XX so this
did not have any users until the BCA team decided to take over.
>
>
> Finally it'd probably be more clean to first introduce
> ARCH_BCMBCA_CORTEXA9 and then get rid of ARCH_BCM_63XX.
That is fair, however a bit late now that the pull requests have been
accepted by the soc maintainers.
Thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-13 16:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:00 [PATCH v2 0/8] arm: bcmbca: Move BCM63138 SoC support under ARCH_BCMBCA William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-07 7:00 ` [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-08 20:58 ` Florian Fainelli
2022-07-08 20:58 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-08 20:59 ` Florian Fainelli
2022-07-13 15:26 ` Rafał Miłecki
2022-07-13 15:26 ` Rafał Miłecki
2022-07-13 16:35 ` Florian Fainelli
2022-07-13 16:35 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138 William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-08 20:59 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-08 21:00 ` Florian Fainelli
2022-07-08 21:00 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 5/8] arm: bcmbca: Move BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-13 15:31 ` Rafał Miłecki
2022-07-13 15:31 ` Rafał Miłecki
2022-07-13 16:36 ` Florian Fainelli [this message]
2022-07-13 16:36 ` Florian Fainelli
2022-07-13 15:35 ` Rafał Miłecki
2022-07-13 15:35 ` Rafał Miłecki
2022-07-13 16:24 ` Florian Fainelli
2022-07-13 16:24 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 6/8] arm: bcmbca: Add BCMBCA sub platforms William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-07 7:00 ` [PATCH v2 7/8] MAINTAINERS: Move BCM63138 to bcmbca arch entry William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-08 21:06 ` Florian Fainelli
2022-07-08 21:06 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 8/8] ARM: multi_v7_defconfig: Update configs for BCM63138 William Zhang
2022-07-07 7:00 ` William Zhang
2022-07-08 21:07 ` Florian Fainelli
2022-07-08 21:07 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97256a3a-6d54-9d60-06e9-480a8f2aa9e5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=joel.peshkin@broadcom.com \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=william.zhang@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.