From: Caesar Wang <caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
Date: Tue, 11 Jul 2017 16:04:38 +0800 [thread overview]
Message-ID: <972bed58-76c2-04e3-f2ab-d5b8065a92dd@gmail.com> (raw)
In-Reply-To: <20170710121227.14264-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Heiko,
在 2017年07月10日 20:12, Heiko Stuebner 写道:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index cb1d415d1201..e99d7ff4c939 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1135,7 +1135,7 @@
> };
>
> gpu: mali@ffa30000 {
> - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
If we remove the "arm,mali-midgard", the mali driver maybe need update
first.
From the lastest MALI driver on ARM supply, the compatible only two
property.
mali_kbase_core_linux.c
4163: { .compatible = "arm,malit6xx" },
4164: { .compatible = "arm,mali-midgard" },
That's odd with the two compatible, the driver should support the more.
-Caesar
> reg = <0xffa30000 0x10000>;
> interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: caesar.upstream@gmail.com (Caesar Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
Date: Tue, 11 Jul 2017 16:04:38 +0800 [thread overview]
Message-ID: <972bed58-76c2-04e3-f2ab-d5b8065a92dd@gmail.com> (raw)
In-Reply-To: <20170710121227.14264-2-heiko@sntech.de>
Heiko,
? 2017?07?10? 20:12, Heiko Stuebner ??:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index cb1d415d1201..e99d7ff4c939 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1135,7 +1135,7 @@
> };
>
> gpu: mali at ffa30000 {
> - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
If we remove the "arm,mali-midgard", the mali driver maybe need update
first.
From the lastest MALI driver on ARM supply, the compatible only two
property.
mali_kbase_core_linux.c
4163: { .compatible = "arm,malit6xx" },
4164: { .compatible = "arm,mali-midgard" },
That's odd with the two compatible, the driver should support the more.
-Caesar
> reg = <0xffa30000 0x10000>;
> interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
next prev parent reply other threads:[~2017-07-11 8:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 12:12 [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example Heiko Stuebner
2017-07-10 12:12 ` Heiko Stuebner
[not found] ` <20170710121227.14264-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-07-10 12:12 ` [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard compatible from rk3288 Heiko Stuebner
2017-07-10 12:12 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Heiko Stuebner
[not found] ` <20170710121227.14264-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-07-11 3:00 ` [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard " Rob Herring
2017-07-11 3:00 ` Rob Herring
2017-07-11 8:04 ` Caesar Wang [this message]
2017-07-11 8:04 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Caesar Wang
[not found] ` <972bed58-76c2-04e3-f2ab-d5b8065a92dd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-11 11:47 ` Heiko Stuebner
2017-07-11 11:47 ` Heiko Stuebner
2017-07-13 17:13 ` [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard " Heiko Stuebner
2017-07-13 17:13 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Heiko Stuebner
2017-07-11 3:03 ` [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example Rob Herring
2017-07-11 3:03 ` Rob Herring
2017-07-13 17:11 ` Heiko Stuebner
2017-07-13 17:11 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972bed58-76c2-04e3-f2ab-d5b8065a92dd@gmail.com \
--to=caesar.upstream-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.