From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Corentin Labbe <clabbe@baylibre.com>,
davem@davemloft.net, heiko@sntech.de,
herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, p.zabel@pengutronix.de,
robh+dt@kernel.org, sboyd@kernel.org
Cc: ricardo@pardini.net, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: crypto: add support for rockchip,crypto-rk3588
Date: Tue, 7 Nov 2023 17:40:24 +0100 [thread overview]
Message-ID: <97ae9fa0-0a6c-41d2-8a6c-1706b920d7ea@linaro.org> (raw)
In-Reply-To: <20231107155532.3747113-2-clabbe@baylibre.com>
On 07/11/2023 16:55, Corentin Labbe wrote:
> Add device tree binding documentation for the Rockchip cryptographic
> offloader V2.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../crypto/rockchip,rk3588-crypto.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
> new file mode 100644
> index 000000000000..07024cf4fb0e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/rockchip,rk3588-crypto.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip cryptographic offloader V2
v2? Where is any documentation of this versioning? From where does it
come from?
> +
> +maintainers:
> + - Corentin Labbe <clabbe@baylibre.com>
> +
> +properties:
> + compatible:
> + enum:
> + - rockchip,rk3568-crypto
> + - rockchip,rk3588-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 3
You also must describe the items instead.
Where do you see any binding using minItems alone?
> +
> + clock-names:
> + items:
> + - const: core
> + - const: a
> + - const: h
> +
> + resets:
> + minItems: 1
No, maxItems.
> +
> + reset-names:
> + items:
> + - const: core
Drop reset-names, not really needed and not useful.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Corentin Labbe <clabbe@baylibre.com>,
davem@davemloft.net, heiko@sntech.de,
herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, p.zabel@pengutronix.de,
robh+dt@kernel.org, sboyd@kernel.org
Cc: ricardo@pardini.net, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: crypto: add support for rockchip,crypto-rk3588
Date: Tue, 7 Nov 2023 17:40:24 +0100 [thread overview]
Message-ID: <97ae9fa0-0a6c-41d2-8a6c-1706b920d7ea@linaro.org> (raw)
In-Reply-To: <20231107155532.3747113-2-clabbe@baylibre.com>
On 07/11/2023 16:55, Corentin Labbe wrote:
> Add device tree binding documentation for the Rockchip cryptographic
> offloader V2.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../crypto/rockchip,rk3588-crypto.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
> new file mode 100644
> index 000000000000..07024cf4fb0e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/rockchip,rk3588-crypto.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip cryptographic offloader V2
v2? Where is any documentation of this versioning? From where does it
come from?
> +
> +maintainers:
> + - Corentin Labbe <clabbe@baylibre.com>
> +
> +properties:
> + compatible:
> + enum:
> + - rockchip,rk3568-crypto
> + - rockchip,rk3588-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 3
You also must describe the items instead.
Where do you see any binding using minItems alone?
> +
> + clock-names:
> + items:
> + - const: core
> + - const: a
> + - const: h
> +
> + resets:
> + minItems: 1
No, maxItems.
> +
> + reset-names:
> + items:
> + - const: core
Drop reset-names, not really needed and not useful.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Corentin Labbe <clabbe@baylibre.com>,
davem@davemloft.net, heiko@sntech.de,
herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, p.zabel@pengutronix.de,
robh+dt@kernel.org, sboyd@kernel.org
Cc: ricardo@pardini.net, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: crypto: add support for rockchip,crypto-rk3588
Date: Tue, 7 Nov 2023 17:40:24 +0100 [thread overview]
Message-ID: <97ae9fa0-0a6c-41d2-8a6c-1706b920d7ea@linaro.org> (raw)
In-Reply-To: <20231107155532.3747113-2-clabbe@baylibre.com>
On 07/11/2023 16:55, Corentin Labbe wrote:
> Add device tree binding documentation for the Rockchip cryptographic
> offloader V2.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../crypto/rockchip,rk3588-crypto.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
> new file mode 100644
> index 000000000000..07024cf4fb0e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/rockchip,rk3588-crypto.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip cryptographic offloader V2
v2? Where is any documentation of this versioning? From where does it
come from?
> +
> +maintainers:
> + - Corentin Labbe <clabbe@baylibre.com>
> +
> +properties:
> + compatible:
> + enum:
> + - rockchip,rk3568-crypto
> + - rockchip,rk3588-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 3
You also must describe the items instead.
Where do you see any binding using minItems alone?
> +
> + clock-names:
> + items:
> + - const: core
> + - const: a
> + - const: h
> +
> + resets:
> + minItems: 1
No, maxItems.
> +
> + reset-names:
> + items:
> + - const: core
Drop reset-names, not really needed and not useful.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-07 16:40 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 15:55 [PATCH 0/6] crypto: rockchip: add support for rk3588/rk3568 Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` [PATCH 1/6] dt-bindings: crypto: add support for rockchip,crypto-rk3588 Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 16:40 ` Krzysztof Kozlowski [this message]
2023-11-07 16:40 ` Krzysztof Kozlowski
2023-11-07 16:40 ` Krzysztof Kozlowski
2023-11-20 12:37 ` Corentin LABBE
2023-11-20 12:37 ` Corentin LABBE
2023-11-20 12:37 ` Corentin LABBE
2023-11-21 9:04 ` Krzysztof Kozlowski
2023-11-21 9:04 ` Krzysztof Kozlowski
2023-11-21 9:04 ` Krzysztof Kozlowski
2023-11-07 15:55 ` [PATCH 2/6] MAINTAINERS: add new dt-binding doc to the right entry Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 16:20 ` Krzysztof Kozlowski
2023-11-07 16:20 ` Krzysztof Kozlowski
2023-11-07 16:20 ` Krzysztof Kozlowski
2023-11-20 12:37 ` Corentin LABBE
2023-11-20 12:37 ` Corentin LABBE
2023-11-20 12:37 ` Corentin LABBE
2023-11-07 15:55 ` [PATCH 3/6] ARM64: dts: rk3588: add crypto node Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:59 ` Heiko Stübner
2023-11-07 15:59 ` Heiko Stübner
2023-11-07 15:59 ` Heiko Stübner
2023-11-20 12:38 ` Corentin LABBE
2023-11-20 12:38 ` Corentin LABBE
2023-11-20 12:38 ` Corentin LABBE
2023-11-07 16:20 ` Krzysztof Kozlowski
2023-11-07 16:20 ` Krzysztof Kozlowski
2023-11-07 16:20 ` Krzysztof Kozlowski
2023-11-20 12:38 ` Corentin LABBE
2023-11-20 12:38 ` Corentin LABBE
2023-11-20 12:38 ` Corentin LABBE
2023-11-07 15:55 ` [PATCH 4/6] ARM64: dts: rk356x: " Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 16:00 ` Heiko Stübner
2023-11-07 16:00 ` Heiko Stübner
2023-11-07 16:00 ` Heiko Stübner
2023-11-07 16:21 ` Krzysztof Kozlowski
2023-11-07 16:21 ` Krzysztof Kozlowski
2023-11-07 16:21 ` Krzysztof Kozlowski
2023-11-07 15:55 ` [PATCH 5/6] reset: rockchip: secure reset must be used by SCMI Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 16:21 ` Krzysztof Kozlowski
2023-11-07 16:21 ` Krzysztof Kozlowski
2023-11-07 16:21 ` Krzysztof Kozlowski
2023-11-07 17:35 ` Heiko Stübner
2023-11-07 17:35 ` Heiko Stübner
2023-11-07 17:35 ` Heiko Stübner
2023-11-07 17:45 ` Krzysztof Kozlowski
2023-11-07 17:45 ` Krzysztof Kozlowski
2023-11-07 17:45 ` Krzysztof Kozlowski
2023-11-11 20:51 ` Sebastian Reichel
2023-11-11 20:51 ` Sebastian Reichel
2023-11-11 20:51 ` Sebastian Reichel
2023-11-11 21:28 ` Krzysztof Kozlowski
2023-11-11 21:28 ` Krzysztof Kozlowski
2023-11-11 21:28 ` Krzysztof Kozlowski
2023-11-12 20:26 ` Sebastian Reichel
2023-11-12 20:26 ` Sebastian Reichel
2023-11-12 20:26 ` Sebastian Reichel
2023-11-20 12:42 ` Corentin LABBE
2023-11-20 12:42 ` Corentin LABBE
2023-11-20 12:42 ` Corentin LABBE
2023-11-07 15:55 ` [PATCH 6/6] crypto: rockchip: add rk3588 driver Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 15:55 ` Corentin Labbe
2023-11-07 16:35 ` Krzysztof Kozlowski
2023-11-07 16:35 ` Krzysztof Kozlowski
2023-11-07 16:35 ` Krzysztof Kozlowski
2023-11-07 16:42 ` Krzysztof Kozlowski
2023-11-07 16:42 ` Krzysztof Kozlowski
2023-11-07 16:42 ` Krzysztof Kozlowski
2023-11-07 16:56 ` Krzysztof Kozlowski
2023-11-07 16:56 ` Krzysztof Kozlowski
2023-11-07 16:56 ` Krzysztof Kozlowski
2023-11-08 2:51 ` kernel test robot
2023-11-12 14:04 ` Aw: " Frank Wunderlich
2023-11-12 14:04 ` Frank Wunderlich
2023-11-12 14:04 ` Frank Wunderlich
2023-11-20 12:48 ` Corentin LABBE
2023-11-20 12:48 ` Corentin LABBE
2023-11-20 12:48 ` Corentin LABBE
2023-11-24 15:05 ` Aw: " Frank Wunderlich
2023-11-24 15:05 ` Frank Wunderlich
2023-11-24 15:05 ` Frank Wunderlich
2023-11-27 11:47 ` Corentin LABBE
2023-11-27 11:47 ` Corentin LABBE
2023-11-27 11:47 ` Corentin LABBE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ae9fa0-0a6c-41d2-8a6c-1706b920d7ea@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=ricardo@pardini.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.