From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
chrome-platform@lists.linux.dev,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Cai Huoqing <cai.huoqing@linux.dev>,
Benjamin Fair <benjaminfair@google.com>,
Jishnu Prakash <quic_jprakash@quicinc.com>,
Linus Walleij <linus.walleij@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Amit Kucheria <amitk@kernel.org>, Andy Gross <agross@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Haibo Chen <haibo.chen@nxp.com>,
Benson Leung <bleung@chromium.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Christophe Branchereau <cbranchereau@gmail.com>,
Patrick Venture <venture@google.com>,
Arnd Bergmann <arnd@arndb.de>, Nancy Yuen <yuenn@google.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Gwendal Grignou <gwendal@chromium.org>,
Saravanan Sekar <sravanhome@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Thara Gopinath <thara.gopinath@linaro.org>,
Avi Fishman <avifishman70@gmail.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Jonathan Cameron <jic23@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Shawn Guo <shawnguo@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Fabio Estevam <festevam@gmail.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Eugen Hristev <eugen.hristev@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 24/34] iio: inkern: move to fwnode properties
Date: Fri, 10 Jun 2022 22:01:09 +0200 [thread overview]
Message-ID: <97b9278953d923008a4c1230ca9bd354117e7213.camel@gmail.com> (raw)
In-Reply-To: <CAHp75Vf6dYFR8TESk6oj=SFiXmw-tBAa9Fz-jhRk57ARumxzhA@mail.gmail.com>
On Fri, 2022-06-10 at 17:19 +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 10:48 AM Nuno Sá <nuno.sa@analog.com> wrote:
> >
> > This moves the IIO in kernel interface to use fwnode properties and
> > thus
> > be firmware agnostic.
> >
> > Note that the interface is still not firmware agnostic. At this
> > point we
> > have both OF and fwnode interfaces so that we don't break any user.
> > On
> > top of this we also want to have a per driver conversion and that
> > is the
> > main reason we have both of_xlate() and fwnode_xlate() support.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Thanks!
>
> A few nit-picks below, though.
>
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > drivers/iio/inkern.c | 145 +++++++++++++++++++------------
> > ----
> > include/linux/iio/consumer.h | 36 +++++----
> > include/linux/iio/iio.h | 5 ++
> > 3 files changed, 105 insertions(+), 81 deletions(-)
> >
> > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> > index dde47324b826..1d519b0cacea 100644
> > --- a/drivers/iio/inkern.c
> > +++ b/drivers/iio/inkern.c
> > @@ -5,6 +5,7 @@
> > */
> > #include <linux/err.h>
> > #include <linux/export.h>
> > +#include <linux/property.h>
> > #include <linux/slab.h>
> > #include <linux/mutex.h>
> > #include <linux/of.h>
> > @@ -117,15 +118,13 @@ static const struct iio_chan_spec
> > return chan;
> > }
> >
> > -#ifdef CONFIG_OF
> > -
> > static int iio_dev_node_match(struct device *dev, const void
> > *data)
> > {
> > - return dev->of_node == data && dev->type ==
> > &iio_device_type;
> > + return device_match_fwnode(dev, data) && dev->type ==
> > &iio_device_type;
> > }
> >
> > /**
> > - * __of_iio_simple_xlate - translate iiospec to the IIO channel
> > index
> > + * __fwnode_iio_simple_xlate - translate iiospec to the IIO
> > channel index
> > * @indio_dev: pointer to the iio_dev structure
> > * @iiospec: IIO specifier as found in the device tree
> > *
> > @@ -134,14 +133,14 @@ static int iio_dev_node_match(struct device
> > *dev, const void *data)
> > * whether IIO index is less than num_channels (that is specified
> > in the
> > * iio_dev).
> > */
> > -static int __of_iio_simple_xlate(struct iio_dev *indio_dev,
> > - const struct of_phandle_args
> > *iiospec)
> > +static int __fwnode_iio_simple_xlate(struct iio_dev *indio_dev,
> > + const struct
> > fwnode_reference_args *iiospec)
> > {
> > - if (!iiospec->args_count)
> > + if (!iiospec->nargs)
> > return 0;
> >
> > if (iiospec->args[0] >= indio_dev->num_channels) {
> > - dev_err(&indio_dev->dev, "invalid channel index
> > %u\n",
> > + dev_err(&indio_dev->dev, "invalid channel index
> > %llu\n",
> > iiospec->args[0]);
> > return -EINVAL;
> > }
> > @@ -149,34 +148,56 @@ static int __of_iio_simple_xlate(struct
> > iio_dev *indio_dev,
> > return iiospec->args[0];
> > }
> >
> > -static int __of_iio_channel_get(struct iio_channel *channel,
> > - struct device_node *np, int index)
> > +/*
> > + * Simple helper to copy fwnode_reference_args into
> > of_phandle_args so we
> > + * can pass it to of_xlate(). Ultimate goal is to drop this
> > together with
> > + * of_xlate().
> > + */
> > +static int __fwnode_to_of_xlate(struct iio_dev *indio_dev,
> > + const struct fwnode_reference_args
> > *iiospec)
> > +{
> > + struct of_phandle_args of_args;
> > + unsigned int i;
> > +
> > + of_args.args_count = iiospec->nargs;
> > + of_args.np = to_of_node(iiospec->fwnode);
> > +
> > + for (i = 0; i < MAX_PHANDLE_ARGS; i++)
> > + of_args.args[i] = i < iiospec->nargs ? iiospec-
> > >args[i] : 0;
> > +
> > + return indio_dev->info->of_xlate(indio_dev, &of_args);
> > +}
>
> Ah, now I realized that it's a bit more complicated than just
> to_of_node() :-)
>
Yeah, of_fwnode_get_reference_args() was helpfull. But I based myself
too much on it. On a second look, I guess ARRAY_SIZE(of_args.args)
would be better than MAX_PHANDLE_ARGS.
> > +static int __fwnode_iio_channel_get(struct iio_channel *channel,
> > + struct fwnode_handle *fwnode,
> > int index)
> > {
> > struct device *idev;
> > struct iio_dev *indio_dev;
> > int err;
> > - struct of_phandle_args iiospec;
> > + struct fwnode_reference_args iiospec;
>
> At the same point you can move it up in the block to make a long line
> first.
Can do that...
>
> > - err = of_parse_phandle_with_args(np, "io-channels",
> > - "#io-channel-cells",
> > - index, &iiospec);
> > + err = fwnode_property_get_reference_args(fwnode, "io-
> > channels",
> > + "#io-channel-
> > cells", 0,
> > + index, &iiospec);
> > if (err)
> > return err;
> >
> > - idev = bus_find_device(&iio_bus_type, NULL, iiospec.np,
> > + idev = bus_find_device(&iio_bus_type, NULL, iiospec.fwnode,
> > iio_dev_node_match);
>
> Wondering if this
> https://elixir.bootlin.com/linux/v5.19-rc1/C/ident/bus_find_device_by_fwnode
> can be utilized (yes, I noticed iio_device_type above).
Hmm, at first glance I would say we can use it. AFAICT, we are already
grabbing a node which contains "#io-channel-cells" which is very
indicative that is an IIO device. I also find it very unlikely to have
two IIO devices with the same fwnode (I guess it would be an issue even
in the old code) and even more unlikely two devices of diferent types
with the same fwnode?
Anyways, I guess Jonathan can help in here...
>
> > if (idev == NULL) {
> > - of_node_put(iiospec.np);
> > + fwnode_handle_put(iiospec.fwnode);
> > return -EPROBE_DEFER;
> > }
> >
> > indio_dev = dev_to_iio_dev(idev);
> > channel->indio_dev = indio_dev;
> > if (indio_dev->info->of_xlate)
> > - index = indio_dev->info->of_xlate(indio_dev,
> > &iiospec);
> > + index = __fwnode_to_of_xlate(indio_dev, &iiospec);
> > + else if (indio_dev->info->fwnode_xlate)
> > + index = indio_dev->info->fwnode_xlate(indio_dev,
> > &iiospec);
> > else
> > - index = __of_iio_simple_xlate(indio_dev, &iiospec);
> > - of_node_put(iiospec.np);
> > + index = __fwnode_iio_simple_xlate(indio_dev,
> > &iiospec);
> > + fwnode_handle_put(iiospec.fwnode);
> > if (index < 0)
> > goto err_put;
> > channel->channel = &indio_dev->channels[index];
> > @@ -188,7 +209,8 @@ static int __of_iio_channel_get(struct
> > iio_channel *channel,
> > return index;
> > }
> >
> > -static struct iio_channel *of_iio_channel_get(struct device_node
> > *np, int index)
> > +static struct iio_channel *fwnode_iio_channel_get(struct
> > fwnode_handle *fwnode,
> > + int index)
> > {
> > struct iio_channel *channel;
> > int err;
> > @@ -200,7 +222,7 @@ static struct iio_channel
> > *of_iio_channel_get(struct device_node *np, int index)
> > if (channel == NULL)
> > return ERR_PTR(-ENOMEM);
> >
> > - err = __of_iio_channel_get(channel, np, index);
> > + err = __fwnode_iio_channel_get(channel, fwnode, index);
> > if (err)
> > goto err_free_channel;
> >
> > @@ -211,9 +233,9 @@ static struct iio_channel
> > *of_iio_channel_get(struct device_node *np, int index)
> > return ERR_PTR(err);
> > }
> >
> > -struct iio_channel *__of_iio_channel_get_by_name(struct
> > device_node *np,
> > - const char *name,
> > - bool
> > *parent_lookup)
> > +struct iio_channel *
> > +__fwnode_iio_channel_get_by_name(struct fwnode_handle *fwnode,
> > const char *name,
> > + bool *parent_lookup)
> > {
> > struct iio_channel *chan;
> > int index = 0;
> > @@ -221,32 +243,34 @@ struct iio_channel
> > *__of_iio_channel_get_by_name(struct device_node *np,
> > /*
> > * For named iio channels, first look up the name in the
> > * "io-channel-names" property. If it cannot be found, the
> > - * index will be an error code, and of_iio_channel_get()
> > + * index will be an error code, and
> > fwnode_iio_channel_get()
> > * will fail.
> > */
> > if (name)
> > - index = of_property_match_string(np, "io-channel-
> > names", name);
> > + index = fwnode_property_match_string(fwnode, "io-
> > channel-names",
> > + name);
> >
> > - chan = of_iio_channel_get(np, index);
> > + chan = fwnode_iio_channel_get(fwnode, index);
> > if (!IS_ERR(chan) || PTR_ERR(chan) == -EPROBE_DEFER) {
> > *parent_lookup = false;
> > } else if (name && index >= 0) {
> > - pr_err("ERROR: could not get IIO channel
> > %pOF:%s(%i)\n",
> > - np, name ? name : "", index);
> > + pr_err("ERROR: could not get IIO channel
> > %pfw:%s(%i)\n",
> > + fwnode, name ? name : "", index);
>
> Since you are touching this line can you switch to name ?: "" and
> possibly move some parameters to the above line?
If it does not cross the 80limit col, sure.
>
> > *parent_lookup = false;
> > }
> >
> > return chan;
> > }
> >
> > -struct iio_channel *of_iio_channel_get_by_name(struct device_node
> > *np,
> > - const char *name)
> > +struct iio_channel *fwnode_iio_channel_get_by_name(struct
> > fwnode_handle *fwnode,
> > + const char
> > *name)
> > {
> > struct iio_channel *chan;
> > + struct fwnode_handle *parent;
> > bool parent_lookup = true;
> >
> > /* Walk up the tree of devices looking for a matching iio
> > channel */
> > - chan = __of_iio_channel_get_by_name(np, name,
> > &parent_lookup);
> > + chan = __fwnode_iio_channel_get_by_name(fwnode, name,
> > &parent_lookup);
> > if (!parent_lookup)
> > return chan;
> >
> > @@ -255,33 +279,34 @@ struct iio_channel
> > *of_iio_channel_get_by_name(struct device_node *np,
> > * If the parent node has a "io-channel-ranges" property,
> > * then we can try one of its channels.
> > */
> > - np = np->parent;
> > - while (np) {
> > - if (!of_get_property(np, "io-channel-ranges",
> > NULL))
> > + fwnode_for_each_parent_node(fwnode, parent) {
> > + if (!fwnode_property_present(parent, "io-channel-
> > ranges")) {
> > + fwnode_handle_put(parent);
> > return chan;
>
> break; ?
The return in place was a request from Jonathan in the RFC...
>
> (Yes, I understand pros and cons of each variant, up to you)
>
> > + }
> >
> > - chan = __of_iio_channel_get_by_name(np, name,
> > &parent_lookup);
> > - if (!parent_lookup)
> > + chan = __fwnode_iio_channel_get_by_name(parent,
> > name, &parent_lookup);
> > + if (!parent_lookup) {
> > + fwnode_handle_put(parent);
> > return chan;
>
> Ditto.
>
> > - np = np->parent;
> > + }
> > }
> >
> > return chan;
> > }
> > -EXPORT_SYMBOL_GPL(of_iio_channel_get_by_name);
> > +EXPORT_SYMBOL_GPL(fwnode_iio_channel_get_by_name);
>
> Wondering if we may move this to the IIO namespace.
I guess it makes sense but surely on a different patch...
>
> > -static struct iio_channel *of_iio_channel_get_all(struct device
> > *dev)
> > +static struct iio_channel *fwnode_iio_channel_get_all(struct
> > device *dev)
> > {
> > + struct fwnode_handle *fwnode = dev_fwnode(dev);
> > struct iio_channel *chans;
> > int i, mapind, nummaps = 0;
> > int ret;
> >
> > do {
> > - ret = of_parse_phandle_with_args(dev->of_node,
> > - "io-channels",
> > - "#io-channel-
> > cells",
> > - nummaps, NULL);
> > + ret = fwnode_property_get_reference_args(fwnode,
> > "io-channels",
> > + "#io-
> > channel-cells", 0,
> > + nummaps,
> > NULL);
> > if (ret < 0)
> > break;
> > } while (++nummaps);
> > @@ -294,10 +319,9 @@ static struct iio_channel
> > *of_iio_channel_get_all(struct device *dev)
> > if (chans == NULL)
> > return ERR_PTR(-ENOMEM);
> >
> > - /* Search for OF matches */
> > + /* Search for FW matches */
> > for (mapind = 0; mapind < nummaps; mapind++) {
> > - ret = __of_iio_channel_get(&chans[mapind], dev-
> > >of_node,
> > - mapind);
> > + ret = __fwnode_iio_channel_get(&chans[mapind],
> > fwnode, mapind);
> > if (ret)
> > goto error_free_chans;
> > }
> > @@ -310,15 +334,6 @@ static struct iio_channel
> > *of_iio_channel_get_all(struct device *dev)
> > return ERR_PTR(ret);
> > }
> >
> > -#else /* CONFIG_OF */
> > -
> > -static inline struct iio_channel *of_iio_channel_get_all(struct
> > device *dev)
> > -{
> > - return ERR_PTR(-ENODEV);
> > -}
> > -
> > -#endif /* CONFIG_OF */
> > -
> > static struct iio_channel *iio_channel_get_sys(const char *name,
> > const char
> > *channel_name)
> > {
> > @@ -379,8 +394,8 @@ struct iio_channel *iio_channel_get(struct
> > device *dev,
> > struct iio_channel *channel;
> >
> > if (dev) {
> > - channel = of_iio_channel_get_by_name(dev->of_node,
> > - channel_name);
> > + channel =
> > fwnode_iio_channel_get_by_name(dev_fwnode(dev),
> > +
> > channel_name);
> > if (!IS_ERR(channel) || PTR_ERR(channel) == -
> > EPROBE_DEFER)
> > return channel;
> > }
> > @@ -421,14 +436,14 @@ struct iio_channel
> > *devm_iio_channel_get(struct device *dev,
> > }
> > EXPORT_SYMBOL_GPL(devm_iio_channel_get);
> >
> > -struct iio_channel *devm_of_iio_channel_get_by_name(struct device
> > *dev,
> > - struct
> > device_node *np,
> > - const char
> > *channel_name)
> > +struct iio_channel *devm_fwnode_iio_channel_get_by_name(struct
> > device *dev,
> > + struct
> > fwnode_handle *fwnode,
> > + const char
> > *channel_name)
> > {
> > struct iio_channel *channel;
> > int ret;
> >
> > - channel = of_iio_channel_get_by_name(np, channel_name);
> > + channel = fwnode_iio_channel_get_by_name(fwnode,
> > channel_name);
> > if (IS_ERR(channel))
> > return channel;
> >
> > @@ -438,7 +453,7 @@ struct iio_channel
> > *devm_of_iio_channel_get_by_name(struct device *dev,
> >
> > return channel;
> > }
> > -EXPORT_SYMBOL_GPL(devm_of_iio_channel_get_by_name);
> > +EXPORT_SYMBOL_GPL(devm_fwnode_iio_channel_get_by_name);
> >
> > struct iio_channel *iio_channel_get_all(struct device *dev)
> > {
> > @@ -452,7 +467,7 @@ struct iio_channel *iio_channel_get_all(struct
> > device *dev)
> > if (dev == NULL)
> > return ERR_PTR(-EINVAL);
> >
> > - chans = of_iio_channel_get_all(dev);
> > + chans = fwnode_iio_channel_get_all(dev);
> > if (!IS_ERR(chans) || PTR_ERR(chans) == -EPROBE_DEFER)
> > return chans;
> >
> > diff --git a/include/linux/iio/consumer.h
> > b/include/linux/iio/consumer.h
> > index 5fa5957586cf..a96a714b5fdc 100644
> > --- a/include/linux/iio/consumer.h
> > +++ b/include/linux/iio/consumer.h
> > @@ -9,11 +9,13 @@
> >
> > #include <linux/types.h>
> > #include <linux/iio/types.h>
>
> > +#include <linux/of.h>
>
> Ordering. IIO has special meaning here, that's why it's last.
ok...
- Nuno Sá
WARNING: multiple messages have this Message-ID (diff)
From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
chrome-platform@lists.linux.dev,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Cai Huoqing <cai.huoqing@linux.dev>,
Benjamin Fair <benjaminfair@google.com>,
Jishnu Prakash <quic_jprakash@quicinc.com>,
Linus Walleij <linus.walleij@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Amit Kucheria <amitk@kernel.org>, Andy Gross <agross@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Haibo Chen <haibo.chen@nxp.com>,
Benson Leung <bleung@chromium.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Christophe Branchereau <cbranchereau@gmail.com>,
Patrick Venture <venture@google.com>,
Arnd Bergmann <arnd@arndb.de>, Nancy Yuen <yuenn@google.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Gwendal Grignou <gwendal@chromium.org>,
Saravanan Sekar <sravanhome@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Thara Gopinath <thara.gopinath@linaro.org>,
Avi Fishman <avifishman70@gmail.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Jonathan Cameron <jic23@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Shawn Guo <shawnguo@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Fabio Estevam <festevam@gmail.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Eugen Hristev <eugen.hristev@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 24/34] iio: inkern: move to fwnode properties
Date: Fri, 10 Jun 2022 22:01:09 +0200 [thread overview]
Message-ID: <97b9278953d923008a4c1230ca9bd354117e7213.camel@gmail.com> (raw)
In-Reply-To: <CAHp75Vf6dYFR8TESk6oj=SFiXmw-tBAa9Fz-jhRk57ARumxzhA@mail.gmail.com>
On Fri, 2022-06-10 at 17:19 +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 10:48 AM Nuno Sá <nuno.sa@analog.com> wrote:
> >
> > This moves the IIO in kernel interface to use fwnode properties and
> > thus
> > be firmware agnostic.
> >
> > Note that the interface is still not firmware agnostic. At this
> > point we
> > have both OF and fwnode interfaces so that we don't break any user.
> > On
> > top of this we also want to have a per driver conversion and that
> > is the
> > main reason we have both of_xlate() and fwnode_xlate() support.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Thanks!
>
> A few nit-picks below, though.
>
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > drivers/iio/inkern.c | 145 +++++++++++++++++++------------
> > ----
> > include/linux/iio/consumer.h | 36 +++++----
> > include/linux/iio/iio.h | 5 ++
> > 3 files changed, 105 insertions(+), 81 deletions(-)
> >
> > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> > index dde47324b826..1d519b0cacea 100644
> > --- a/drivers/iio/inkern.c
> > +++ b/drivers/iio/inkern.c
> > @@ -5,6 +5,7 @@
> > */
> > #include <linux/err.h>
> > #include <linux/export.h>
> > +#include <linux/property.h>
> > #include <linux/slab.h>
> > #include <linux/mutex.h>
> > #include <linux/of.h>
> > @@ -117,15 +118,13 @@ static const struct iio_chan_spec
> > return chan;
> > }
> >
> > -#ifdef CONFIG_OF
> > -
> > static int iio_dev_node_match(struct device *dev, const void
> > *data)
> > {
> > - return dev->of_node == data && dev->type ==
> > &iio_device_type;
> > + return device_match_fwnode(dev, data) && dev->type ==
> > &iio_device_type;
> > }
> >
> > /**
> > - * __of_iio_simple_xlate - translate iiospec to the IIO channel
> > index
> > + * __fwnode_iio_simple_xlate - translate iiospec to the IIO
> > channel index
> > * @indio_dev: pointer to the iio_dev structure
> > * @iiospec: IIO specifier as found in the device tree
> > *
> > @@ -134,14 +133,14 @@ static int iio_dev_node_match(struct device
> > *dev, const void *data)
> > * whether IIO index is less than num_channels (that is specified
> > in the
> > * iio_dev).
> > */
> > -static int __of_iio_simple_xlate(struct iio_dev *indio_dev,
> > - const struct of_phandle_args
> > *iiospec)
> > +static int __fwnode_iio_simple_xlate(struct iio_dev *indio_dev,
> > + const struct
> > fwnode_reference_args *iiospec)
> > {
> > - if (!iiospec->args_count)
> > + if (!iiospec->nargs)
> > return 0;
> >
> > if (iiospec->args[0] >= indio_dev->num_channels) {
> > - dev_err(&indio_dev->dev, "invalid channel index
> > %u\n",
> > + dev_err(&indio_dev->dev, "invalid channel index
> > %llu\n",
> > iiospec->args[0]);
> > return -EINVAL;
> > }
> > @@ -149,34 +148,56 @@ static int __of_iio_simple_xlate(struct
> > iio_dev *indio_dev,
> > return iiospec->args[0];
> > }
> >
> > -static int __of_iio_channel_get(struct iio_channel *channel,
> > - struct device_node *np, int index)
> > +/*
> > + * Simple helper to copy fwnode_reference_args into
> > of_phandle_args so we
> > + * can pass it to of_xlate(). Ultimate goal is to drop this
> > together with
> > + * of_xlate().
> > + */
> > +static int __fwnode_to_of_xlate(struct iio_dev *indio_dev,
> > + const struct fwnode_reference_args
> > *iiospec)
> > +{
> > + struct of_phandle_args of_args;
> > + unsigned int i;
> > +
> > + of_args.args_count = iiospec->nargs;
> > + of_args.np = to_of_node(iiospec->fwnode);
> > +
> > + for (i = 0; i < MAX_PHANDLE_ARGS; i++)
> > + of_args.args[i] = i < iiospec->nargs ? iiospec-
> > >args[i] : 0;
> > +
> > + return indio_dev->info->of_xlate(indio_dev, &of_args);
> > +}
>
> Ah, now I realized that it's a bit more complicated than just
> to_of_node() :-)
>
Yeah, of_fwnode_get_reference_args() was helpfull. But I based myself
too much on it. On a second look, I guess ARRAY_SIZE(of_args.args)
would be better than MAX_PHANDLE_ARGS.
> > +static int __fwnode_iio_channel_get(struct iio_channel *channel,
> > + struct fwnode_handle *fwnode,
> > int index)
> > {
> > struct device *idev;
> > struct iio_dev *indio_dev;
> > int err;
> > - struct of_phandle_args iiospec;
> > + struct fwnode_reference_args iiospec;
>
> At the same point you can move it up in the block to make a long line
> first.
Can do that...
>
> > - err = of_parse_phandle_with_args(np, "io-channels",
> > - "#io-channel-cells",
> > - index, &iiospec);
> > + err = fwnode_property_get_reference_args(fwnode, "io-
> > channels",
> > + "#io-channel-
> > cells", 0,
> > + index, &iiospec);
> > if (err)
> > return err;
> >
> > - idev = bus_find_device(&iio_bus_type, NULL, iiospec.np,
> > + idev = bus_find_device(&iio_bus_type, NULL, iiospec.fwnode,
> > iio_dev_node_match);
>
> Wondering if this
> https://elixir.bootlin.com/linux/v5.19-rc1/C/ident/bus_find_device_by_fwnode
> can be utilized (yes, I noticed iio_device_type above).
Hmm, at first glance I would say we can use it. AFAICT, we are already
grabbing a node which contains "#io-channel-cells" which is very
indicative that is an IIO device. I also find it very unlikely to have
two IIO devices with the same fwnode (I guess it would be an issue even
in the old code) and even more unlikely two devices of diferent types
with the same fwnode?
Anyways, I guess Jonathan can help in here...
>
> > if (idev == NULL) {
> > - of_node_put(iiospec.np);
> > + fwnode_handle_put(iiospec.fwnode);
> > return -EPROBE_DEFER;
> > }
> >
> > indio_dev = dev_to_iio_dev(idev);
> > channel->indio_dev = indio_dev;
> > if (indio_dev->info->of_xlate)
> > - index = indio_dev->info->of_xlate(indio_dev,
> > &iiospec);
> > + index = __fwnode_to_of_xlate(indio_dev, &iiospec);
> > + else if (indio_dev->info->fwnode_xlate)
> > + index = indio_dev->info->fwnode_xlate(indio_dev,
> > &iiospec);
> > else
> > - index = __of_iio_simple_xlate(indio_dev, &iiospec);
> > - of_node_put(iiospec.np);
> > + index = __fwnode_iio_simple_xlate(indio_dev,
> > &iiospec);
> > + fwnode_handle_put(iiospec.fwnode);
> > if (index < 0)
> > goto err_put;
> > channel->channel = &indio_dev->channels[index];
> > @@ -188,7 +209,8 @@ static int __of_iio_channel_get(struct
> > iio_channel *channel,
> > return index;
> > }
> >
> > -static struct iio_channel *of_iio_channel_get(struct device_node
> > *np, int index)
> > +static struct iio_channel *fwnode_iio_channel_get(struct
> > fwnode_handle *fwnode,
> > + int index)
> > {
> > struct iio_channel *channel;
> > int err;
> > @@ -200,7 +222,7 @@ static struct iio_channel
> > *of_iio_channel_get(struct device_node *np, int index)
> > if (channel == NULL)
> > return ERR_PTR(-ENOMEM);
> >
> > - err = __of_iio_channel_get(channel, np, index);
> > + err = __fwnode_iio_channel_get(channel, fwnode, index);
> > if (err)
> > goto err_free_channel;
> >
> > @@ -211,9 +233,9 @@ static struct iio_channel
> > *of_iio_channel_get(struct device_node *np, int index)
> > return ERR_PTR(err);
> > }
> >
> > -struct iio_channel *__of_iio_channel_get_by_name(struct
> > device_node *np,
> > - const char *name,
> > - bool
> > *parent_lookup)
> > +struct iio_channel *
> > +__fwnode_iio_channel_get_by_name(struct fwnode_handle *fwnode,
> > const char *name,
> > + bool *parent_lookup)
> > {
> > struct iio_channel *chan;
> > int index = 0;
> > @@ -221,32 +243,34 @@ struct iio_channel
> > *__of_iio_channel_get_by_name(struct device_node *np,
> > /*
> > * For named iio channels, first look up the name in the
> > * "io-channel-names" property. If it cannot be found, the
> > - * index will be an error code, and of_iio_channel_get()
> > + * index will be an error code, and
> > fwnode_iio_channel_get()
> > * will fail.
> > */
> > if (name)
> > - index = of_property_match_string(np, "io-channel-
> > names", name);
> > + index = fwnode_property_match_string(fwnode, "io-
> > channel-names",
> > + name);
> >
> > - chan = of_iio_channel_get(np, index);
> > + chan = fwnode_iio_channel_get(fwnode, index);
> > if (!IS_ERR(chan) || PTR_ERR(chan) == -EPROBE_DEFER) {
> > *parent_lookup = false;
> > } else if (name && index >= 0) {
> > - pr_err("ERROR: could not get IIO channel
> > %pOF:%s(%i)\n",
> > - np, name ? name : "", index);
> > + pr_err("ERROR: could not get IIO channel
> > %pfw:%s(%i)\n",
> > + fwnode, name ? name : "", index);
>
> Since you are touching this line can you switch to name ?: "" and
> possibly move some parameters to the above line?
If it does not cross the 80limit col, sure.
>
> > *parent_lookup = false;
> > }
> >
> > return chan;
> > }
> >
> > -struct iio_channel *of_iio_channel_get_by_name(struct device_node
> > *np,
> > - const char *name)
> > +struct iio_channel *fwnode_iio_channel_get_by_name(struct
> > fwnode_handle *fwnode,
> > + const char
> > *name)
> > {
> > struct iio_channel *chan;
> > + struct fwnode_handle *parent;
> > bool parent_lookup = true;
> >
> > /* Walk up the tree of devices looking for a matching iio
> > channel */
> > - chan = __of_iio_channel_get_by_name(np, name,
> > &parent_lookup);
> > + chan = __fwnode_iio_channel_get_by_name(fwnode, name,
> > &parent_lookup);
> > if (!parent_lookup)
> > return chan;
> >
> > @@ -255,33 +279,34 @@ struct iio_channel
> > *of_iio_channel_get_by_name(struct device_node *np,
> > * If the parent node has a "io-channel-ranges" property,
> > * then we can try one of its channels.
> > */
> > - np = np->parent;
> > - while (np) {
> > - if (!of_get_property(np, "io-channel-ranges",
> > NULL))
> > + fwnode_for_each_parent_node(fwnode, parent) {
> > + if (!fwnode_property_present(parent, "io-channel-
> > ranges")) {
> > + fwnode_handle_put(parent);
> > return chan;
>
> break; ?
The return in place was a request from Jonathan in the RFC...
>
> (Yes, I understand pros and cons of each variant, up to you)
>
> > + }
> >
> > - chan = __of_iio_channel_get_by_name(np, name,
> > &parent_lookup);
> > - if (!parent_lookup)
> > + chan = __fwnode_iio_channel_get_by_name(parent,
> > name, &parent_lookup);
> > + if (!parent_lookup) {
> > + fwnode_handle_put(parent);
> > return chan;
>
> Ditto.
>
> > - np = np->parent;
> > + }
> > }
> >
> > return chan;
> > }
> > -EXPORT_SYMBOL_GPL(of_iio_channel_get_by_name);
> > +EXPORT_SYMBOL_GPL(fwnode_iio_channel_get_by_name);
>
> Wondering if we may move this to the IIO namespace.
I guess it makes sense but surely on a different patch...
>
> > -static struct iio_channel *of_iio_channel_get_all(struct device
> > *dev)
> > +static struct iio_channel *fwnode_iio_channel_get_all(struct
> > device *dev)
> > {
> > + struct fwnode_handle *fwnode = dev_fwnode(dev);
> > struct iio_channel *chans;
> > int i, mapind, nummaps = 0;
> > int ret;
> >
> > do {
> > - ret = of_parse_phandle_with_args(dev->of_node,
> > - "io-channels",
> > - "#io-channel-
> > cells",
> > - nummaps, NULL);
> > + ret = fwnode_property_get_reference_args(fwnode,
> > "io-channels",
> > + "#io-
> > channel-cells", 0,
> > + nummaps,
> > NULL);
> > if (ret < 0)
> > break;
> > } while (++nummaps);
> > @@ -294,10 +319,9 @@ static struct iio_channel
> > *of_iio_channel_get_all(struct device *dev)
> > if (chans == NULL)
> > return ERR_PTR(-ENOMEM);
> >
> > - /* Search for OF matches */
> > + /* Search for FW matches */
> > for (mapind = 0; mapind < nummaps; mapind++) {
> > - ret = __of_iio_channel_get(&chans[mapind], dev-
> > >of_node,
> > - mapind);
> > + ret = __fwnode_iio_channel_get(&chans[mapind],
> > fwnode, mapind);
> > if (ret)
> > goto error_free_chans;
> > }
> > @@ -310,15 +334,6 @@ static struct iio_channel
> > *of_iio_channel_get_all(struct device *dev)
> > return ERR_PTR(ret);
> > }
> >
> > -#else /* CONFIG_OF */
> > -
> > -static inline struct iio_channel *of_iio_channel_get_all(struct
> > device *dev)
> > -{
> > - return ERR_PTR(-ENODEV);
> > -}
> > -
> > -#endif /* CONFIG_OF */
> > -
> > static struct iio_channel *iio_channel_get_sys(const char *name,
> > const char
> > *channel_name)
> > {
> > @@ -379,8 +394,8 @@ struct iio_channel *iio_channel_get(struct
> > device *dev,
> > struct iio_channel *channel;
> >
> > if (dev) {
> > - channel = of_iio_channel_get_by_name(dev->of_node,
> > - channel_name);
> > + channel =
> > fwnode_iio_channel_get_by_name(dev_fwnode(dev),
> > +
> > channel_name);
> > if (!IS_ERR(channel) || PTR_ERR(channel) == -
> > EPROBE_DEFER)
> > return channel;
> > }
> > @@ -421,14 +436,14 @@ struct iio_channel
> > *devm_iio_channel_get(struct device *dev,
> > }
> > EXPORT_SYMBOL_GPL(devm_iio_channel_get);
> >
> > -struct iio_channel *devm_of_iio_channel_get_by_name(struct device
> > *dev,
> > - struct
> > device_node *np,
> > - const char
> > *channel_name)
> > +struct iio_channel *devm_fwnode_iio_channel_get_by_name(struct
> > device *dev,
> > + struct
> > fwnode_handle *fwnode,
> > + const char
> > *channel_name)
> > {
> > struct iio_channel *channel;
> > int ret;
> >
> > - channel = of_iio_channel_get_by_name(np, channel_name);
> > + channel = fwnode_iio_channel_get_by_name(fwnode,
> > channel_name);
> > if (IS_ERR(channel))
> > return channel;
> >
> > @@ -438,7 +453,7 @@ struct iio_channel
> > *devm_of_iio_channel_get_by_name(struct device *dev,
> >
> > return channel;
> > }
> > -EXPORT_SYMBOL_GPL(devm_of_iio_channel_get_by_name);
> > +EXPORT_SYMBOL_GPL(devm_fwnode_iio_channel_get_by_name);
> >
> > struct iio_channel *iio_channel_get_all(struct device *dev)
> > {
> > @@ -452,7 +467,7 @@ struct iio_channel *iio_channel_get_all(struct
> > device *dev)
> > if (dev == NULL)
> > return ERR_PTR(-EINVAL);
> >
> > - chans = of_iio_channel_get_all(dev);
> > + chans = fwnode_iio_channel_get_all(dev);
> > if (!IS_ERR(chans) || PTR_ERR(chans) == -EPROBE_DEFER)
> > return chans;
> >
> > diff --git a/include/linux/iio/consumer.h
> > b/include/linux/iio/consumer.h
> > index 5fa5957586cf..a96a714b5fdc 100644
> > --- a/include/linux/iio/consumer.h
> > +++ b/include/linux/iio/consumer.h
> > @@ -9,11 +9,13 @@
> >
> > #include <linux/types.h>
> > #include <linux/iio/types.h>
>
> > +#include <linux/of.h>
>
> Ordering. IIO has special meaning here, that's why it's last.
ok...
- Nuno Sá
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Tomer Maimon <tmaimon77@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Tali Perry <tali.perry1@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Guenter Roeck <groeck@chromium.org>,
Fabio Estevam <festevam@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
chrome-platform@lists.linux.dev,
Lars-Peter Clausen <lars@metafoo.de>,
Benjamin Fair <benjaminfair@google.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Jishnu Prakash <quic_jprakash@quicinc.com>,
Haibo Chen <haibo.chen@nxp.com>, Andy Gross <agross@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Zhang Rui <rui.zhang@intel.com>,
Christophe Branchereau <cbranchereau@gmail.com>,
Saravanan Sekar <sravanhome@gmail.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Eugen Hristev <eugen.hristev@microchip.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Gwendal Grignou <gwendal@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Benson Leung <bleung@chromium.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
Thara Gopinath <thara.gopinath@linaro.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
Shawn Guo <shawnguo@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 24/34] iio: inkern: move to fwnode properties
Date: Fri, 10 Jun 2022 22:01:09 +0200 [thread overview]
Message-ID: <97b9278953d923008a4c1230ca9bd354117e7213.camel@gmail.com> (raw)
In-Reply-To: <CAHp75Vf6dYFR8TESk6oj=SFiXmw-tBAa9Fz-jhRk57ARumxzhA@mail.gmail.com>
On Fri, 2022-06-10 at 17:19 +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 10:48 AM Nuno Sá <nuno.sa@analog.com> wrote:
> >
> > This moves the IIO in kernel interface to use fwnode properties and
> > thus
> > be firmware agnostic.
> >
> > Note that the interface is still not firmware agnostic. At this
> > point we
> > have both OF and fwnode interfaces so that we don't break any user.
> > On
> > top of this we also want to have a per driver conversion and that
> > is the
> > main reason we have both of_xlate() and fwnode_xlate() support.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Thanks!
>
> A few nit-picks below, though.
>
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > drivers/iio/inkern.c | 145 +++++++++++++++++++------------
> > ----
> > include/linux/iio/consumer.h | 36 +++++----
> > include/linux/iio/iio.h | 5 ++
> > 3 files changed, 105 insertions(+), 81 deletions(-)
> >
> > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> > index dde47324b826..1d519b0cacea 100644
> > --- a/drivers/iio/inkern.c
> > +++ b/drivers/iio/inkern.c
> > @@ -5,6 +5,7 @@
> > */
> > #include <linux/err.h>
> > #include <linux/export.h>
> > +#include <linux/property.h>
> > #include <linux/slab.h>
> > #include <linux/mutex.h>
> > #include <linux/of.h>
> > @@ -117,15 +118,13 @@ static const struct iio_chan_spec
> > return chan;
> > }
> >
> > -#ifdef CONFIG_OF
> > -
> > static int iio_dev_node_match(struct device *dev, const void
> > *data)
> > {
> > - return dev->of_node == data && dev->type ==
> > &iio_device_type;
> > + return device_match_fwnode(dev, data) && dev->type ==
> > &iio_device_type;
> > }
> >
> > /**
> > - * __of_iio_simple_xlate - translate iiospec to the IIO channel
> > index
> > + * __fwnode_iio_simple_xlate - translate iiospec to the IIO
> > channel index
> > * @indio_dev: pointer to the iio_dev structure
> > * @iiospec: IIO specifier as found in the device tree
> > *
> > @@ -134,14 +133,14 @@ static int iio_dev_node_match(struct device
> > *dev, const void *data)
> > * whether IIO index is less than num_channels (that is specified
> > in the
> > * iio_dev).
> > */
> > -static int __of_iio_simple_xlate(struct iio_dev *indio_dev,
> > - const struct of_phandle_args
> > *iiospec)
> > +static int __fwnode_iio_simple_xlate(struct iio_dev *indio_dev,
> > + const struct
> > fwnode_reference_args *iiospec)
> > {
> > - if (!iiospec->args_count)
> > + if (!iiospec->nargs)
> > return 0;
> >
> > if (iiospec->args[0] >= indio_dev->num_channels) {
> > - dev_err(&indio_dev->dev, "invalid channel index
> > %u\n",
> > + dev_err(&indio_dev->dev, "invalid channel index
> > %llu\n",
> > iiospec->args[0]);
> > return -EINVAL;
> > }
> > @@ -149,34 +148,56 @@ static int __of_iio_simple_xlate(struct
> > iio_dev *indio_dev,
> > return iiospec->args[0];
> > }
> >
> > -static int __of_iio_channel_get(struct iio_channel *channel,
> > - struct device_node *np, int index)
> > +/*
> > + * Simple helper to copy fwnode_reference_args into
> > of_phandle_args so we
> > + * can pass it to of_xlate(). Ultimate goal is to drop this
> > together with
> > + * of_xlate().
> > + */
> > +static int __fwnode_to_of_xlate(struct iio_dev *indio_dev,
> > + const struct fwnode_reference_args
> > *iiospec)
> > +{
> > + struct of_phandle_args of_args;
> > + unsigned int i;
> > +
> > + of_args.args_count = iiospec->nargs;
> > + of_args.np = to_of_node(iiospec->fwnode);
> > +
> > + for (i = 0; i < MAX_PHANDLE_ARGS; i++)
> > + of_args.args[i] = i < iiospec->nargs ? iiospec-
> > >args[i] : 0;
> > +
> > + return indio_dev->info->of_xlate(indio_dev, &of_args);
> > +}
>
> Ah, now I realized that it's a bit more complicated than just
> to_of_node() :-)
>
Yeah, of_fwnode_get_reference_args() was helpfull. But I based myself
too much on it. On a second look, I guess ARRAY_SIZE(of_args.args)
would be better than MAX_PHANDLE_ARGS.
> > +static int __fwnode_iio_channel_get(struct iio_channel *channel,
> > + struct fwnode_handle *fwnode,
> > int index)
> > {
> > struct device *idev;
> > struct iio_dev *indio_dev;
> > int err;
> > - struct of_phandle_args iiospec;
> > + struct fwnode_reference_args iiospec;
>
> At the same point you can move it up in the block to make a long line
> first.
Can do that...
>
> > - err = of_parse_phandle_with_args(np, "io-channels",
> > - "#io-channel-cells",
> > - index, &iiospec);
> > + err = fwnode_property_get_reference_args(fwnode, "io-
> > channels",
> > + "#io-channel-
> > cells", 0,
> > + index, &iiospec);
> > if (err)
> > return err;
> >
> > - idev = bus_find_device(&iio_bus_type, NULL, iiospec.np,
> > + idev = bus_find_device(&iio_bus_type, NULL, iiospec.fwnode,
> > iio_dev_node_match);
>
> Wondering if this
> https://elixir.bootlin.com/linux/v5.19-rc1/C/ident/bus_find_device_by_fwnode
> can be utilized (yes, I noticed iio_device_type above).
Hmm, at first glance I would say we can use it. AFAICT, we are already
grabbing a node which contains "#io-channel-cells" which is very
indicative that is an IIO device. I also find it very unlikely to have
two IIO devices with the same fwnode (I guess it would be an issue even
in the old code) and even more unlikely two devices of diferent types
with the same fwnode?
Anyways, I guess Jonathan can help in here...
>
> > if (idev == NULL) {
> > - of_node_put(iiospec.np);
> > + fwnode_handle_put(iiospec.fwnode);
> > return -EPROBE_DEFER;
> > }
> >
> > indio_dev = dev_to_iio_dev(idev);
> > channel->indio_dev = indio_dev;
> > if (indio_dev->info->of_xlate)
> > - index = indio_dev->info->of_xlate(indio_dev,
> > &iiospec);
> > + index = __fwnode_to_of_xlate(indio_dev, &iiospec);
> > + else if (indio_dev->info->fwnode_xlate)
> > + index = indio_dev->info->fwnode_xlate(indio_dev,
> > &iiospec);
> > else
> > - index = __of_iio_simple_xlate(indio_dev, &iiospec);
> > - of_node_put(iiospec.np);
> > + index = __fwnode_iio_simple_xlate(indio_dev,
> > &iiospec);
> > + fwnode_handle_put(iiospec.fwnode);
> > if (index < 0)
> > goto err_put;
> > channel->channel = &indio_dev->channels[index];
> > @@ -188,7 +209,8 @@ static int __of_iio_channel_get(struct
> > iio_channel *channel,
> > return index;
> > }
> >
> > -static struct iio_channel *of_iio_channel_get(struct device_node
> > *np, int index)
> > +static struct iio_channel *fwnode_iio_channel_get(struct
> > fwnode_handle *fwnode,
> > + int index)
> > {
> > struct iio_channel *channel;
> > int err;
> > @@ -200,7 +222,7 @@ static struct iio_channel
> > *of_iio_channel_get(struct device_node *np, int index)
> > if (channel == NULL)
> > return ERR_PTR(-ENOMEM);
> >
> > - err = __of_iio_channel_get(channel, np, index);
> > + err = __fwnode_iio_channel_get(channel, fwnode, index);
> > if (err)
> > goto err_free_channel;
> >
> > @@ -211,9 +233,9 @@ static struct iio_channel
> > *of_iio_channel_get(struct device_node *np, int index)
> > return ERR_PTR(err);
> > }
> >
> > -struct iio_channel *__of_iio_channel_get_by_name(struct
> > device_node *np,
> > - const char *name,
> > - bool
> > *parent_lookup)
> > +struct iio_channel *
> > +__fwnode_iio_channel_get_by_name(struct fwnode_handle *fwnode,
> > const char *name,
> > + bool *parent_lookup)
> > {
> > struct iio_channel *chan;
> > int index = 0;
> > @@ -221,32 +243,34 @@ struct iio_channel
> > *__of_iio_channel_get_by_name(struct device_node *np,
> > /*
> > * For named iio channels, first look up the name in the
> > * "io-channel-names" property. If it cannot be found, the
> > - * index will be an error code, and of_iio_channel_get()
> > + * index will be an error code, and
> > fwnode_iio_channel_get()
> > * will fail.
> > */
> > if (name)
> > - index = of_property_match_string(np, "io-channel-
> > names", name);
> > + index = fwnode_property_match_string(fwnode, "io-
> > channel-names",
> > + name);
> >
> > - chan = of_iio_channel_get(np, index);
> > + chan = fwnode_iio_channel_get(fwnode, index);
> > if (!IS_ERR(chan) || PTR_ERR(chan) == -EPROBE_DEFER) {
> > *parent_lookup = false;
> > } else if (name && index >= 0) {
> > - pr_err("ERROR: could not get IIO channel
> > %pOF:%s(%i)\n",
> > - np, name ? name : "", index);
> > + pr_err("ERROR: could not get IIO channel
> > %pfw:%s(%i)\n",
> > + fwnode, name ? name : "", index);
>
> Since you are touching this line can you switch to name ?: "" and
> possibly move some parameters to the above line?
If it does not cross the 80limit col, sure.
>
> > *parent_lookup = false;
> > }
> >
> > return chan;
> > }
> >
> > -struct iio_channel *of_iio_channel_get_by_name(struct device_node
> > *np,
> > - const char *name)
> > +struct iio_channel *fwnode_iio_channel_get_by_name(struct
> > fwnode_handle *fwnode,
> > + const char
> > *name)
> > {
> > struct iio_channel *chan;
> > + struct fwnode_handle *parent;
> > bool parent_lookup = true;
> >
> > /* Walk up the tree of devices looking for a matching iio
> > channel */
> > - chan = __of_iio_channel_get_by_name(np, name,
> > &parent_lookup);
> > + chan = __fwnode_iio_channel_get_by_name(fwnode, name,
> > &parent_lookup);
> > if (!parent_lookup)
> > return chan;
> >
> > @@ -255,33 +279,34 @@ struct iio_channel
> > *of_iio_channel_get_by_name(struct device_node *np,
> > * If the parent node has a "io-channel-ranges" property,
> > * then we can try one of its channels.
> > */
> > - np = np->parent;
> > - while (np) {
> > - if (!of_get_property(np, "io-channel-ranges",
> > NULL))
> > + fwnode_for_each_parent_node(fwnode, parent) {
> > + if (!fwnode_property_present(parent, "io-channel-
> > ranges")) {
> > + fwnode_handle_put(parent);
> > return chan;
>
> break; ?
The return in place was a request from Jonathan in the RFC...
>
> (Yes, I understand pros and cons of each variant, up to you)
>
> > + }
> >
> > - chan = __of_iio_channel_get_by_name(np, name,
> > &parent_lookup);
> > - if (!parent_lookup)
> > + chan = __fwnode_iio_channel_get_by_name(parent,
> > name, &parent_lookup);
> > + if (!parent_lookup) {
> > + fwnode_handle_put(parent);
> > return chan;
>
> Ditto.
>
> > - np = np->parent;
> > + }
> > }
> >
> > return chan;
> > }
> > -EXPORT_SYMBOL_GPL(of_iio_channel_get_by_name);
> > +EXPORT_SYMBOL_GPL(fwnode_iio_channel_get_by_name);
>
> Wondering if we may move this to the IIO namespace.
I guess it makes sense but surely on a different patch...
>
> > -static struct iio_channel *of_iio_channel_get_all(struct device
> > *dev)
> > +static struct iio_channel *fwnode_iio_channel_get_all(struct
> > device *dev)
> > {
> > + struct fwnode_handle *fwnode = dev_fwnode(dev);
> > struct iio_channel *chans;
> > int i, mapind, nummaps = 0;
> > int ret;
> >
> > do {
> > - ret = of_parse_phandle_with_args(dev->of_node,
> > - "io-channels",
> > - "#io-channel-
> > cells",
> > - nummaps, NULL);
> > + ret = fwnode_property_get_reference_args(fwnode,
> > "io-channels",
> > + "#io-
> > channel-cells", 0,
> > + nummaps,
> > NULL);
> > if (ret < 0)
> > break;
> > } while (++nummaps);
> > @@ -294,10 +319,9 @@ static struct iio_channel
> > *of_iio_channel_get_all(struct device *dev)
> > if (chans == NULL)
> > return ERR_PTR(-ENOMEM);
> >
> > - /* Search for OF matches */
> > + /* Search for FW matches */
> > for (mapind = 0; mapind < nummaps; mapind++) {
> > - ret = __of_iio_channel_get(&chans[mapind], dev-
> > >of_node,
> > - mapind);
> > + ret = __fwnode_iio_channel_get(&chans[mapind],
> > fwnode, mapind);
> > if (ret)
> > goto error_free_chans;
> > }
> > @@ -310,15 +334,6 @@ static struct iio_channel
> > *of_iio_channel_get_all(struct device *dev)
> > return ERR_PTR(ret);
> > }
> >
> > -#else /* CONFIG_OF */
> > -
> > -static inline struct iio_channel *of_iio_channel_get_all(struct
> > device *dev)
> > -{
> > - return ERR_PTR(-ENODEV);
> > -}
> > -
> > -#endif /* CONFIG_OF */
> > -
> > static struct iio_channel *iio_channel_get_sys(const char *name,
> > const char
> > *channel_name)
> > {
> > @@ -379,8 +394,8 @@ struct iio_channel *iio_channel_get(struct
> > device *dev,
> > struct iio_channel *channel;
> >
> > if (dev) {
> > - channel = of_iio_channel_get_by_name(dev->of_node,
> > - channel_name);
> > + channel =
> > fwnode_iio_channel_get_by_name(dev_fwnode(dev),
> > +
> > channel_name);
> > if (!IS_ERR(channel) || PTR_ERR(channel) == -
> > EPROBE_DEFER)
> > return channel;
> > }
> > @@ -421,14 +436,14 @@ struct iio_channel
> > *devm_iio_channel_get(struct device *dev,
> > }
> > EXPORT_SYMBOL_GPL(devm_iio_channel_get);
> >
> > -struct iio_channel *devm_of_iio_channel_get_by_name(struct device
> > *dev,
> > - struct
> > device_node *np,
> > - const char
> > *channel_name)
> > +struct iio_channel *devm_fwnode_iio_channel_get_by_name(struct
> > device *dev,
> > + struct
> > fwnode_handle *fwnode,
> > + const char
> > *channel_name)
> > {
> > struct iio_channel *channel;
> > int ret;
> >
> > - channel = of_iio_channel_get_by_name(np, channel_name);
> > + channel = fwnode_iio_channel_get_by_name(fwnode,
> > channel_name);
> > if (IS_ERR(channel))
> > return channel;
> >
> > @@ -438,7 +453,7 @@ struct iio_channel
> > *devm_of_iio_channel_get_by_name(struct device *dev,
> >
> > return channel;
> > }
> > -EXPORT_SYMBOL_GPL(devm_of_iio_channel_get_by_name);
> > +EXPORT_SYMBOL_GPL(devm_fwnode_iio_channel_get_by_name);
> >
> > struct iio_channel *iio_channel_get_all(struct device *dev)
> > {
> > @@ -452,7 +467,7 @@ struct iio_channel *iio_channel_get_all(struct
> > device *dev)
> > if (dev == NULL)
> > return ERR_PTR(-EINVAL);
> >
> > - chans = of_iio_channel_get_all(dev);
> > + chans = fwnode_iio_channel_get_all(dev);
> > if (!IS_ERR(chans) || PTR_ERR(chans) == -EPROBE_DEFER)
> > return chans;
> >
> > diff --git a/include/linux/iio/consumer.h
> > b/include/linux/iio/consumer.h
> > index 5fa5957586cf..a96a714b5fdc 100644
> > --- a/include/linux/iio/consumer.h
> > +++ b/include/linux/iio/consumer.h
> > @@ -9,11 +9,13 @@
> >
> > #include <linux/types.h>
> > #include <linux/iio/types.h>
>
> > +#include <linux/of.h>
>
> Ordering. IIO has special meaning here, that's why it's last.
ok...
- Nuno Sá
next prev parent reply other threads:[~2022-06-10 20:01 UTC|newest]
Thread overview: 246+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 8:45 [PATCH 00/34] make iio inkern interface firmware agnostic Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` [PATCH 01/34] iio: adc: ad7606: explicitly add proper header files Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 13:59 ` Jonathan Cameron
2022-06-11 13:59 ` Jonathan Cameron
2022-06-11 13:59 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 02/34] iio: adc: ad7606_par: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:00 ` Jonathan Cameron
2022-06-11 14:00 ` Jonathan Cameron
2022-06-11 14:00 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 03/34] iio: adc: berlin2-adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:02 ` Jonathan Cameron
2022-06-11 14:02 ` Jonathan Cameron
2022-06-11 14:02 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 04/34] iio: adc: imx7d_adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:04 ` Jonathan Cameron
2022-06-11 14:04 ` Jonathan Cameron
2022-06-11 14:04 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 05/34] iio: adc: imx8qxp-adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:05 ` Jonathan Cameron
2022-06-11 14:05 ` Jonathan Cameron
2022-06-11 14:05 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 06/34] iio: adc: ingenic-adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 14:45 ` Andy Shevchenko
2022-06-10 14:45 ` Andy Shevchenko
2022-06-10 19:49 ` Nuno Sá
2022-06-10 19:49 ` Nuno Sá
2022-06-10 19:49 ` Nuno Sá
2022-06-11 14:07 ` Jonathan Cameron
2022-06-11 14:07 ` Jonathan Cameron
2022-06-11 14:07 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 07/34] iio: adc: mp2629_adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:08 ` Jonathan Cameron
2022-06-11 14:08 ` Jonathan Cameron
2022-06-11 14:08 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 08/34] iio: adc: mt6360-adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:09 ` Jonathan Cameron
2022-06-11 14:09 ` Jonathan Cameron
2022-06-11 14:09 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 09/34] iio: adc: npcm_adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:12 ` Jonathan Cameron
2022-06-11 14:12 ` Jonathan Cameron
2022-06-11 14:12 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 10/34] iio: adc: rzg2l_adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:13 ` Jonathan Cameron
2022-06-11 14:13 ` Jonathan Cameron
2022-06-11 14:13 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 11/34] iio: common: cros_ec_lid_angle: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:14 ` Jonathan Cameron
2022-06-11 14:14 ` Jonathan Cameron
2022-06-11 14:14 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 12/34] iio: common: cros_ec_sensors: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:16 ` Jonathan Cameron
2022-06-11 14:16 ` Jonathan Cameron
2022-06-11 14:16 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 13/34] iio: dac: stm32-dac: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:17 ` Jonathan Cameron
2022-06-11 14:17 ` Jonathan Cameron
2022-06-11 14:17 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 14/34] iio: dac: vf610_dac: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:19 ` Jonathan Cameron
2022-06-11 14:19 ` Jonathan Cameron
2022-06-11 14:19 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 15/34] iio: humidity: hts221_buffer: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 14:47 ` Andy Shevchenko
2022-06-10 14:47 ` Andy Shevchenko
2022-06-11 14:22 ` Jonathan Cameron
2022-06-11 14:22 ` Jonathan Cameron
2022-06-11 14:22 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 16/34] iio: light: cros_ec_light_prox: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:23 ` Jonathan Cameron
2022-06-11 14:23 ` Jonathan Cameron
2022-06-11 14:23 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 17/34] iio: pressure: cros_ec_baro: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` [PATCH 18/34] iio: trigger: stm32-lptimer-trigger: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` [PATCH 19/34] iio: core: drop of.h from iio.h Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 14:30 ` Jonathan Cameron
2022-06-11 14:30 ` Jonathan Cameron
2022-06-11 14:30 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 20/34] iio: inkern: only relase the device node when done with it Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 14:56 ` Andy Shevchenko
2022-06-10 14:56 ` Andy Shevchenko
2022-06-10 20:08 ` Nuno Sá
2022-06-10 20:08 ` Nuno Sá
2022-06-10 20:08 ` Nuno Sá
2022-06-11 14:59 ` Jonathan Cameron
2022-06-11 14:59 ` Jonathan Cameron
2022-06-11 14:59 ` Jonathan Cameron
2022-06-13 7:20 ` Nuno Sá
2022-06-13 7:20 ` Nuno Sá
2022-06-13 7:20 ` Nuno Sá
2022-06-18 14:03 ` Jonathan Cameron
2022-06-18 14:03 ` Jonathan Cameron
2022-06-18 14:13 ` Jonathan Cameron
2022-06-18 14:13 ` Jonathan Cameron
2022-06-18 17:30 ` Jonathan Cameron
2022-06-18 17:30 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 21/34] iio: inkern: fix return value in devm_of_iio_channel_get_by_name() Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 14:56 ` Andy Shevchenko
2022-06-10 14:56 ` Andy Shevchenko
2022-06-10 8:45 ` [PATCH 22/34] iio: inkern: only return error codes in iio_channel_get_*() APIs Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 15:05 ` Andy Shevchenko
2022-06-10 15:05 ` Andy Shevchenko
2022-06-10 19:48 ` Nuno Sá
2022-06-10 19:48 ` Nuno Sá
2022-06-10 19:48 ` Nuno Sá
2022-06-11 15:17 ` Jonathan Cameron
2022-06-11 15:17 ` Jonathan Cameron
2022-06-11 15:17 ` Jonathan Cameron
2022-06-13 7:06 ` Nuno Sá
2022-06-13 7:06 ` Nuno Sá
2022-06-13 7:06 ` Nuno Sá
2022-06-18 14:06 ` Jonathan Cameron
2022-06-18 14:06 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 23/34] iio: inkern: split of_iio_channel_get_by_name() Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 15:07 ` Andy Shevchenko
2022-06-10 15:07 ` Andy Shevchenko
2022-06-10 8:45 ` [PATCH 24/34] iio: inkern: move to fwnode properties Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 15:19 ` Andy Shevchenko
2022-06-10 15:19 ` Andy Shevchenko
2022-06-10 20:01 ` Nuno Sá [this message]
2022-06-10 20:01 ` Nuno Sá
2022-06-10 20:01 ` Nuno Sá
2022-06-11 15:30 ` Jonathan Cameron
2022-06-11 15:30 ` Jonathan Cameron
2022-06-11 15:30 ` Jonathan Cameron
2022-06-11 15:32 ` Jonathan Cameron
2022-06-11 15:32 ` Jonathan Cameron
2022-06-13 7:13 ` Nuno Sá
2022-06-18 14:09 ` Jonathan Cameron
2022-06-10 8:45 ` [PATCH 25/34] thermal: qcom: qcom-spmi-adc-tm5: convert to IIO fwnode API Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 15:20 ` Andy Shevchenko
2022-06-10 15:20 ` Andy Shevchenko
2022-06-10 19:42 ` Nuno Sá
2022-06-10 19:42 ` Nuno Sá
2022-06-10 19:42 ` Nuno Sá
2022-06-10 8:45 ` [PATCH 26/34] iio: adc: ingenic-adc: convert to IIO fwnode interface Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` [PATCH 27/34] iio: adc: ab8500-gpadc: convert to device properties Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-15 14:26 ` Linus Walleij
2022-06-15 14:26 ` Linus Walleij
2022-06-10 8:45 ` [PATCH 28/34] iio: adc: at91-sama5d2_adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` [PATCH 29/34] iio: adc: qcom-pm8xxx-xoadc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-15 14:27 ` Linus Walleij
2022-06-15 14:27 ` Linus Walleij
2022-06-10 8:45 ` [PATCH 30/34] iio: adc: qcom-spmi-vadc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-16 13:15 ` Linus Walleij
2022-06-16 13:15 ` Linus Walleij
2022-06-10 8:45 ` [PATCH 31/34] iio: adc: qcom-spmi-adc5: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-16 13:16 ` Linus Walleij
2022-06-16 13:16 ` Linus Walleij
2022-06-10 8:45 ` [PATCH 32/34] iio: adc: stm32-adc: " Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-11 15:47 ` Jonathan Cameron
2022-06-11 15:47 ` Jonathan Cameron
2022-06-11 15:47 ` Jonathan Cameron
2022-06-17 15:58 ` Fabrice Gasnier
2022-06-17 15:58 ` Fabrice Gasnier
2022-06-10 8:45 ` [PATCH 33/34] iio: inkern: remove OF dependencies Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` [PATCH 34/34] iio: inkern: fix coding style warnings Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 8:45 ` Nuno Sá
2022-06-10 15:53 ` Joe Simmons-Talbott
2022-06-10 15:53 ` Joe Simmons-Talbott
2022-06-10 15:53 ` Joe Simmons-Talbott
2022-06-10 19:51 ` Nuno Sá
2022-06-10 19:51 ` Nuno Sá
2022-06-10 19:51 ` Nuno Sá
2022-06-12 17:39 ` Geert Uytterhoeven
2022-06-12 17:39 ` Geert Uytterhoeven
2022-06-12 17:39 ` Geert Uytterhoeven
2022-06-13 7:23 ` Nuno Sá
2022-06-13 7:23 ` Nuno Sá
2022-06-13 7:23 ` Nuno Sá
2022-06-10 14:48 ` [PATCH 00/34] make iio inkern interface firmware agnostic Andy Shevchenko
2022-06-10 14:48 ` Andy Shevchenko
2022-06-10 15:28 ` Andy Shevchenko
2022-06-10 15:28 ` Andy Shevchenko
2022-06-11 15:50 ` Jonathan Cameron
2022-06-11 15:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97b9278953d923008a4c1230ca9bd354117e7213.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amitk@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=bleung@chromium.org \
--cc=cai.huoqing@linux.dev \
--cc=cbranchereau@gmail.com \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.lezcano@linaro.org \
--cc=eugen.hristev@microchip.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=openbmc@lists.ozlabs.org \
--cc=paul@crapouillou.net \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_jprakash@quicinc.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=thara.gopinath@linaro.org \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.