From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: YueHaibing <yuehaibing@huawei.com>
Cc: alsa-devel@alsa-project.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH -next] ASoC: atmel: Fix build error
Date: Thu, 17 Oct 2019 09:51:22 +0200 [thread overview]
Message-ID: <97c5adeb-ce12-f50a-f3e5-e187985ef073@free.fr> (raw)
In-Reply-To: <20190928081641.44232-1-yuehaibing@huawei.com>
On 28/09/2019 10:16, YueHaibing wrote:
> when do randbuilding, I got this error:
>
> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
> (.text+0x12f6): undefined reference to `atmel_pcm_pdc_platform_register'
>
> This is because SND_ATMEL_SOC_SSC_DMA=y, SND_ATMEL_SOC_SSC=y,
> but SND_ATMEL_SOC_SSC_PDC=m. Fix it bt reintroducing the default Kconfig.
A default doesn't prevent a user from picking the problematic config.
Shouldn't there be some kind of "depends on" clause?
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> sound/soc/atmel/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index f118c22..79e45f2 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -12,10 +12,14 @@ if SND_ATMEL_SOC
> config SND_ATMEL_SOC_PDC
> tristate
> depends on HAS_DMA
> + default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m
> + default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=y)
>
> config SND_ATMEL_SOC_DMA
> tristate
> select SND_SOC_GENERIC_DMAENGINE_PCM
> + default m if SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=m
> + default y if SND_ATMEL_SOC_SSC_DMA=y || (SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=y)
>
> config SND_ATMEL_SOC_SSC
> tristate
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: YueHaibing <yuehaibing@huawei.com>
Cc: alsa-devel@alsa-project.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] ASoC: atmel: Fix build error
Date: Thu, 17 Oct 2019 09:51:22 +0200 [thread overview]
Message-ID: <97c5adeb-ce12-f50a-f3e5-e187985ef073@free.fr> (raw)
In-Reply-To: <20190928081641.44232-1-yuehaibing@huawei.com>
On 28/09/2019 10:16, YueHaibing wrote:
> when do randbuilding, I got this error:
>
> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
> (.text+0x12f6): undefined reference to `atmel_pcm_pdc_platform_register'
>
> This is because SND_ATMEL_SOC_SSC_DMA=y, SND_ATMEL_SOC_SSC=y,
> but SND_ATMEL_SOC_SSC_PDC=m. Fix it bt reintroducing the default Kconfig.
A default doesn't prevent a user from picking the problematic config.
Shouldn't there be some kind of "depends on" clause?
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> sound/soc/atmel/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index f118c22..79e45f2 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -12,10 +12,14 @@ if SND_ATMEL_SOC
> config SND_ATMEL_SOC_PDC
> tristate
> depends on HAS_DMA
> + default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m
> + default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=y)
>
> config SND_ATMEL_SOC_DMA
> tristate
> select SND_SOC_GENERIC_DMAENGINE_PCM
> + default m if SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=m
> + default y if SND_ATMEL_SOC_SSC_DMA=y || (SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=y)
>
> config SND_ATMEL_SOC_SSC
> tristate
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-17 7:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 8:16 [PATCH -next] ASoC: atmel: Fix build error YueHaibing
2019-09-28 8:16 ` YueHaibing
2019-09-28 8:16 ` [alsa-devel] " YueHaibing
2019-09-30 15:58 ` Michał Mirosław
2019-09-30 15:58 ` Michał Mirosław
2019-09-30 15:58 ` [alsa-devel] " Michał Mirosław
2019-09-30 16:01 ` Michał Mirosław
2019-09-30 16:01 ` Michał Mirosław
2019-09-30 16:01 ` [alsa-devel] " Michał Mirosław
2019-10-17 7:32 ` Yuehaibing
2019-10-17 7:32 ` Yuehaibing
2019-10-17 7:32 ` [alsa-devel] " Yuehaibing
2019-10-17 11:11 ` Mark Brown
2019-10-17 11:11 ` Mark Brown
2019-10-17 11:11 ` [alsa-devel] " Mark Brown
2019-10-17 7:51 ` Marc Gonzalez [this message]
2019-10-17 7:51 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97c5adeb-ce12-f50a-f3e5-e187985ef073@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.