From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, dm-devel@redhat.com,
Song Liu <song@kernel.org>,
linux-raid@vger.kernel.org, Mike Snitzer <snitzer@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com,
Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: [PATCH v2 19/19] block: mark bio_add_page as __must_check
Date: Thu, 30 Mar 2023 03:44:01 -0700 [thread overview]
Message-ID: <981a2b8809dedbd6dd756d7af1df4251944f42b0.1680172791.git.johannes.thumshirn@wdc.com> (raw)
In-Reply-To: <cover.1680172791.git.johannes.thumshirn@wdc.com>
Now that all users of bio_add_page check for the return value, mark
bio_add_page as __must_check.
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
include/linux/bio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index d766be7152e1..0f8a8d7a6384 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -465,7 +465,7 @@ extern void bio_uninit(struct bio *);
void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf);
void bio_chain(struct bio *, struct bio *);
-int bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
+int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off);
extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *,
unsigned int, unsigned int);
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, Song Liu <song@kernel.org>,
dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
Andreas Gruenbacher <agruenba@redhat.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Matthew Wilcox <willy@infradead.org>,
cluster-devel@redhat.com, Chaitanya Kulkarni <kch@nvidia.com>,
Mike Snitzer <snitzer@kernel.org>, Ming Lei <ming.lei@redhat.com>,
linux-raid@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
David Sterba <dsterba@suse.com>,
linux-block@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-mm@kvack.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [dm-devel] [PATCH v2 19/19] block: mark bio_add_page as __must_check
Date: Thu, 30 Mar 2023 03:44:01 -0700 [thread overview]
Message-ID: <981a2b8809dedbd6dd756d7af1df4251944f42b0.1680172791.git.johannes.thumshirn@wdc.com> (raw)
In-Reply-To: <cover.1680172791.git.johannes.thumshirn@wdc.com>
Now that all users of bio_add_page check for the return value, mark
bio_add_page as __must_check.
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
include/linux/bio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index d766be7152e1..0f8a8d7a6384 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -465,7 +465,7 @@ extern void bio_uninit(struct bio *);
void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf);
void bio_chain(struct bio *, struct bio *);
-int bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
+int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off);
extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *,
unsigned int, unsigned int);
--
2.39.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 19/19] block: mark bio_add_page as __must_check
Date: Thu, 30 Mar 2023 03:44:01 -0700 [thread overview]
Message-ID: <981a2b8809dedbd6dd756d7af1df4251944f42b0.1680172791.git.johannes.thumshirn@wdc.com> (raw)
In-Reply-To: <cover.1680172791.git.johannes.thumshirn@wdc.com>
Now that all users of bio_add_page check for the return value, mark
bio_add_page as __must_check.
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
include/linux/bio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index d766be7152e1..0f8a8d7a6384 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -465,7 +465,7 @@ extern void bio_uninit(struct bio *);
void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf);
void bio_chain(struct bio *, struct bio *);
-int bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
+int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);
bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off);
extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *,
unsigned int, unsigned int);
--
2.39.2
next prev parent reply other threads:[~2023-03-30 10:47 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 10:43 [PATCH v2 00/19] bio: check return values of bio_add_page Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 01/19] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 02/19] drbd: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 03/19] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 04/19] fs: buffer: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 05/19] md: use __bio_add_page to add single page Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-31 17:47 ` Song Liu
2023-03-31 17:47 ` [Cluster-devel] " Song Liu
2023-03-31 17:47 ` [dm-devel] " Song Liu
2023-03-30 10:43 ` [PATCH v2 06/19] md: raid5-log: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-31 17:47 ` Song Liu
2023-03-31 17:47 ` [Cluster-devel] " Song Liu
2023-03-31 17:47 ` [dm-devel] " Song Liu
2023-03-30 10:43 ` [PATCH v2 07/19] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-31 17:47 ` Song Liu
2023-03-31 17:47 ` [Cluster-devel] " Song Liu
2023-03-31 17:47 ` [dm-devel] " Song Liu
2023-03-30 10:43 ` [PATCH v2 08/19] btrfs: repair: use __bio_add_page for adding single page Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 09/19] btrfs: raid56: use __bio_add_page to add " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 10/19] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 16:50 ` Dave Kleikamp
2023-03-30 16:50 ` [Cluster-devel] " Dave Kleikamp
2023-03-30 16:50 ` [dm-devel] " Dave Kleikamp
2023-03-30 10:43 ` [PATCH v2 11/19] gfs: use __bio_add_page for adding " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 12/19] zonefs: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 13/19] zram: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 14/19] floppy: " Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [PATCH v2 15/19] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-31 17:54 ` Song Liu
2023-03-31 17:54 ` [Cluster-devel] " Song Liu
2023-03-31 17:54 ` [dm-devel] " Song Liu
2023-03-30 10:43 ` [PATCH v2 16/19] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-31 17:59 ` Song Liu
2023-03-31 17:59 ` [Cluster-devel] " Song Liu
2023-03-31 17:59 ` [dm-devel] " Song Liu
2023-03-30 10:43 ` [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-03-30 10:43 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:43 ` [dm-devel] " Johannes Thumshirn
2023-03-31 18:13 ` Song Liu
2023-03-31 18:13 ` [Cluster-devel] " Song Liu
2023-03-31 18:13 ` [dm-devel] " Song Liu
2023-04-04 8:26 ` Johannes Thumshirn
2023-04-04 8:26 ` [Cluster-devel] " Johannes Thumshirn
2023-04-04 8:26 ` [dm-devel] " Johannes Thumshirn
2023-04-10 16:06 ` Song Liu
2023-04-10 16:06 ` [Cluster-devel] " Song Liu
2023-04-10 16:06 ` [dm-devel] " Song Liu
2023-03-30 10:44 ` [PATCH v2 18/19] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-03-30 10:44 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 10:44 ` [dm-devel] " Johannes Thumshirn
2023-03-30 10:44 ` Johannes Thumshirn [this message]
2023-03-30 10:44 ` [Cluster-devel] [PATCH v2 19/19] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-03-30 10:44 ` [dm-devel] " Johannes Thumshirn
2023-03-30 15:45 ` [PATCH v2 00/19] bio: check return values of bio_add_page David Sterba
2023-03-30 15:45 ` [Cluster-devel] " David Sterba
2023-03-30 15:45 ` [dm-devel] " David Sterba
2023-03-30 16:41 ` Johannes Thumshirn
2023-03-30 16:41 ` [Cluster-devel] " Johannes Thumshirn
2023-03-30 16:41 ` [dm-devel] " Johannes Thumshirn
2023-03-30 19:25 ` David Sterba
2023-03-30 19:25 ` [Cluster-devel] " David Sterba
2023-03-30 19:25 ` [dm-devel] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981a2b8809dedbd6dd756d7af1df4251944f42b0.1680172791.git.johannes.thumshirn@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=agruenba@redhat.com \
--cc=axboe@kernel.dk \
--cc=cluster-devel@redhat.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=rpeterso@redhat.com \
--cc=shaggy@kernel.org \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.