Re: [Patch V2 0/2] iommu/arm-smmu: Fix races in iommu domain/group creation

From: Ashish Mhetre <amhetre@nvidia.com>
To: <robin.murphy@arm.com>, <will@kernel.org>, <vdumpa@nvidia.com>
Cc: <iommu@lists.linux-foundation.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [Patch V2 0/2] iommu/arm-smmu: Fix races in iommu domain/group creation
Date: Thu, 15 Jul 2021 10:14:04 +0530	[thread overview]
Message-ID: <984e45e9-5dc0-fcdc-fa60-179faccb3715@nvidia.com> (raw)
In-Reply-To: <1623961837-12540-1-git-send-email-amhetre@nvidia.com>

On 6/18/2021 2:00 AM, Ashish Mhetre wrote:
> Multiple iommu domains and iommu groups are getting created for the devices
> sharing same SID. It is expected for devices sharing same SID to be in same
> iommu group and same iommu domain.
> This is leading to context faults when one device is accessing IOVA from
> other device which shouldn't be the case for devices sharing same SID.
> Fix this by protecting iommu domain and iommu group creation with mutexes.
> 
> Ashish Mhetre (1):
>    iommu: Fix race condition during default domain allocation
> 
> Krishna Reddy (1):
>    iommu/arm-smmu: Fix race condition during iommu_group creation
> 
>   drivers/iommu/arm/arm-smmu/arm-smmu.c | 6 +++++-
>   drivers/iommu/iommu.c                 | 2 ++
>   2 files changed, 7 insertions(+), 1 deletion(-)
> 

Hi,

Can you please help in reviewing this V2 change? Please let me know if 
anymore changes are required.

Thanks,
Ashish Mhetre