From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
chunkuang.hu@kernel.org, p.zabel@pengutronix.de, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com, airlied@linux.ie
Cc: msp@baylibre.com, granquet@baylibre.com, jitao.shi@mediatek.com,
wenst@chromium.org, ck.hu@mediatek.com,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v13 11/14] drm/mediatek: dpi: Add YUV422 output support
Date: Tue, 21 Jun 2022 14:11:41 +0200 [thread overview]
Message-ID: <98679256-5903-3923-dcaf-5a965174e049@collabora.com> (raw)
In-Reply-To: <20220621113732.11595-12-rex-bc.chen@mediatek.com>
Il 21/06/22 13:37, Bo-Chen Chen ha scritto:
> Dp_intf supports YUV422 as output format. In MT8195 Chrome project,
> YUV422 output format is used for 4K resolution.
>
> To support this, it is also needed to support color format transfer.
> Color format transfer is a new feature for both dpi and dpintf of MT8195.
>
> The input format could be RGB888 and output format for dp_intf should be
> YUV422. Therefore, we add a mtk_dpi_matrix_sel() helper to update the
> DPI_MATRIX_SET register depending on the color format.
>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 34 ++++++++++++++++++++++++-
> drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 3 +++
> 2 files changed, 36 insertions(+), 1 deletion(-)
>
..snip..
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> index 3a02fabe1662..65fce11316b7 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> @@ -217,4 +217,7 @@
>
> #define EDGE_SEL_EN BIT(5)
> #define H_FRE_2N BIT(25)
> +
> +#define DPI_MATRIX_SET 0xB4
> +#define INT_MATRIX_SEL_MASK (0x1F << 0)
Please, change INT_MATRIX_SEL_MASK: that's GENMASK(4, 0).
After that,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> #endif /* __MTK_DPI_REGS_H */
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
chunkuang.hu@kernel.org, p.zabel@pengutronix.de, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com, airlied@linux.ie
Cc: devicetree@vger.kernel.org, granquet@baylibre.com,
jitao.shi@mediatek.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, msp@baylibre.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org, wenst@chromium.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 11/14] drm/mediatek: dpi: Add YUV422 output support
Date: Tue, 21 Jun 2022 14:11:41 +0200 [thread overview]
Message-ID: <98679256-5903-3923-dcaf-5a965174e049@collabora.com> (raw)
In-Reply-To: <20220621113732.11595-12-rex-bc.chen@mediatek.com>
Il 21/06/22 13:37, Bo-Chen Chen ha scritto:
> Dp_intf supports YUV422 as output format. In MT8195 Chrome project,
> YUV422 output format is used for 4K resolution.
>
> To support this, it is also needed to support color format transfer.
> Color format transfer is a new feature for both dpi and dpintf of MT8195.
>
> The input format could be RGB888 and output format for dp_intf should be
> YUV422. Therefore, we add a mtk_dpi_matrix_sel() helper to update the
> DPI_MATRIX_SET register depending on the color format.
>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 34 ++++++++++++++++++++++++-
> drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 3 +++
> 2 files changed, 36 insertions(+), 1 deletion(-)
>
..snip..
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> index 3a02fabe1662..65fce11316b7 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> @@ -217,4 +217,7 @@
>
> #define EDGE_SEL_EN BIT(5)
> #define H_FRE_2N BIT(25)
> +
> +#define DPI_MATRIX_SET 0xB4
> +#define INT_MATRIX_SEL_MASK (0x1F << 0)
Please, change INT_MATRIX_SEL_MASK: that's GENMASK(4, 0).
After that,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> #endif /* __MTK_DPI_REGS_H */
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
chunkuang.hu@kernel.org, p.zabel@pengutronix.de, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com, airlied@linux.ie
Cc: msp@baylibre.com, granquet@baylibre.com, jitao.shi@mediatek.com,
wenst@chromium.org, ck.hu@mediatek.com,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v13 11/14] drm/mediatek: dpi: Add YUV422 output support
Date: Tue, 21 Jun 2022 14:11:41 +0200 [thread overview]
Message-ID: <98679256-5903-3923-dcaf-5a965174e049@collabora.com> (raw)
In-Reply-To: <20220621113732.11595-12-rex-bc.chen@mediatek.com>
Il 21/06/22 13:37, Bo-Chen Chen ha scritto:
> Dp_intf supports YUV422 as output format. In MT8195 Chrome project,
> YUV422 output format is used for 4K resolution.
>
> To support this, it is also needed to support color format transfer.
> Color format transfer is a new feature for both dpi and dpintf of MT8195.
>
> The input format could be RGB888 and output format for dp_intf should be
> YUV422. Therefore, we add a mtk_dpi_matrix_sel() helper to update the
> DPI_MATRIX_SET register depending on the color format.
>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 34 ++++++++++++++++++++++++-
> drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 3 +++
> 2 files changed, 36 insertions(+), 1 deletion(-)
>
..snip..
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> index 3a02fabe1662..65fce11316b7 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
> @@ -217,4 +217,7 @@
>
> #define EDGE_SEL_EN BIT(5)
> #define H_FRE_2N BIT(25)
> +
> +#define DPI_MATRIX_SET 0xB4
> +#define INT_MATRIX_SEL_MASK (0x1F << 0)
Please, change INT_MATRIX_SEL_MASK: that's GENMASK(4, 0).
After that,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> #endif /* __MTK_DPI_REGS_H */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-21 12:11 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 11:37 [PATCH v13 00/14] drm/mediatek: Add MT8195 dp_intf driver Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 01/14] dt-bindings: mediatek,dpi: Add DP_INTF compatible Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-22 2:32 ` CK Hu
2022-06-22 2:32 ` CK Hu
2022-06-22 2:32 ` CK Hu
2022-06-21 11:37 ` [PATCH v13 02/14] drm/mediatek: dpi: Add kernel document for struct mtk_dpi_conf Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 11:37 ` [PATCH v13 03/14] drm/mediatek: dpi: Add support for quantization range Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 11:37 ` [PATCH v13 04/14] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 05/14] drm/mediatek: dpi: implement a swap_input " Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 06/14] drm/mediatek: dpi: move dimension mask to " Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 07/14] drm/mediatek: dpi: move hvsize_mask " Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 08/14] drm/mediatek: dpi: move swap_shift " Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 09/14] drm/mediatek: dpi: move the yuv422_en_bit " Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 10/14] drm/mediatek: dpi: move the csc_enable bit " Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` [PATCH v13 11/14] drm/mediatek: dpi: Add YUV422 output support Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 12:11 ` AngeloGioacchino Del Regno [this message]
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 11:37 ` [PATCH v13 12/14] drm/mediatek: dpi: add config to control setting of direct connection to pins Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-22 9:08 ` Rex-BC Chen
2022-06-22 9:08 ` Rex-BC Chen
2022-06-22 9:08 ` Rex-BC Chen
2022-06-23 3:34 ` Rex-BC Chen
2022-06-23 3:34 ` Rex-BC Chen
2022-06-23 3:34 ` Rex-BC Chen
2022-06-21 11:37 ` [PATCH v13 13/14] drm/mediatek: dpi: Add dp_intf support Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-21 12:11 ` AngeloGioacchino Del Regno
2022-06-22 9:10 ` Rex-BC Chen
2022-06-22 9:10 ` Rex-BC Chen
2022-06-22 9:10 ` Rex-BC Chen
2022-06-21 11:37 ` [PATCH v13 14/14] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
2022-06-21 11:37 ` Bo-Chen Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98679256-5903-3923-dcaf-5a965174e049@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.