From: "Andrew Jeffery" <andrew@aj.id.au> To: "Colin King" <colin.king@canonical.com>, "Corey Minyard" <minyard@acm.org>, "Joel Stanley" <joel@jms.id.au>, openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int Date: Thu, 17 Jun 2021 08:33:38 +0930 [thread overview] Message-ID: <9902c945-4651-4023-bede-6833392b3811@www.fastmail.com> (raw) In-Reply-To: <20210616162913.15259-1-colin.king@canonical.com> On Thu, 17 Jun 2021, at 01:59, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The comparisons of the unsigned int hw_type to less than zero always > false because it is unsigned. Fix this by using an int for the > assignment and less than zero check. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 9d2df9a0ad80 ("ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks for catching that. Andrew
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew Jeffery" <andrew@aj.id.au> To: "Colin King" <colin.king@canonical.com>, "Corey Minyard" <minyard@acm.org>, "Joel Stanley" <joel@jms.id.au>, openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int Date: Thu, 17 Jun 2021 08:33:38 +0930 [thread overview] Message-ID: <9902c945-4651-4023-bede-6833392b3811@www.fastmail.com> (raw) In-Reply-To: <20210616162913.15259-1-colin.king@canonical.com> On Thu, 17 Jun 2021, at 01:59, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The comparisons of the unsigned int hw_type to less than zero always > false because it is unsigned. Fix this by using an int for the > assignment and less than zero check. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 9d2df9a0ad80 ("ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks for catching that. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-16 23:04 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 16:29 [PATCH][next] ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int Colin King 2021-06-16 16:29 ` Colin King 2021-06-16 19:02 ` Corey Minyard 2021-06-16 19:02 ` Corey Minyard 2021-06-16 23:03 ` Andrew Jeffery [this message] 2021-06-16 23:03 ` Andrew Jeffery
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9902c945-4651-4023-bede-6833392b3811@www.fastmail.com \ --to=andrew@aj.id.au \ --cc=colin.king@canonical.com \ --cc=joel@jms.id.au \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=minyard@acm.org \ --cc=openipmi-developer@lists.sourceforge.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.