From: Javier Martinez Canillas <javier@osg.samsung.com> To: Rob Herring <robh+dt@kernel.org> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Aaro Koskinen <aaro.koskinen@iki.fi>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Tony Lindgren <tony@atomide.com>, Lee Jones <lee.jones@linaro.org>, Mark Rutland <mark.rutland@arm.com> Subject: Re: [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Date: Tue, 4 Apr 2017 13:01:20 -0400 [thread overview] Message-ID: <9967ec41-cdc1-5cd2-4a62-e3a83cc6fa80@osg.samsung.com> (raw) In-Reply-To: <CAL_JsqLfo7jbf+fdZnqhUN=RC_Z4=Evn=5XmSr-XMw+952XYaQ@mail.gmail.com> Hello Rob, On 04/04/2017 12:54 PM, Rob Herring wrote: > On Tue, Apr 4, 2017 at 10:30 AM, Javier Martinez Canillas > <javier@osg.samsung.com> wrote: >> There are Device Tree source files defining a device node for the >> retu/tahvo I2C chip, but there isn't a DT binding document for it. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> --- >> >> Changes in v4: >> - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring). >> - Add information about what functions the device serve (Lee Jones). >> - Avoid using MFD in Device Tree (Lee Jones). >> >> Changes in v3: None >> Changes in v2: None >> >> Documentation/devicetree/bindings/mfd/retu.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt >> new file mode 100644 >> index 000000000000..7df21a2b28ea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/retu.txt >> @@ -0,0 +1,21 @@ >> +* Device tree bindings for Nokia Retu and Tahvo multi-function device >> + >> +Retu and Tahvo are a multi-function devices found on Nokia Internet >> +Tablets (770, N800 and N810). The Retu chip provides watchdog timer >> +and power button control functionalities while Tahvo chip provides >> +USB transceiver functionality. >> + >> +Required properties: >> +- compatible: "nokia,retu" or "nokia,tahvo" >> +- reg: Specifies the I2C slave address of the ASIC chip > > Missing interrupts here. > Right, sorry for missing that. I'll wait for Lee's feedback before posting a new version in case I missed something else. > With that: > > Acked-by: Rob Herring <robh@kernel.org> > Thanks a lot for your review and acks! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> Subject: Re: [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Date: Tue, 4 Apr 2017 13:01:20 -0400 [thread overview] Message-ID: <9967ec41-cdc1-5cd2-4a62-e3a83cc6fa80@osg.samsung.com> (raw) In-Reply-To: <CAL_JsqLfo7jbf+fdZnqhUN=RC_Z4=Evn=5XmSr-XMw+952XYaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Hello Rob, On 04/04/2017 12:54 PM, Rob Herring wrote: > On Tue, Apr 4, 2017 at 10:30 AM, Javier Martinez Canillas > <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> wrote: >> There are Device Tree source files defining a device node for the >> retu/tahvo I2C chip, but there isn't a DT binding document for it. >> >> Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> >> >> --- >> >> Changes in v4: >> - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring). >> - Add information about what functions the device serve (Lee Jones). >> - Avoid using MFD in Device Tree (Lee Jones). >> >> Changes in v3: None >> Changes in v2: None >> >> Documentation/devicetree/bindings/mfd/retu.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt >> new file mode 100644 >> index 000000000000..7df21a2b28ea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/retu.txt >> @@ -0,0 +1,21 @@ >> +* Device tree bindings for Nokia Retu and Tahvo multi-function device >> + >> +Retu and Tahvo are a multi-function devices found on Nokia Internet >> +Tablets (770, N800 and N810). The Retu chip provides watchdog timer >> +and power button control functionalities while Tahvo chip provides >> +USB transceiver functionality. >> + >> +Required properties: >> +- compatible: "nokia,retu" or "nokia,tahvo" >> +- reg: Specifies the I2C slave address of the ASIC chip > > Missing interrupts here. > Right, sorry for missing that. I'll wait for Lee's feedback before posting a new version in case I missed something else. > With that: > > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Thanks a lot for your review and acks! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-04 17:01 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-04 15:30 [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Javier Martinez Canillas 2017-04-04 16:54 ` Rob Herring 2017-04-04 17:01 ` Javier Martinez Canillas [this message] 2017-04-04 17:01 ` Javier Martinez Canillas 2017-04-11 13:57 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 2/8] mfd: retu: Drop -mfd suffix from I2C device ID name Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-11 13:56 ` Lee Jones 2017-04-11 13:56 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 3/8] mfd: retu: Add OF device ID table Javier Martinez Canillas 2017-04-11 13:56 ` Lee Jones 2017-04-11 13:56 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 4/8] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 6/8] dt-bindings: mfd: Add TI tps6105x chip bindings Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 7/8] mfd: tps6105x: Add OF device ID table Javier Martinez Canillas 2017-04-11 13:57 ` Lee Jones 2017-04-11 13:57 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 8/8] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 16:54 ` [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Rob Herring 2017-04-04 16:54 ` Rob Herring 2017-04-04 17:38 ` Aaro Koskinen 2017-04-04 17:38 ` Aaro Koskinen 2017-04-04 17:43 ` Tony Lindgren 2017-04-04 17:43 ` Tony Lindgren 2017-04-04 17:43 ` Tony Lindgren 2017-04-04 17:46 ` Javier Martinez Canillas 2017-04-04 17:46 ` Javier Martinez Canillas 2017-04-04 17:46 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9967ec41-cdc1-5cd2-4a62-e3a83cc6fa80@osg.samsung.com \ --to=javier@osg.samsung.com \ --cc=aaro.koskinen@iki.fi \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.