From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Damien Le Moal <damien.lemoal@hgst.com>,
<linux-scsi@vger.kernel.org>, <linux-block@vger.kernel.org>
Cc: <martin.petersen@oracle.com>, <axboe@kernel.dk>, <hare@suse.de>,
<shaun.tancheff@seagate.com>
Subject: Re: [PATCH 1/9] block: Add 'zoned' queue limit
Date: Mon, 19 Sep 2016 21:05:03 -0700 [thread overview]
Message-ID: <99a58964-121e-3822-aa00-3864dcc69a45@sandisk.com> (raw)
In-Reply-To: <1474320454-5264-2-git-send-email-damien.lemoal@hgst.com>
On 09/19/16 14:27, Damien Le Moal wrote:
> +/*
> + * Zoned block device models (zoned limit).
> + */
> +enum blk_zoned_model {
> + BLK_ZONED_NONE, /* Regular block device */
> + BLK_ZONED_HA, /* Host-aware zoned block device */
> + BLK_ZONED_HM, /* Host-managed zoned block device */
> +};
[ ... ]
> +static inline unsigned int blk_queue_zoned(struct request_queue *q)
> +{
> + return q->limits.zoned;
> +}
> +
> /*
> * We regard a request as sync, if either a read or a sync write
> */
> @@ -1354,6 +1369,16 @@ static inline unsigned int bdev_write_same(struct block_device *bdev)
> return 0;
> }
>
> +static inline unsigned int bdev_zoned(struct block_device *bdev)
> +{
> + struct request_queue *q = bdev_get_queue(bdev);
> +
> + if (q)
> + return blk_queue_zoned(q);
> +
> + return 0;
> +}
Hello Damien,
Please consider changing the return type of the above two functions into
"enum blk_zoned_model" to make it clear that both return one of the
BLK_ZONED_* constants.
Thanks,
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Damien Le Moal <damien.lemoal@hgst.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Cc: martin.petersen@oracle.com, axboe@kernel.dk, hare@suse.de,
shaun.tancheff@seagate.com
Subject: Re: [PATCH 1/9] block: Add 'zoned' queue limit
Date: Mon, 19 Sep 2016 21:05:03 -0700 [thread overview]
Message-ID: <99a58964-121e-3822-aa00-3864dcc69a45@sandisk.com> (raw)
In-Reply-To: <1474320454-5264-2-git-send-email-damien.lemoal@hgst.com>
On 09/19/16 14:27, Damien Le Moal wrote:
> +/*
> + * Zoned block device models (zoned limit).
> + */
> +enum blk_zoned_model {
> + BLK_ZONED_NONE, /* Regular block device */
> + BLK_ZONED_HA, /* Host-aware zoned block device */
> + BLK_ZONED_HM, /* Host-managed zoned block device */
> +};
[ ... ]
> +static inline unsigned int blk_queue_zoned(struct request_queue *q)
> +{
> + return q->limits.zoned;
> +}
> +
> /*
> * We regard a request as sync, if either a read or a sync write
> */
> @@ -1354,6 +1369,16 @@ static inline unsigned int bdev_write_same(struct block_device *bdev)
> return 0;
> }
>
> +static inline unsigned int bdev_zoned(struct block_device *bdev)
> +{
> + struct request_queue *q = bdev_get_queue(bdev);
> +
> + if (q)
> + return blk_queue_zoned(q);
> +
> + return 0;
> +}
Hello Damien,
Please consider changing the return type of the above two functions into
"enum blk_zoned_model" to make it clear that both return one of the
BLK_ZONED_* constants.
Thanks,
Bart.
next prev parent reply other threads:[~2016-09-20 4:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 21:27 [PATCH 0/9] ZBC / Zoned block device support Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-19 21:27 ` [PATCH 1/9] block: Add 'zoned' queue limit Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-20 4:05 ` Bart Van Assche [this message]
2016-09-20 4:05 ` Bart Van Assche
2016-09-19 21:27 ` [PATCH 2/9] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-19 21:27 ` [PATCH 3/9] block: update chunk_sectors in blk_stack_limits() Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-19 21:27 ` [PATCH 4/9] block: Define zoned block device operations Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-20 4:05 ` Bart Van Assche
2016-09-20 4:05 ` Bart Van Assche
2016-09-19 21:27 ` [PATCH 5/9] block: Implement support for zoned block devices Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-20 4:18 ` Bart Van Assche
2016-09-20 4:18 ` Bart Van Assche
2016-09-19 21:27 ` [PATCH 6/9] block: Add 'BLKPREP_DONE' return value Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-19 21:27 ` [PATCH 7/9] block: Add 'BLK_MQ_RQ_QUEUE_DONE' " Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-19 21:27 ` [PATCH 8/9] sd: Implement support for ZBC devices Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-20 0:08 ` kbuild test robot
2016-09-20 0:08 ` kbuild test robot
2016-09-20 5:40 ` Shaun Tancheff
2016-09-20 5:40 ` Shaun Tancheff
2016-09-19 21:27 ` [PATCH 9/9] blk-zoned: Add ioctl interface for zone operations Damien Le Moal
2016-09-19 21:27 ` Damien Le Moal
2016-09-20 2:39 ` kbuild test robot
2016-09-20 2:39 ` kbuild test robot
2016-09-20 6:02 ` Shaun Tancheff
2016-09-20 6:02 ` Shaun Tancheff
2016-09-20 6:33 ` kbuild test robot
2016-09-20 6:33 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a58964-121e-3822-aa00-3864dcc69a45@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@hgst.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun.tancheff@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.