From: Iskren Chernev <iskren.chernev@gmail.com> To: Krzysztof Kozlowski <krzk@kernel.org>, Chanwoo Choi <cw00.choi@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Lee Jones <lee.jones@linaro.org>, Sebastian Reichel <sre@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Matheus Castello <matheus@castello.eng.br>, Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>, Angus Ainslie <angus@akkea.ca>, Hans de Goede <hdegoede@redhat.com> Subject: Re: [PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: correct fuel gauge interrupt trigger level Date: Fri, 11 Dec 2020 17:25:07 +0200 [thread overview] Message-ID: <9a896342-cc0b-5cdf-aefd-6fe13c540c69@gmail.com> (raw) In-Reply-To: <20201210212534.216197-12-krzk@kernel.org> On 12/10/20 11:25 PM, Krzysztof Kozlowski wrote: > The Maxim fuel gauge datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU. The falling edge > interrupt will mostly work but it's not correct. > > Fixes: da8d46992e67 ("ARM: dts: qcom: msm8974-klte: Add fuel gauge") > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts > index 97352de91314..64a3fdb79539 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts > +++ b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts > @@ -691,7 +691,7 @@ fuelgauge@36 { > maxim,rcomp = /bits/ 8 <0x56>; > > interrupt-parent = <&pma8084_gpios>; > - interrupts = <21 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > > pinctrl-names = "default"; > pinctrl-0 = <&fuelgauge_pin>; After testing this patch + the rfc modifying 17040 driver I can confirm it works on the klte. Also, according to the max17048 datasheet, the ALRT pin is active low, so everything is in order. Acked-By: Iskren Chernev <iskren.chernev@gmail.com> Tested-By: Iskren Chernev <iskren.chernev@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Iskren Chernev <iskren.chernev@gmail.com> To: Krzysztof Kozlowski <krzk@kernel.org>, Chanwoo Choi <cw00.choi@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Lee Jones <lee.jones@linaro.org>, Sebastian Reichel <sre@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Angus Ainslie <angus@akkea.ca>, Hans de Goede <hdegoede@redhat.com>, Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>, Matheus Castello <matheus@castello.eng.br> Subject: Re: [PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: correct fuel gauge interrupt trigger level Date: Fri, 11 Dec 2020 17:25:07 +0200 [thread overview] Message-ID: <9a896342-cc0b-5cdf-aefd-6fe13c540c69@gmail.com> (raw) In-Reply-To: <20201210212534.216197-12-krzk@kernel.org> On 12/10/20 11:25 PM, Krzysztof Kozlowski wrote: > The Maxim fuel gauge datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU. The falling edge > interrupt will mostly work but it's not correct. > > Fixes: da8d46992e67 ("ARM: dts: qcom: msm8974-klte: Add fuel gauge") > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts > index 97352de91314..64a3fdb79539 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts > +++ b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts > @@ -691,7 +691,7 @@ fuelgauge@36 { > maxim,rcomp = /bits/ 8 <0x56>; > > interrupt-parent = <&pma8084_gpios>; > - interrupts = <21 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > > pinctrl-names = "default"; > pinctrl-0 = <&fuelgauge_pin>; After testing this patch + the rfc modifying 17040 driver I can confirm it works on the klte. Also, according to the max17048 datasheet, the ALRT pin is active low, so everything is in order. Acked-By: Iskren Chernev <iskren.chernev@gmail.com> Tested-By: Iskren Chernev <iskren.chernev@gmail.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-11 16:12 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-10 21:25 [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 02/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on P4 Note family Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-29 15:43 ` Krzysztof Kozlowski 2020-12-29 15:43 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 04/18] ARM: dts: exynos: correct MUIC " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 05/18] ARM: dts: exynos: correct PMIC " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 06/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid X/U3 family Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 07/18] ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 08/18] ARM: dts: exynos: correct PMIC interrupt trigger level on SMDK5250 Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 09/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Snow Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 10/18] ARM: dts: s5pv210: correct fuel gauge interrupt trigger level on Fascinate family Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [PATCH 11/18] ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-11 15:29 ` Iskren Chernev 2020-12-11 15:29 ` Iskren Chernev 2020-12-10 21:25 ` [PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-11 15:25 ` Iskren Chernev [this message] 2020-12-11 15:25 ` Iskren Chernev 2020-12-10 21:25 ` [RFC 13/18] mfd: max77686: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-21 18:45 ` Rob Herring 2020-12-21 18:45 ` Rob Herring 2020-12-10 21:25 ` [RFC 14/18] rtc: " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [RFC 15/18] mfd: max77693: " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-21 18:46 ` Rob Herring 2020-12-21 18:46 ` Rob Herring 2020-12-10 21:25 ` [RFC 16/18] power: supply: max17042: " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 21:25 ` [RFC 17/18] mfd: max14577: " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-21 18:47 ` Rob Herring 2020-12-21 18:47 ` Rob Herring 2020-12-10 21:25 ` [RFC 18/18] power: supply: max17040: " Krzysztof Kozlowski 2020-12-10 21:25 ` Krzysztof Kozlowski 2020-12-10 22:16 ` Sebastian Reichel 2020-12-11 7:52 ` Krzysztof Kozlowski 2020-12-11 7:47 ` Krzysztof Kozlowski 2020-12-11 7:47 ` Krzysztof Kozlowski 2020-12-11 15:44 ` Iskren Chernev 2020-12-11 15:44 ` Iskren Chernev 2020-12-11 15:51 ` Krzysztof Kozlowski 2020-12-11 15:51 ` Krzysztof Kozlowski 2021-03-03 18:19 ` [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski 2021-03-03 18:19 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9a896342-cc0b-5cdf-aefd-6fe13c540c69@gmail.com \ --to=iskren.chernev@gmail.com \ --cc=a.zummo@towertech.it \ --cc=agross@kernel.org \ --cc=alexandre.belloni@bootlin.com \ --cc=angus@akkea.ca \ --cc=b.zolnierkie@samsung.com \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=hdegoede@redhat.com \ --cc=krzk@kernel.org \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=matheus@castello.eng.br \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=sebastian.krzyszkowiak@puri.sm \ --cc=sre@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.