Re: [PATCH v2] of: overlay: do not break notify on NOTIFY_{OK|STOP}

From: Frank Rowand <frowand.list@gmail.com>
To: "Nuno Sá" <nuno.sa@analog.com>, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Subject: Re: [PATCH v2] of: overlay: do not break notify on NOTIFY_{OK|STOP}
Date: Wed, 20 Apr 2022 10:53:43 -0500	[thread overview]
Message-ID: <9ab323ca-f2ca-163b-4216-8537bf65b9ca@gmail.com> (raw)
In-Reply-To: <20220420130205.89435-1-nuno.sa@analog.com>

On 4/20/22 08:02, Nuno Sá wrote:
> We should not break overlay notifications on NOTIFY_{OK|STOP}
> otherwise we might break on the first fragment. We should only stop
> notifications if a *real* errno is returned by one of the listeners.
> 
> Fixes: a1d19bd4cf1fe ("of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove")
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Thank you.

-Frank

> ---
> v2:
>  * Only break fragment notification in case errno is returned from
> notifier;
>  * Massaged commit message accordingly.
> 
>  drivers/of/overlay.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index d80160cf34bb..d1187123c4fc 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -170,9 +170,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
>  
>  		ret = blocking_notifier_call_chain(&overlay_notify_chain,
>  						   action, &nd);
> -		if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
> -			return 0;
> -		if (ret) {
> +		if (notifier_to_errno(ret)) {
>  			ret = notifier_to_errno(ret);
>  			pr_err("overlay changeset %s notifier error %d, target: %pOF\n",
>  			       of_overlay_action_name[action], ret, nd.target);