Re: [PATCH v2] of: overlay: do not break notify on NOTIFY_{OK|STOP}

From: Rob Herring <robh@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v2] of: overlay: do not break notify on NOTIFY_{OK|STOP}
Date: Wed, 20 Apr 2022 10:14:50 -0500	[thread overview]
Message-ID: <YmAjamb4yIqieK/N@robh.at.kernel.org> (raw)
In-Reply-To: <20220420130205.89435-1-nuno.sa@analog.com>

On Wed, 20 Apr 2022 15:02:05 +0200, Nuno Sá wrote:
> We should not break overlay notifications on NOTIFY_{OK|STOP}
> otherwise we might break on the first fragment. We should only stop
> notifications if a *real* errno is returned by one of the listeners.
> 
> Fixes: a1d19bd4cf1fe ("of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove")
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> v2:
>  * Only break fragment notification in case errno is returned from
> notifier;
>  * Massaged commit message accordingly.
> 
>  drivers/of/overlay.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Applied, thanks!