Re: [PATCH v2 00/10] allow unprivileged overlay mounts

From: John Johansen <john.johansen@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Miklos Szeredi <mszeredi@redhat.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	linux-fsdevel@vger.kernel.org,
	overlayfs <linux-unionfs@vger.kernel.org>,
	LSM <linux-security-module@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/10] allow unprivileged overlay mounts
Date: Tue, 15 Dec 2020 03:03:30 -0800	[thread overview]
Message-ID: <9b8236eb-b3c4-6e0f-edb8-833172c7c2c7@canonical.com> (raw)
In-Reply-To: <CAJfpegsiuf8ib5cvVrr=zHZ+Xu7BMMTT2eYapsEUdmPcRBUiwQ@mail.gmail.com>

On 12/10/20 1:39 AM, Miklos Szeredi wrote:
> On Thu, Dec 10, 2020 at 10:00 AM John Johansen
> <john.johansen@canonical.com> wrote:
>>
>> On 12/8/20 2:27 AM, Tetsuo Handa wrote:
>>> On 2020/12/08 1:32, Miklos Szeredi wrote:
>>>> A general observation is that overlayfs does not call security_path_*()
>>>> hooks on the underlying fs.  I don't see this as a problem, because a
>>>> simple bind mount done inside a private mount namespace also defeats the
>>>> path based security checks.  Maybe I'm missing something here, so I'm
>>>> interested in comments from AppArmor and Tomoyo developers.
>>>
>>> Regarding TOMOYO, I don't want overlayfs to call security_path_*() hooks on the
>>> underlying fs, but the reason is different. It is not because a simple bind mount
>>> done inside a private mount namespace defeats the path based security checks.
>>> TOMOYO does want to check what device/filesystem is mounted on which location. But
>>> currently TOMOYO is failing to check it due to fsopen()/fsmount()/move_mount() API.
>>>
>>
>> Regardless of TOMOYO's approach I would say that overlays should call the
>> security_path_*() hooks, making it possible for an LSM to do something based off of
>> them when needed.
>>
>> The current state of private mounts with regard to path based mediation is broken.
>> I just haven't had time to try and come up with an acceptable fix for it. overlayfs
>> is actually broken under apparmor mediation, and accesses to the lower layer end up
>> getting denied but there is no way to properly allow them. So policy that hits this
>> needs a flag set that allows for it in a very hacky way (its on the list of things
>> to fix).
>>
>> Path based mediation has to carefully control mounts otherwise policy can be
>> circumvented as Miklos rightly points out. Ideally path based LSM wouldn't allow
>> you to do the simple bind mount inside a private mount namespace (at least not
>> unless policy allowed for it). AppArmor does mediate the mount hooks and bind
>> mounts in a private mount namespace (if they go through the LSM mount hooks) will
>> be denied. Again the problem is how to allow them, and this is broken.
> 
> Okay, so what does that mean for overlayfs?
> 
> AA can deny the overlay mount just as well as the bind mount, and it
> can allow it just as well as the bind mount.  Policy could be the
> same.
> 
not entirely the private mount is always detached from the namespace and we have
no way to correlate the private mount to the overlay so the only safe thing is
to deny operations on the private mount.

Ideally we would have a way to provide some kind of correlation so we could
make an informed decision.

> Also all the security_path_ hooks will still get called for each
> access on overlayfs itself.  They won't be called for the accesses
> which overlayfs does on underlying layers, but is that needed?
> 
maybe but maybe not. The thing is apparmor doesn't just used security_path_
hooks which means we get some operation on leaking through that are using
the private mount. Its this inconsistent partial view that is problematic.

> Overlay could call those hooks itself (since the vfs_ helpers don't)
> but the big question is whether that makes any sense.  AFAICS it might
> make sense, but only if AA would correctly handle bind mounts, and
> especially detached bind mounts (which is what overlayfs technically
> uses).
> 

I haven't investigated enough to say for sure whether AA needs the path
hooks called, but I think it probably doesn't. What AA does need is a
way to determine what to do with private mounts when it encounters them
in the none path hooks.

That could be a simple as a hook when the private mount is setup so it
can setup some state.

> Thanks,
> Miklos
> 
> Tja
> 