Re: [PATCH_V3 0/6] thermal: stm32: driver improvements

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Pascal PAILLET-LME <p.paillet@st.com>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
	"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	David HERNANDEZ SANCHEZ <david.hernandezsanchez@st.com>,
	"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
	"wsa+renesas@sang-engineering.com"
	<wsa+renesas@sang-engineering.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH_V3 0/6] thermal: stm32: driver improvements
Date: Mon, 27 Jan 2020 15:39:00 +0100	[thread overview]
Message-ID: <9cddb220-7890-5bdb-0d59-125264ab0626@linaro.org> (raw)
In-Reply-To: <a400d4e2-4abb-aad8-73f0-57c9300ca351@st.com>

On 27/01/2020 14:17, Pascal PAILLET-LME wrote:
> The goal of this patchset is to improve and simplify the stm32 thermal
>> driver:
>> * let the framework handle the trip points: it very is hard to split this patch
>> into smaller ones and keep each individual patch functional.
>> * fix interrupt management to avoid receiving hundreds of
>> interrupts when the temperature is close to the low threshold.
>> * improve temperature reading resolution
>> * the dirver is backawrd compatible.
>>
>> Pascal Paillet (6):
>> changes in v2:
>> * Split "handle multiple trip points" patch to make ones:
>> *   rework sensor mode management
>> *   disable interrupts at probe
>> * "remove hardware irq handler" is squashed in "handle multiple trip points"
> kind reminder for review
>>    thermal: stm32: fix icifr register name
>>    thermal: stm32: rework sensor mode management
>>    thermal: stm32: disable interrupts at probe
>>    thermal: stm32: handle multiple trip points
>>    thermal: stm32: improve temperature computing
>>    thermal: stm32: fix low threshold interrupt flood
>>
>>   drivers/thermal/st/stm_thermal.c | 388 ++++++++++---------------------
>>   1 file changed, 120 insertions(+), 268 deletions(-)

The series looks good to me. I've applied it for kernelci, if it is good
it will go to the next branch and be part of the next pull request.

In the future, do not join the PATCH keyword with the version. That
puzzles patchwork.

Thanks

  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog