From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Durrant, Paul" <pdurrant@amazon.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Thomas Huth <thuth@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge
Date: Mon, 9 Dec 2019 12:12:22 +0100 [thread overview]
Message-ID: <9dea9aca-5445-9c53-e1c4-c5f73c2af243@redhat.com> (raw)
In-Reply-To: <4e9dee3e-05b5-640d-33df-4341c2e01b8b@redhat.com>
On 09/12/19 11:56, Philippe Mathieu-Daudé wrote:
>
> I think so, but with PC_I440FX -> PCI_I440FX ;)
>
> It would be cleaner to pass the CONFIG_XEN_PCI_PASSTHROUGH variable to
> Kconfig and use it (use 'depends on XEN_PCI_PASSTHROUGH').
>
> This can be another step, so if this series looks OK to you so far, do
> you mind fixing this and the comment in the previous patch noticed by
> Thomas:
>
> - Extract it into a new file, 'hw/pci-host/igd_pt.c'.
> + Extract it into a new file, 'hw/pci-host/xen_igd_pt.c'.
Sure.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Durrant, Paul" <pdurrant@amazon.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Thomas Huth <thuth@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge
Date: Mon, 9 Dec 2019 12:12:22 +0100 [thread overview]
Message-ID: <9dea9aca-5445-9c53-e1c4-c5f73c2af243@redhat.com> (raw)
In-Reply-To: <4e9dee3e-05b5-640d-33df-4341c2e01b8b@redhat.com>
On 09/12/19 11:56, Philippe Mathieu-Daudé wrote:
>
> I think so, but with PC_I440FX -> PCI_I440FX ;)
>
> It would be cleaner to pass the CONFIG_XEN_PCI_PASSTHROUGH variable to
> Kconfig and use it (use 'depends on XEN_PCI_PASSTHROUGH').
>
> This can be another step, so if this series looks OK to you so far, do
> you mind fixing this and the comment in the previous patch noticed by
> Thomas:
>
> - Extract it into a new file, 'hw/pci-host/igd_pt.c'.
> + Extract it into a new file, 'hw/pci-host/xen_igd_pt.c'.
Sure.
Paolo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-09 11:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 9:49 [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through Philippe Mathieu-Daudé
2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-12-09 9:49 ` [PATCH-for-5.0 v3 1/6] hw/pci-host/i440fx: Correct the header description Philippe Mathieu-Daudé
2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-12-09 10:02 ` Thomas Huth
2019-12-09 10:02 ` [Xen-devel] " Thomas Huth
2019-12-18 11:57 ` Laurent Vivier
2019-12-18 11:57 ` [Xen-devel] " Laurent Vivier
2019-12-09 9:49 ` [PATCH-for-5.0 v3 2/6] hw/pci-host/i440fx: Extract PCII440FXState to "hw/pci-host/i440fx.h" Philippe Mathieu-Daudé
2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-12-09 10:03 ` Thomas Huth
2019-12-09 10:03 ` [Xen-devel] " Thomas Huth
2019-12-09 9:49 ` [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE() Philippe Mathieu-Daudé
2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-12-09 10:05 ` Thomas Huth
2019-12-09 10:05 ` [Xen-devel] " Thomas Huth
2019-12-18 11:57 ` Laurent Vivier
2019-12-18 11:57 ` [Xen-devel] " Laurent Vivier
2019-12-18 12:01 ` Paolo Bonzini
2019-12-18 12:01 ` [Xen-devel] " Paolo Bonzini
2019-12-18 12:31 ` Laurent Vivier
2019-12-18 12:31 ` [Xen-devel] " Laurent Vivier
2019-12-09 9:50 ` [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values Philippe Mathieu-Daudé
2019-12-09 9:50 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-12-09 10:08 ` Thomas Huth
2019-12-09 10:08 ` [Xen-devel] " Thomas Huth
2019-12-09 9:50 ` [PATCH-for-5.0 v3 5/6] hw/pci-host/i440fx: Extract the IGD passthrough host bridge device Philippe Mathieu-Daudé
2019-12-09 9:50 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-12-09 10:08 ` Durrant, Paul
2019-12-09 10:08 ` Durrant, Paul
2019-12-09 9:50 ` [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge Philippe Mathieu-Daudé
2019-12-09 9:50 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-12-09 10:10 ` Durrant, Paul
2019-12-09 10:10 ` Durrant, Paul
2019-12-09 10:42 ` Paolo Bonzini
2019-12-09 10:42 ` Paolo Bonzini
2019-12-09 10:56 ` Philippe Mathieu-Daudé
2019-12-09 10:56 ` Philippe Mathieu-Daudé
2019-12-09 11:12 ` Paolo Bonzini [this message]
2019-12-09 11:12 ` Paolo Bonzini
2019-12-09 10:39 ` Paolo Bonzini
2019-12-09 10:39 ` [Xen-devel] " Paolo Bonzini
2019-12-09 18:39 ` [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through no-reply
2019-12-09 18:39 ` [Xen-devel] " no-reply
2019-12-09 18:49 ` no-reply
2019-12-09 18:49 ` [Xen-devel] " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dea9aca-5445-9c53-e1c4-c5f73c2af243@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.