Re: [PATCH 1/2] edac: altera: fix deferred probing

From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Borislav Petkov <bp@alien8.de>, Dinh Nguyen <dinguyen@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rric@kernel.org>, <linux-edac@vger.kernel.org>
Subject: Re: [PATCH 1/2] edac: altera: fix deferred probing
Date: Fri, 28 Jan 2022 22:02:46 +0300	[thread overview]
Message-ID: <9f28d2de-5119-a7a6-9da7-08b2ce13f1a0@omp.ru> (raw)
In-Reply-To: <ba83ca78-6a15-caf5-71ba-76d5b2b1b41d@omp.ru>

On 1/28/22 9:53 PM, Sergey Shtylyov wrote:

>>>> The driver overrides the error codes returned by platform_get_irq() to
>>>> -ENODEV for some strange reason, so if it returns -EPROBE_DEFER, the
>>>> driver will fail the probe permanently instead of the deferred probing.
>>>> Switch to propagating the error codes upstream.
>>>>
>>>> Fixes: 71bcada88b0f ("edac: altera: Add Altera SDRAM EDAC support")
>>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>>> ---
>>>>   drivers/edac/altera_edac.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
>>>> index 3a6d2416cb0f..5dd29789f97d 100644
>>>> --- a/drivers/edac/altera_edac.c
>>>> +++ b/drivers/edac/altera_edac.c
>>>> @@ -350,7 +350,7 @@ static int altr_sdram_probe(struct platform_device *pdev)
>>>>   	if (irq < 0) {
>>>>   		edac_printk(KERN_ERR, EDAC_MC,
>>>>   			    "No irq %d in DT\n", irq);
>>>> -		return -ENODEV;
>>>> +		return irq;
>>>>   	}
>>>>   	/* Arria10 has a 2nd IRQ */
>>>
>>>
>>> Acked-by: Dinh Nguyen <dinguyen@kernel.org>
>>
>> It sounds to me like we want this CC: stable@ too?
> 
>    I think the -stable people will pick it up based on the Fixes: tag. 
> 
>> If so, looking at
>>
>>   2043727c2882 ("driver core: platform: Make use of the helper function dev_err_probe()")
>>
>> that added that dev_err_probe() call, which was in Nov. 2021, which
> 
>    It didn't add anything new -- there was dev_err() there before that,
> added by 7723f4c5ecdb8d832f049f8483beb0d1081cedf6.
> 
>> would mean, even if stable, only 5.15 and not in all stable trees
>> judging by the Fixes: tag which is a patch from 3.17, i.e., 2014.
>>
>> Right?
> 
>    Mmm, platfrom_get_irq() started to return errors long ago, no? 

   Ah, you were wondering about returing -EPROBE_DEFER? It started to be returned
by the commit 9ec36cafe43bf835f8f29273597a5b0cbc8267ef several months before that...

MBR, Sergey