Re: [PATCH 1/2] edac: altera: fix deferred probing

From: Borislav Petkov <bp@alien8.de>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rric@kernel.org>,
	linux-edac@vger.kernel.org
Subject: Re: [PATCH 1/2] edac: altera: fix deferred probing
Date: Fri, 28 Jan 2022 19:36:53 +0100	[thread overview]
Message-ID: <YfQ3xUpLOPvDu5W+@zn.tnic> (raw)
In-Reply-To: <7b964ac0-6356-9330-a745-b43e620d051b@kernel.org>

On Wed, Jan 26, 2022 at 10:52:20AM -0600, Dinh Nguyen wrote:
> On 1/24/22 12:55, Sergey Shtylyov wrote:
> > The driver overrides the error codes returned by platform_get_irq() to
> > -ENODEV for some strange reason, so if it returns -EPROBE_DEFER, the
> > driver will fail the probe permanently instead of the deferred probing.
> > Switch to propagating the error codes upstream.
> > 
> > Fixes: 71bcada88b0f ("edac: altera: Add Altera SDRAM EDAC support")
> > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> > ---
> >   drivers/edac/altera_edac.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> > index 3a6d2416cb0f..5dd29789f97d 100644
> > --- a/drivers/edac/altera_edac.c
> > +++ b/drivers/edac/altera_edac.c
> > @@ -350,7 +350,7 @@ static int altr_sdram_probe(struct platform_device *pdev)
> >   	if (irq < 0) {
> >   		edac_printk(KERN_ERR, EDAC_MC,
> >   			    "No irq %d in DT\n", irq);
> > -		return -ENODEV;
> > +		return irq;
> >   	}
> >   	/* Arria10 has a 2nd IRQ */
> 
> 
> Acked-by: Dinh Nguyen <dinguyen@kernel.org>

It sounds to me like we want this CC: stable@ too?

If so, looking at

  2043727c2882 ("driver core: platform: Make use of the helper function dev_err_probe()")

that added that dev_err_probe() call, which was in Nov. 2021, which
would mean, even if stable, only 5.15 and not in all stable trees
judging by the Fixes: tag which is a patch from 3.17, i.e., 2014.

Right?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette