From: Punit Agrawal <punit.agrawal@arm.com> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Daniel Kurtz <djkurtz@chromium.org>, kernel@pengutronix.de, Matthias Brugger <matthias.bgg@gmail.com>, devicetree@vger.kernel.org, mark.rutland@arm.com, robh+dt@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Date: Thu, 27 Aug 2015 12:49:39 +0100 [thread overview] Message-ID: <9hh1tepj6i4.fsf@e105922-lin.cambridge.arm.com> (raw) In-Reply-To: <1440657677-2890-2-git-send-email-s.hauer@pengutronix.de> (Sascha Hauer's message of "Thu, 27 Aug 2015 08:41:15 +0200") [ + device tree folks ] Hi Sascha, When introducing a new binding, it is a good idea to get reviews from the device tree maintainers. I've added a few folks here. Please keep them in the loop for future postings. Sascha Hauer <s.hauer@pengutronix.de> writes: > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> Please add a commit log. > --- > .../bindings/thermal/mediatek-thermal.txt | 38 ++++++++++++++++++++++ > include/dt-bindings/thermal/mt8173.h | 13 ++++++++ > 2 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > create mode 100644 include/dt-bindings/thermal/mt8173.h > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > new file mode 100644 > index 0000000..1697375 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > @@ -0,0 +1,38 @@ > +* Mediatek Thermal > + > +This describes the device tree binding for the Mediatek thermal controller > +which measures the on-SoC temperatures. This device does not have its own ADC, > +instead it directly controls the AUXADC via AHB bus accesses. For this reason > +this device needs phandles to the AUXADC. Also it controls a mux in the > +apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS > +is also needed. > + > +Required properties: > +- compatible: "mediatek,mt8173-thermal" > +- reg: Address range of the thermal controller > +- interrupts: IRQ for the thermal controller > +- clocks, clock-names: Clocks needed for the thermal controller. required > + clocks are: > + "therm": Main clock needed for register access > + "auxadc": The AUXADC clock > +- resets: Reference to the reset controller controlling the thermal controller. > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller. > +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See > + include/dt-bindings/thermal/mt8173.h for valid sensor > + numbers. > + > +Example: > + > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <1>; > + compatible = "mediatek,mt8173-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&pericfg MT8173_PERI_THERM_SW_RST>; > + reset-names = "therm"; > + mediatek,auxadc = <&auxadc>; > + mediatek,apmixedsys = <&apmixedsys>; > + }; > diff --git a/include/dt-bindings/thermal/mt8173.h b/include/dt-bindings/thermal/mt8173.h > new file mode 100644 > index 0000000..692e74c > --- /dev/null > +++ b/include/dt-bindings/thermal/mt8173.h > @@ -0,0 +1,13 @@ > +/* > + * This header provides constants for mediatek,mt8173-thermal > + */ > + > +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H > +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H > + > +#define MT8173_THERMAL_ZONE_CA53 0 > +#define MT8173_THERMAL_ZONE_CA57 1 > +#define MT8173_THERMAL_ZONE_GPU 2 > +#define MT8173_THERMAL_ZONE_CORE 3 > + > +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */ The constants in this include are not used in the patchset. Please drop this hunk and introduce it when you use it. Thanks, Punit
WARNING: multiple messages have this Message-ID (diff)
From: Punit Agrawal <punit.agrawal-5wv7dgnIgG8@public.gmane.org> To: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Subject: Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Date: Thu, 27 Aug 2015 12:49:39 +0100 [thread overview] Message-ID: <9hh1tepj6i4.fsf@e105922-lin.cambridge.arm.com> (raw) In-Reply-To: <1440657677-2890-2-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> (Sascha Hauer's message of "Thu, 27 Aug 2015 08:41:15 +0200") [ + device tree folks ] Hi Sascha, When introducing a new binding, it is a good idea to get reviews from the device tree maintainers. I've added a few folks here. Please keep them in the loop for future postings. Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> writes: > Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > Reviewed-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Please add a commit log. > --- > .../bindings/thermal/mediatek-thermal.txt | 38 ++++++++++++++++++++++ > include/dt-bindings/thermal/mt8173.h | 13 ++++++++ > 2 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > create mode 100644 include/dt-bindings/thermal/mt8173.h > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > new file mode 100644 > index 0000000..1697375 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > @@ -0,0 +1,38 @@ > +* Mediatek Thermal > + > +This describes the device tree binding for the Mediatek thermal controller > +which measures the on-SoC temperatures. This device does not have its own ADC, > +instead it directly controls the AUXADC via AHB bus accesses. For this reason > +this device needs phandles to the AUXADC. Also it controls a mux in the > +apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS > +is also needed. > + > +Required properties: > +- compatible: "mediatek,mt8173-thermal" > +- reg: Address range of the thermal controller > +- interrupts: IRQ for the thermal controller > +- clocks, clock-names: Clocks needed for the thermal controller. required > + clocks are: > + "therm": Main clock needed for register access > + "auxadc": The AUXADC clock > +- resets: Reference to the reset controller controlling the thermal controller. > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller. > +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See > + include/dt-bindings/thermal/mt8173.h for valid sensor > + numbers. > + > +Example: > + > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <1>; > + compatible = "mediatek,mt8173-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&pericfg MT8173_PERI_THERM_SW_RST>; > + reset-names = "therm"; > + mediatek,auxadc = <&auxadc>; > + mediatek,apmixedsys = <&apmixedsys>; > + }; > diff --git a/include/dt-bindings/thermal/mt8173.h b/include/dt-bindings/thermal/mt8173.h > new file mode 100644 > index 0000000..692e74c > --- /dev/null > +++ b/include/dt-bindings/thermal/mt8173.h > @@ -0,0 +1,13 @@ > +/* > + * This header provides constants for mediatek,mt8173-thermal > + */ > + > +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H > +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H > + > +#define MT8173_THERMAL_ZONE_CA53 0 > +#define MT8173_THERMAL_ZONE_CA57 1 > +#define MT8173_THERMAL_ZONE_GPU 2 > +#define MT8173_THERMAL_ZONE_CORE 3 > + > +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */ The constants in this include are not used in the patchset. Please drop this hunk and introduce it when you use it. Thanks, Punit -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-27 11:49 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-27 6:41 [PATCH v7] Add Mediatek thermal support Sascha Hauer 2015-08-27 6:41 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-08-27 11:49 ` Punit Agrawal [this message] 2015-08-27 11:49 ` Punit Agrawal 2015-08-28 2:23 ` Daniel Kurtz 2015-08-31 7:25 ` Sascha Hauer 2015-08-27 6:41 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-08-27 11:50 ` Punit Agrawal 2015-08-27 6:41 ` [PATCH 3/3] ARM64: dts: mt8173: Add thermal/auxadc device nodes Sascha Hauer -- strict thread matches above, loose matches on Subject: below -- 2016-07-07 9:06 [PATCH 0/3] thermal: Add Mediatek thermal driver for mt2701 Dawei Chien 2016-07-07 9:06 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Dawei Chien 2016-07-07 9:06 ` Dawei Chien 2016-07-07 9:06 ` Dawei Chien 2016-07-07 11:09 ` Keerthy 2016-07-07 11:09 ` Keerthy 2016-07-07 11:09 ` Keerthy 2016-07-11 8:52 ` dawei chien 2016-07-11 8:52 ` dawei chien 2016-07-11 8:52 ` dawei chien 2016-08-11 15:48 ` Matthias Brugger 2016-08-11 15:48 ` Matthias Brugger 2016-08-15 7:07 ` dawei chien 2016-08-15 7:07 ` dawei chien 2016-08-15 7:07 ` dawei chien 2015-11-30 11:42 [PATCH v12] Add Mediatek thermal support Sascha Hauer 2015-11-30 11:42 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-11-30 11:42 ` Sascha Hauer 2015-12-16 11:23 ` Daniel Kurtz 2015-12-16 11:23 ` Daniel Kurtz 2015-12-16 11:23 ` Daniel Kurtz 2015-12-17 19:23 ` Eduardo Valentin 2015-12-17 19:23 ` Eduardo Valentin 2015-12-17 19:23 ` Eduardo Valentin 2015-12-18 7:16 ` Sascha Hauer 2015-12-18 7:16 ` Sascha Hauer 2015-12-18 7:16 ` Sascha Hauer 2015-12-20 2:12 ` Eduardo Valentin 2015-12-20 2:12 ` Eduardo Valentin 2015-12-20 2:12 ` Eduardo Valentin 2015-11-18 8:24 [PATCH v11] Add Mediatek thermal support Sascha Hauer 2015-11-18 8:24 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-11-18 8:24 ` Sascha Hauer 2015-11-09 10:13 [PATCH v10] Add Mediatek thermal support Sascha Hauer 2015-11-09 10:13 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-11-09 10:13 ` Sascha Hauer 2015-11-09 10:13 ` Sascha Hauer 2015-11-09 15:59 ` Rob Herring 2015-11-09 15:59 ` Rob Herring 2015-09-23 13:37 [PATCH v9] Add Mediatek thermal support Sascha Hauer 2015-09-23 13:37 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-09-23 13:37 ` Sascha Hauer 2015-08-31 7:34 [PATCH v8] Add Mediatek thermal support Sascha Hauer 2015-08-31 7:34 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-08-31 7:34 ` Sascha Hauer 2015-08-31 7:34 ` Sascha Hauer 2015-09-01 5:26 ` Sascha Hauer 2015-09-01 5:26 ` Sascha Hauer 2015-08-26 13:58 [PATCH v6] Add Mediatek thermal support Sascha Hauer 2015-08-26 13:58 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-08-20 8:05 [PATCH v5] Add Mediatek thermal support Sascha Hauer 2015-08-20 8:06 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-08-07 13:55 [PATCH v4] Add Mediatek thermal support Sascha Hauer 2015-08-07 13:55 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-08-05 12:25 [PATCH v3] Add Mediatek thermal support Sascha Hauer 2015-08-05 12:25 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-07-21 7:59 [PATCH v2] Add Mediatek thermal support Sascha Hauer 2015-07-21 7:59 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-07-21 7:59 ` Sascha Hauer 2015-07-13 10:34 [PATCH] thermal: Add Mediatek thermal support Sascha Hauer 2015-07-13 10:34 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-07-13 10:34 ` Sascha Hauer 2015-07-15 17:41 ` Daniel Kurtz 2015-07-15 17:41 ` Daniel Kurtz 2015-07-15 17:41 ` Daniel Kurtz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9hh1tepj6i4.fsf@e105922-lin.cambridge.arm.com \ --to=punit.agrawal@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=djkurtz@chromium.org \ --cc=edubezval@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.