From: Ohad Ben-Cohen <ohad@wizery.com> To: Adrian Hunter <adrian.hunter@nokia.com> Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, Mark Brown <broonie@opensource.wolfsonmicro.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Chikkature Rajashekar Madhusudhan <madhu.cr@ti.com>, "Coelho Luciano (Nokia-MS/Helsinki)" <Luciano.Coelho@nokia.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, San Mehat <san@google.com>, "Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@nokia.com>, Tony Lindgren <tony@atomide.com>, Nicolas Pitre <nico@fluxnic.net>, Pandita Vikram <vikram.pandita@ti.com>, Kalle Valo <kalle.valo@iki.fi> Subject: Re: [PATCH v3 6/9] omap: hsmmc: remove unused variable Date: Wed, 11 Aug 2010 13:08:28 +0300 [thread overview] Message-ID: <AANLkTi=bB++-VU88JQTicJeYf==9qccx0HMDiz5-geyg@mail.gmail.com> (raw) In-Reply-To: <4C627378.2090304@nokia.com> On Wed, Aug 11, 2010 at 12:55 PM, Adrian Hunter <adrian.hunter@nokia.com> wrote: > Ohad Ben-Cohen wrote: >> >> Make this go away: >> >> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend': >> drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state' > > Was done a while ago. Are you sure ? I can still see the unused state variable in Linus' tree: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/mmc/host/omap_hsmmc.c;h=b032828c61263028963bd412a7455546d5e86ce7;hb=HEAD#l2275 > See 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e in linus' tree. This commit only seem to adapt to the API change (the state variable is not removed): diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index d25b19b..b032828 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -2292,7 +2292,7 @@ static int omap_hsmmc_suspend(struct device *dev) } cancel_work_sync(&host->mmc_carddetect_work); mmc_host_enable(host->mmc); - ret = mmc_suspend_host(host->mmc, state); + ret = mmc_suspend_host(host->mmc); if (ret == 0) { omap_hsmmc_disable_irq(host); OMAP_HSMMC_WRITE(host->base, HCTL, > >> >> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com> >> --- >> drivers/mmc/host/omap_hsmmc.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c >> index b032828..d50e917 100644 >> --- a/drivers/mmc/host/omap_hsmmc.c >> +++ b/drivers/mmc/host/omap_hsmmc.c >> @@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev) >> int ret = 0; >> struct platform_device *pdev = to_platform_device(dev); >> struct omap_hsmmc_host *host = platform_get_drvdata(pdev); >> - pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */ >> if (host && host->suspended) >> return 0; > >
WARNING: multiple messages have this Message-ID (diff)
From: ohad@wizery.com (Ohad Ben-Cohen) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 6/9] omap: hsmmc: remove unused variable Date: Wed, 11 Aug 2010 13:08:28 +0300 [thread overview] Message-ID: <AANLkTi=bB++-VU88JQTicJeYf==9qccx0HMDiz5-geyg@mail.gmail.com> (raw) In-Reply-To: <4C627378.2090304@nokia.com> On Wed, Aug 11, 2010 at 12:55 PM, Adrian Hunter <adrian.hunter@nokia.com> wrote: > Ohad Ben-Cohen wrote: >> >> Make this go away: >> >> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend': >> drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state' > > Was done a while ago. Are you sure ? I can still see the unused state variable in Linus' tree: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/mmc/host/omap_hsmmc.c;h=b032828c61263028963bd412a7455546d5e86ce7;hb=HEAD#l2275 > See 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e in linus' tree. This commit only seem to adapt to the API change (the state variable is not removed): diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index d25b19b..b032828 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -2292,7 +2292,7 @@ static int omap_hsmmc_suspend(struct device *dev) } cancel_work_sync(&host->mmc_carddetect_work); mmc_host_enable(host->mmc); - ret = mmc_suspend_host(host->mmc, state); + ret = mmc_suspend_host(host->mmc); if (ret == 0) { omap_hsmmc_disable_irq(host); OMAP_HSMMC_WRITE(host->base, HCTL, > >> >> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com> >> --- >> ?drivers/mmc/host/omap_hsmmc.c | ? ?1 - >> ?1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c >> index b032828..d50e917 100644 >> --- a/drivers/mmc/host/omap_hsmmc.c >> +++ b/drivers/mmc/host/omap_hsmmc.c >> @@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev) >> ? ? ? ?int ret = 0; >> ? ? ? ?struct platform_device *pdev = to_platform_device(dev); >> ? ? ? ?struct omap_hsmmc_host *host = platform_get_drvdata(pdev); >> - ? ? ? pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */ >> ? ? ? ?if (host && host->suspended) >> ? ? ? ? ? ? ? ?return 0; > >
next prev parent reply other threads:[~2010-08-11 10:08 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-10 22:12 [PATCH v3 0/9] native support for wl1271 on ZOOM Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 1/9] wireless: wl1271: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 2/9] wireless: wl1271: support return value for the set power func Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 3/9] wireless: wl1271: add platform driver to get board data Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 4/9] wireless: wl1271: take irq info from private " Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 5/9] wireless: wl1271: make ref_clock configurable by board Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 6/9] omap: hsmmc: remove unused variable Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-11 9:55 ` Adrian Hunter 2010-08-11 9:55 ` Adrian Hunter 2010-08-11 10:08 ` Ohad Ben-Cohen [this message] 2010-08-11 10:08 ` Ohad Ben-Cohen 2010-08-11 10:28 ` Adrian Hunter 2010-08-11 10:28 ` Adrian Hunter 2010-08-10 22:12 ` [PATCH v3 7/9] omap: zoom: add fixed regulator device for wlan Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 8/9] omap: hsmmc: split mmc23 power control Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-11 8:30 ` Roger Quadros 2010-08-11 8:30 ` Roger Quadros 2010-08-11 10:05 ` Adrian Hunter 2010-08-11 10:05 ` Adrian Hunter 2010-08-11 10:52 ` Roger Quadros 2010-08-11 10:52 ` Roger Quadros 2010-08-11 11:01 ` Ohad Ben-Cohen 2010-08-11 11:01 ` Ohad Ben-Cohen 2010-08-11 16:01 ` Ohad Ben-Cohen 2010-08-11 16:01 ` Ohad Ben-Cohen 2010-08-10 22:12 ` [PATCH v3 9/9] omap: zoom: add mmc3/wl1271 device support Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-10 22:12 ` Ohad Ben-Cohen 2010-08-11 8:37 ` Roger Quadros 2010-08-11 8:37 ` Roger Quadros 2010-08-11 9:01 ` Roger Quadros 2010-08-11 9:01 ` Roger Quadros 2010-08-11 15:38 ` Ohad Ben-Cohen 2010-08-11 15:38 ` Ohad Ben-Cohen 2010-08-11 15:38 ` Ohad Ben-Cohen 2010-08-11 15:38 ` Ohad Ben-Cohen 2010-08-11 15:38 ` Ohad Ben-Cohen 2010-08-11 15:38 ` Ohad Ben-Cohen 2010-08-11 20:09 ` kishore kadiyala 2010-08-11 20:09 ` kishore kadiyala 2010-08-11 20:12 ` Ohad Ben-Cohen 2010-08-11 20:12 ` Ohad Ben-Cohen 2010-08-11 20:18 ` kishore kadiyala 2010-08-11 20:18 ` kishore kadiyala 2010-08-11 21:03 ` Mark Brown 2010-08-11 21:03 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='AANLkTi=bB++-VU88JQTicJeYf==9qccx0HMDiz5-geyg@mail.gmail.com' \ --to=ohad@wizery.com \ --cc=Luciano.Coelho@nokia.com \ --cc=adrian.hunter@nokia.com \ --cc=akpm@linux-foundation.org \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=kalle.valo@iki.fi \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=madhu.cr@ti.com \ --cc=nico@fluxnic.net \ --cc=roger.quadros@nokia.com \ --cc=san@google.com \ --cc=tony@atomide.com \ --cc=vikram.pandita@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.