Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

From: Christian Brunner <c.m.brunner@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
	ceph-devel@vger.kernel.org, kwolf@redhat.com
Subject: Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)
Date: Mon, 15 Nov 2010 18:04:49 +0100	[thread overview]
Message-ID: <AANLkTik0=3tDxu+PMA-JzGwLaCYRGQfRugm36h3L=xvn@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikE3UX8AxmfiwwVgR7_NxL=p=1CCD+6wwomwBkQ@mail.gmail.com>

Hi Stefan,

thanks for your feedback. Yehuda and Sage have already committed some
pathes to our git repository.

What I'm not sure about is the rados_(de)initialization for multiple
rbd images. I suspect that _deinitialize should only be called for the
last rbd image.

Yehuda and Sage know librados a lot better than me. I pretty sure,
that they will give some feedback about this remaining issue. After
that we will send an updated patch.

Regards,
Christian

2010/11/11 Stefan Hajnoczi <stefanha@gmail.com>:
> On Fri, Oct 15, 2010 at 8:54 PM, Christian Brunner <chb@muc.de> wrote:
>> [...]
>> +
>> +    if ((r = rados_initialize(0, NULL)) < 0) {
>> +        error_report("error initializing");
>> +        return r;
>> +    }
>
> Does rados_initialize() work when called multiple times?  This would happen if
> the VM has several rbd devices attached.
>
> [...]
>
> Stefan
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html