All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aisheng Dong <aisheng.dong@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Abel Vesa <abel.vesa@nxp.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Rob Herring <robh@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Fabio Estevam <fabio.estevam@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [RFC 0/7] cpuidle: Add poking mechanism to support non-IPI wakeup
Date: Thu, 28 Mar 2019 11:27:53 +0000	[thread overview]
Message-ID: <AM0PR04MB4211673DC2071A6181B0948880590@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1553709304.2561.44.camel@pengutronix.de>

[...]
> > > Anything that isn't visible to the GPC and requires the GIC
> > > wake_request signal to behave as specified is broken by this erratum.
> >
> > I really wonder how a timer interrupt (a PPI, hence not routed through
> > the GPC) can wake up the CPU in this case. It really feels like
> > something like "program CNTV_CVAL_EL0 to expire at some later point;
> > WFI" could result in the CPU going to a deep sleep state, and not
> > wake-up at all.
> 
> I guess it's broken in the same way. The downstream DT claims
> "local-timer-stop" for the CPU sleep state and "arm,no-tick-in-suspend"
> for the armv8-timer, which I guess is not the timer actually stopping in suspend,
> but the CPU being unable to wake up due to the timer IRQ.
> 
> > This would indicate that not only cpuidle is broken with this, but
> > absolutely every interrupt that is not routed through the GPC.
> 
> That's my understanding as well. Note that I have no NXP internal information
> and can only infer from the published reference manual, errata notice and
> downstream kernel.
> 

We will double check it.
Thanks for the information.

Regards
Dong Aisheng

> Regards,
> Lucas

WARNING: multiple messages have this Message-ID (diff)
From: Aisheng Dong <aisheng.dong@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	 Abel Vesa <abel.vesa@nxp.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Rob Herring <robh@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Fabio Estevam <fabio.estevam@nxp.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [RFC 0/7] cpuidle: Add poking mechanism to support non-IPI wakeup
Date: Thu, 28 Mar 2019 11:27:53 +0000	[thread overview]
Message-ID: <AM0PR04MB4211673DC2071A6181B0948880590@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1553709304.2561.44.camel@pengutronix.de>

[...]
> > > Anything that isn't visible to the GPC and requires the GIC
> > > wake_request signal to behave as specified is broken by this erratum.
> >
> > I really wonder how a timer interrupt (a PPI, hence not routed through
> > the GPC) can wake up the CPU in this case. It really feels like
> > something like "program CNTV_CVAL_EL0 to expire at some later point;
> > WFI" could result in the CPU going to a deep sleep state, and not
> > wake-up at all.
> 
> I guess it's broken in the same way. The downstream DT claims
> "local-timer-stop" for the CPU sleep state and "arm,no-tick-in-suspend"
> for the armv8-timer, which I guess is not the timer actually stopping in suspend,
> but the CPU being unable to wake up due to the timer IRQ.
> 
> > This would indicate that not only cpuidle is broken with this, but
> > absolutely every interrupt that is not routed through the GPC.
> 
> That's my understanding as well. Note that I have no NXP internal information
> and can only infer from the published reference manual, errata notice and
> downstream kernel.
> 

We will double check it.
Thanks for the information.

Regards
Dong Aisheng

> Regards,
> Lucas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-28 11:27 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 13:21 [RFC 0/7] cpuidle: Add poking mechanism to support non-IPI wakeup Abel Vesa
2019-03-27 13:21 ` Abel Vesa
2019-03-27 13:21 ` Abel Vesa
2019-03-27 13:21 ` [RFC 1/7] sched: idle: Add sched get idle state helper Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 2/7] cpuidle: Add cpu poke support Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 3/7] smp: Poke the cores before requesting IPI Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 4/7] psci: Add cpu_poke ops to support core poking Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 5/7] cpuidle-arm: Add ops to support poke alonside enter Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 6/7] cpuidle-arm: Add arm64 wake helper for cpu_poke op Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 7/7] arm64: dts: imx8mq: Add cpu-sleep state with poke wake-up enabled Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 15:44 ` [RFC 0/7] cpuidle: Add poking mechanism to support non-IPI wakeup Lucas Stach
2019-03-27 15:44   ` Lucas Stach
2019-03-27 15:44   ` Lucas Stach
2019-03-27 15:57   ` Marc Zyngier
2019-03-27 15:57     ` Marc Zyngier
2019-03-27 15:57     ` Marc Zyngier
2019-03-27 16:06     ` Lucas Stach
2019-03-27 16:06       ` Lucas Stach
2019-03-27 16:06       ` Lucas Stach
2019-03-27 17:00       ` Leonard Crestez
2019-03-27 17:00         ` Leonard Crestez
2019-03-27 17:00         ` Leonard Crestez
2019-03-27 17:11         ` Lucas Stach
2019-03-27 17:11           ` Lucas Stach
2019-03-27 17:11           ` Lucas Stach
2019-03-27 18:13         ` Marc Zyngier
2019-03-27 18:13           ` Marc Zyngier
2019-03-27 18:13           ` Marc Zyngier
2019-03-28 11:21           ` Aisheng Dong
2019-03-28 11:21             ` Aisheng Dong
2019-03-28 11:21             ` Aisheng Dong
2019-03-29  9:11             ` Richard Zhu
2019-03-29  9:11               ` Richard Zhu
2019-03-29  9:11               ` Richard Zhu
2019-03-27 17:45       ` Marc Zyngier
2019-03-27 17:45         ` Marc Zyngier
2019-03-27 17:45         ` Marc Zyngier
2019-03-27 17:55         ` Lucas Stach
2019-03-27 17:55           ` Lucas Stach
2019-03-27 17:55           ` Lucas Stach
2019-03-28 11:27           ` Aisheng Dong [this message]
2019-03-28 11:27             ` Aisheng Dong
2019-03-28 11:27             ` Aisheng Dong
2019-03-27 18:40         ` Leonard Crestez
2019-03-27 18:40           ` Leonard Crestez
2019-03-27 18:40           ` Leonard Crestez
2019-03-28 10:35           ` Marc Zyngier
2019-03-28 10:35             ` Marc Zyngier
2019-03-28 10:35             ` Marc Zyngier
2019-03-28 10:36             ` Rafael J. Wysocki
2019-03-28 10:36               ` Rafael J. Wysocki
2019-03-28 10:36               ` Rafael J. Wysocki
2019-03-28 11:55             ` Aisheng Dong
2019-03-28 11:55               ` Aisheng Dong
2019-03-28 11:55               ` Aisheng Dong
2019-03-28 10:45           ` Lorenzo Pieralisi
2019-03-28 10:45             ` Lorenzo Pieralisi
2019-03-28 10:45             ` Lorenzo Pieralisi
2019-11-06 20:14             ` Florian Fainelli
2019-11-06 20:14               ` Florian Fainelli
2019-11-06 21:31               ` Leonard Crestez
2019-11-06 21:31                 ` Leonard Crestez
2019-11-06 22:10                 ` Florian Fainelli
2019-11-06 22:10                   ` Florian Fainelli
2019-11-06 22:47                   ` Leonard Crestez
2019-11-06 22:47                     ` Leonard Crestez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR04MB4211673DC2071A6181B0948880590@AM0PR04MB4211.eurprd04.prod.outlook.com \
    --to=aisheng.dong@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=catalin.marinas@arm.com \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.