From: Peng Fan <peng.fan@nxp.com> To: Oleksij Rempel <o.rempel@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>, Leonard Crestez <leonard.crestez@nxp.com> Cc: Aisheng Dong <aisheng.dong@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Richard Zhu <hongxing.zhu@nxp.com>, "m.felsch@pengutronix.de" <m.felsch@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH 1/3] dt-bindings: mailbox: imx-mu: add fsl,scu property Date: Mon, 24 Feb 2020 13:33:07 +0000 [thread overview] Message-ID: <AM0PR04MB4481FF0A89B56963AF525B7A88EC0@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw) In-Reply-To: <ad6b8ee4-f5c5-dc44-b06e-d265101ce5ad@pengutronix.de> Hi Oleksij, > Subject: Re: [PATCH 1/3] dt-bindings: mailbox: imx-mu: add fsl,scu property > > Hi Peng, > > On 24.02.20 13:14, peng.fan@nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add fsl,scu property, this needs to be enabled for SCU channel type. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > Documentation/devicetree/bindings/mailbox/fsl,mu.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > b/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > > index 9c43357c5924..5b502bcf7122 100644 > > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > > @@ -45,6 +45,7 @@ Optional properties: > > ------------------- > > - clocks : phandle to the input clock. > > - fsl,mu-side-b : Should be set for side B MU. > > +- fsl,scu: Support i.MX8/8X SCU channel type From RM, one of the MU using example. 12.9.2.3.2 Messaging Examples The following are messaging examples: • Passing short messages: Transmit register(s) can be used to pass short messages from one to four words in length. For example, when a four-word message is desired, only one of the registers needs to have its corresponding interrupt enable bit set at the receiver side; the message’s first three words are written to the registers whose interrupt is masked, and the fourth word is written to the other register (which triggers an interrupt at the receiver side). So we could define flexible channel, but not restricted only one TR0 or RR0 register. And SCFW SCU side IPC is using "Passing short messages" method. > > Hm.. what you are doing is a "link aggregation" with round-robin scheduling: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wik > ipedia.org%2Fwiki%2FLink_aggregation&data=02%7C01%7Cpeng.fan%4 > 0nxp.com%7C23f8a75e19a4484159d908d7b92a6524%7C686ea1d3bc2b4c6f > a92cd99c5c301635%7C0%7C0%7C637181464049069832&sdata=yGyL3 > GwLvzkNh%2Btsl8Qc%2B5CgAtpooOocxXpUrsJ7Kg8%3D&reserved=0 Due to SCFW message is not fixed length, driver has to parse the msg header to know how many to transmit and how many to receive. > > I would be happy if we can define a generic mailbox property for this. Any suggestions? I am thinking mbox_send_message_size with an extra size parameter from firmware client side. But not have good idea on rx. Thanks, Peng. > > Kind regards, > Oleksij Rempel > > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p > engutronix.de%2F&data=02%7C01%7Cpeng.fan%40nxp.com%7C23f8a7 > 5e19a4484159d908d7b92a6524%7C686ea1d3bc2b4c6fa92cd99c5c301635% > 7C0%7C0%7C637181464049079826&sdata=1hEs2jScRBEGAS%2FrzD8i6l > R%2FRybXu8hiq8hfQ3wDQ8I%3D&reserved=0 | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: Oleksij Rempel <o.rempel@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>, Leonard Crestez <leonard.crestez@nxp.com> Cc: Aisheng Dong <aisheng.dong@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Richard Zhu <hongxing.zhu@nxp.com>, "m.felsch@pengutronix.de" <m.felsch@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH 1/3] dt-bindings: mailbox: imx-mu: add fsl,scu property Date: Mon, 24 Feb 2020 13:33:07 +0000 [thread overview] Message-ID: <AM0PR04MB4481FF0A89B56963AF525B7A88EC0@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw) In-Reply-To: <ad6b8ee4-f5c5-dc44-b06e-d265101ce5ad@pengutronix.de> Hi Oleksij, > Subject: Re: [PATCH 1/3] dt-bindings: mailbox: imx-mu: add fsl,scu property > > Hi Peng, > > On 24.02.20 13:14, peng.fan@nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add fsl,scu property, this needs to be enabled for SCU channel type. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > Documentation/devicetree/bindings/mailbox/fsl,mu.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > b/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > > index 9c43357c5924..5b502bcf7122 100644 > > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.txt > > @@ -45,6 +45,7 @@ Optional properties: > > ------------------- > > - clocks : phandle to the input clock. > > - fsl,mu-side-b : Should be set for side B MU. > > +- fsl,scu: Support i.MX8/8X SCU channel type From RM, one of the MU using example. 12.9.2.3.2 Messaging Examples The following are messaging examples: • Passing short messages: Transmit register(s) can be used to pass short messages from one to four words in length. For example, when a four-word message is desired, only one of the registers needs to have its corresponding interrupt enable bit set at the receiver side; the message’s first three words are written to the registers whose interrupt is masked, and the fourth word is written to the other register (which triggers an interrupt at the receiver side). So we could define flexible channel, but not restricted only one TR0 or RR0 register. And SCFW SCU side IPC is using "Passing short messages" method. > > Hm.. what you are doing is a "link aggregation" with round-robin scheduling: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wik > ipedia.org%2Fwiki%2FLink_aggregation&data=02%7C01%7Cpeng.fan%4 > 0nxp.com%7C23f8a75e19a4484159d908d7b92a6524%7C686ea1d3bc2b4c6f > a92cd99c5c301635%7C0%7C0%7C637181464049069832&sdata=yGyL3 > GwLvzkNh%2Btsl8Qc%2B5CgAtpooOocxXpUrsJ7Kg8%3D&reserved=0 Due to SCFW message is not fixed length, driver has to parse the msg header to know how many to transmit and how many to receive. > > I would be happy if we can define a generic mailbox property for this. Any suggestions? I am thinking mbox_send_message_size with an extra size parameter from firmware client side. But not have good idea on rx. Thanks, Peng. > > Kind regards, > Oleksij Rempel > > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p > engutronix.de%2F&data=02%7C01%7Cpeng.fan%40nxp.com%7C23f8a7 > 5e19a4484159d908d7b92a6524%7C686ea1d3bc2b4c6fa92cd99c5c301635% > 7C0%7C0%7C637181464049079826&sdata=1hEs2jScRBEGAS%2FrzD8i6l > R%2FRybXu8hiq8hfQ3wDQ8I%3D&reserved=0 | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-24 13:33 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-24 12:14 [PATCH 0/3] mailbox/firmware: imx: support SCU channel type peng.fan 2020-02-24 12:14 ` peng.fan 2020-02-24 12:14 ` [PATCH 1/3] dt-bindings: mailbox: imx-mu: add fsl,scu property peng.fan 2020-02-24 12:14 ` peng.fan 2020-02-24 13:06 ` Oleksij Rempel 2020-02-24 13:06 ` Oleksij Rempel 2020-02-24 13:33 ` Peng Fan [this message] 2020-02-24 13:33 ` Peng Fan 2020-02-28 15:13 ` Rob Herring 2020-02-28 15:13 ` Rob Herring 2020-02-29 2:09 ` Peng Fan 2020-02-29 2:09 ` Peng Fan 2020-02-24 12:14 ` [PATCH 2/3] mailbox: imx: support SCU channel type peng.fan 2020-02-24 12:14 ` peng.fan 2020-02-24 12:14 ` [PATCH 3/3] firmware: imx-scu: Support one TX and one RX peng.fan 2020-02-24 12:14 ` peng.fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB4481FF0A89B56963AF525B7A88EC0@AM0PR04MB4481.eurprd04.prod.outlook.com \ --to=peng.fan@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=hongxing.zhu@nxp.com \ --cc=jassisinghbrar@gmail.com \ --cc=kernel@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=m.felsch@pengutronix.de \ --cc=o.rempel@pengutronix.de \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.