From: Liming Sun <lsun@mellanox.com> To: Arnd Bergmann <arnd@arndb.de> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, David Woods <dwoods@mellanox.com>, arm-soc <arm@kernel.org>, Olof Johansson <olof@lixom.net>, Robin Murphy <robin.murphy@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v4 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Date: Fri, 26 Oct 2018 19:36:37 +0000 [thread overview] Message-ID: <AM4PR05MB3220F4E5EEB673F0CC97C11DA1F00@AM4PR05MB3220.eurprd05.prod.outlook.com> (raw) In-Reply-To: <CAK8P3a1K7BjgZRyBMKFrqWfcr-Bb3HQus+QE7qTpd27voE9e0A@mail.gmail.com> Thanks Arnd for the comments! Please see the response inline. - Liming > -----Original Message----- > From: arndbergmann@gmail.com [mailto:arndbergmann@gmail.com] On > Behalf Of Arnd Bergmann > Sent: Thursday, October 25, 2018 11:33 AM > To: Liming Sun <lsun@mellanox.com> > Cc: Olof Johansson <olof@lixom.net>; David Woods > <dwoods@mellanox.com>; Robin Murphy <robin.murphy@arm.com>; arm- > soc <arm@kernel.org>; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v4 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox > BlueField SoC > > On 10/24/18, Liming Sun <lsun@mellanox.com> wrote: > > Add devicetree bindings for the TmFifo which is found on Mellanox > > BlueField SoCs. > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Reviewed-by: David Woods <dwoods@mellanox.com> > > Signed-off-by: Liming Sun <lsun@mellanox.com> > > --- > > .../devicetree/bindings/soc/mellanox/tmfifo.txt | 23 > > ++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > > > diff --git a/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > b/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > new file mode 100644 > > index 0000000..8a13fa6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > @@ -0,0 +1,23 @@ > > +* Mellanox BlueField SoC TmFifo > > + > > +BlueField TmFifo provides a shared FIFO between the target and the > > +external host machine, which can be accessed by external host via > > +USB or PCIe. In the current tmfifo driver, this FIFO has been demuxed > > +to implement virtual console and network interface based on the virtio > > +framework. > > + > > +Required properties: > > + > > +- compatible: Should be "mellanox,bf-tmfifo" > > +- reg: Physical base address and length of Rx/Tx block > > +- interrupts: The interrupt number of Rx low water mark, Rx high water > > mark > > + Tx low water mark, Tx high water mark respectively. > > > This sounds like it might fit into the mailbox subsystem, and perhaps > it should use the mailbox DT bindings. Have you had a look at that? This commit of dt-bindings is mainly to solve the warning of checkpatch.pl. Like the response to patch 2/4, ACPI is actually used now instead of device tree. The TMFIFO definition in the ACPI DSDT table would be something like below. // RShim TMFIFO Device(RSH0) { Name(_HID, "MLNXBF01") Name(_UID, Zero) Name(_CCA, 1) Name(_CRS, ResourceTemplate() { Memory32Fixed(ReadWrite, 0x00800a20, 0x00000018) Memory32Fixed(ReadWrite, 0x00800a40, 0x00000018) Interrupt(ResourceConsumer, Edge, ActiveHigh, Exclusive) { BF1_RSH0_TM_HTT_LWM_INT, BF1_RSH0_TM_HTT_HWM_INT, BF1_RSH0_TM_TTH_LWM_INT, BF1_RSH0_TM_TTH_HWM_INT } }) } Any suggestion how it should be added into Linux Documentation, or maybe I should just remove this commit from this patch series? As for the sub-component of this driver, the "soc" might be better fit than the mailbox for some reasons. It's a communication between extern machines and the SoC via USB / PCIe, like pushing boot stream, console and network mgmt. Some of the features, like pushing boot stream, doesn't communicate with the ARM core. The boot stream is pushed to the SoC HW logic directly. I'll add the host-side virtio-based driver in patch v5. > > Arnd
WARNING: multiple messages have this Message-ID (diff)
From: lsun@mellanox.com (Liming Sun) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Date: Fri, 26 Oct 2018 19:36:37 +0000 [thread overview] Message-ID: <AM4PR05MB3220F4E5EEB673F0CC97C11DA1F00@AM4PR05MB3220.eurprd05.prod.outlook.com> (raw) In-Reply-To: <CAK8P3a1K7BjgZRyBMKFrqWfcr-Bb3HQus+QE7qTpd27voE9e0A@mail.gmail.com> Thanks Arnd for the comments! Please see the response inline. - Liming > -----Original Message----- > From: arndbergmann at gmail.com [mailto:arndbergmann at gmail.com] On > Behalf Of Arnd Bergmann > Sent: Thursday, October 25, 2018 11:33 AM > To: Liming Sun <lsun@mellanox.com> > Cc: Olof Johansson <olof@lixom.net>; David Woods > <dwoods@mellanox.com>; Robin Murphy <robin.murphy@arm.com>; arm- > soc <arm@kernel.org>; devicetree at vger.kernel.org; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH v4 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox > BlueField SoC > > On 10/24/18, Liming Sun <lsun@mellanox.com> wrote: > > Add devicetree bindings for the TmFifo which is found on Mellanox > > BlueField SoCs. > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Reviewed-by: David Woods <dwoods@mellanox.com> > > Signed-off-by: Liming Sun <lsun@mellanox.com> > > --- > > .../devicetree/bindings/soc/mellanox/tmfifo.txt | 23 > > ++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > > > diff --git a/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > b/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > new file mode 100644 > > index 0000000..8a13fa6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt > > @@ -0,0 +1,23 @@ > > +* Mellanox BlueField SoC TmFifo > > + > > +BlueField TmFifo provides a shared FIFO between the target and the > > +external host machine, which can be accessed by external host via > > +USB or PCIe. In the current tmfifo driver, this FIFO has been demuxed > > +to implement virtual console and network interface based on the virtio > > +framework. > > + > > +Required properties: > > + > > +- compatible: Should be "mellanox,bf-tmfifo" > > +- reg: Physical base address and length of Rx/Tx block > > +- interrupts: The interrupt number of Rx low water mark, Rx high water > > mark > > + Tx low water mark, Tx high water mark respectively. > > > This sounds like it might fit into the mailbox subsystem, and perhaps > it should use the mailbox DT bindings. Have you had a look at that? This commit of dt-bindings is mainly to solve the warning of checkpatch.pl. Like the response to patch 2/4, ACPI is actually used now instead of device tree. The TMFIFO definition in the ACPI DSDT table would be something like below. // RShim TMFIFO Device(RSH0) { Name(_HID, "MLNXBF01") Name(_UID, Zero) Name(_CCA, 1) Name(_CRS, ResourceTemplate() { Memory32Fixed(ReadWrite, 0x00800a20, 0x00000018) Memory32Fixed(ReadWrite, 0x00800a40, 0x00000018) Interrupt(ResourceConsumer, Edge, ActiveHigh, Exclusive) { BF1_RSH0_TM_HTT_LWM_INT, BF1_RSH0_TM_HTT_HWM_INT, BF1_RSH0_TM_TTH_LWM_INT, BF1_RSH0_TM_TTH_HWM_INT } }) } Any suggestion how it should be added into Linux Documentation, or maybe I should just remove this commit from this patch series? As for the sub-component of this driver, the "soc" might be better fit than the mailbox for some reasons. It's a communication between extern machines and the SoC via USB / PCIe, like pushing boot stream, console and network mgmt. Some of the features, like pushing boot stream, doesn't communicate with the ARM core. The boot stream is pushed to the SoC HW logic directly. I'll add the host-side virtio-based driver in patch v5. > > Arnd
next prev parent reply other threads:[~2018-10-26 19:36 UTC|newest] Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-25 16:06 [PATCH v1 1/4] soc: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2018-05-25 16:06 ` Liming Sun 2018-05-25 16:06 ` [PATCH v1 2/4] arm64: Add Mellanox BlueField SoC config option Liming Sun 2018-05-25 16:06 ` Liming Sun 2018-05-25 16:06 ` [PATCH v1 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2018-05-25 16:06 ` Liming Sun 2018-05-25 16:06 ` [PATCH v1 4/4] MAINTAINERS: Add entry for Mellanox Bluefield Soc Liming Sun 2018-05-25 16:06 ` Liming Sun 2018-05-25 17:14 ` [PATCH v1 1/4] soc: Add TmFifo driver for Mellanox BlueField Soc Robin Murphy 2018-05-25 17:14 ` Robin Murphy 2018-05-25 20:18 ` Liming Sun 2018-05-25 20:18 ` Liming Sun 2018-05-25 20:17 ` [PATCH v2 " Liming Sun 2018-05-25 20:17 ` Liming Sun 2018-05-25 20:17 ` [PATCH v2 2/4] arm64: Add Mellanox BlueField SoC config option Liming Sun 2018-05-25 20:17 ` Liming Sun 2018-05-25 20:17 ` [PATCH v2 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2018-05-25 20:17 ` Liming Sun 2018-05-31 3:43 ` Rob Herring 2018-05-31 3:43 ` Rob Herring 2018-06-01 14:31 ` Liming Sun 2018-06-01 14:31 ` Liming Sun 2018-05-25 20:17 ` [PATCH v2 4/4] MAINTAINERS: Add entry for Mellanox Bluefield Soc Liming Sun 2018-05-25 20:17 ` Liming Sun 2018-06-01 14:31 ` [PATCH v3 1/4] soc: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2018-06-01 14:31 ` Liming Sun 2018-06-01 14:31 ` [PATCH v3 2/4] arm64: Add Mellanox BlueField SoC config option Liming Sun 2018-06-01 14:31 ` Liming Sun 2018-06-01 14:31 ` [PATCH v3 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2018-06-01 14:31 ` Liming Sun 2018-06-11 18:19 ` Rob Herring 2018-06-11 18:19 ` Rob Herring 2018-06-01 14:31 ` [PATCH v3 4/4] MAINTAINERS: Add entry for Mellanox Bluefield Soc Liming Sun 2018-06-01 14:31 ` Liming Sun 2018-10-24 17:55 ` [PATCH v4 1/4] soc: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2018-10-24 17:55 ` Liming Sun 2018-10-25 15:57 ` Arnd Bergmann 2018-10-25 15:57 ` Arnd Bergmann 2018-10-26 18:24 ` Liming Sun 2018-10-26 18:24 ` Liming Sun 2018-10-26 18:35 ` Arnd Bergmann 2018-10-26 18:35 ` Arnd Bergmann 2018-10-29 14:17 ` Liming Sun 2018-10-29 14:17 ` Liming Sun 2018-10-29 14:52 ` Arnd Bergmann 2018-10-29 14:52 ` Arnd Bergmann 2018-12-04 22:12 ` Liming Sun 2018-12-04 22:12 ` Liming Sun 2018-10-24 17:55 ` [PATCH v4 2/4] arm64: Add Mellanox BlueField SoC config option Liming Sun 2018-10-24 17:55 ` Liming Sun 2018-10-25 15:38 ` Arnd Bergmann 2018-10-25 15:38 ` Arnd Bergmann 2018-10-26 19:18 ` Liming Sun 2018-10-26 19:18 ` Liming Sun 2018-10-26 19:32 ` Arnd Bergmann 2018-10-26 19:32 ` Arnd Bergmann 2018-10-29 14:58 ` Liming Sun 2018-10-29 14:58 ` Liming Sun 2018-10-29 15:26 ` Arnd Bergmann 2018-10-29 15:26 ` Arnd Bergmann 2018-10-29 16:09 ` Liming Sun 2018-10-29 16:09 ` Liming Sun 2018-10-24 17:55 ` [PATCH v4 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2018-10-24 17:55 ` Liming Sun 2018-10-25 15:32 ` Arnd Bergmann 2018-10-25 15:32 ` Arnd Bergmann 2018-10-26 19:36 ` Liming Sun [this message] 2018-10-26 19:36 ` Liming Sun 2018-10-26 20:33 ` Arnd Bergmann 2018-10-26 20:33 ` Arnd Bergmann 2018-10-29 16:48 ` Liming Sun 2018-10-29 16:48 ` Liming Sun 2019-01-24 15:07 ` Liming Sun 2019-01-24 15:07 ` Liming Sun 2018-10-24 17:55 ` [PATCH v4 4/4] MAINTAINERS: Add entry for Mellanox Bluefield Soc Liming Sun 2018-10-24 17:55 ` Liming Sun 2018-10-31 18:09 ` [PATCH v5 1/5] soc: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2018-10-31 18:09 ` Liming Sun 2018-10-31 18:09 ` [PATCH v5 2/5] arm64: Add Mellanox BlueField SoC config option Liming Sun 2018-10-31 18:09 ` Liming Sun 2018-10-31 18:09 ` [PATCH v5 3/5] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2018-10-31 18:09 ` Liming Sun 2018-10-31 18:09 ` [PATCH v5 4/5] MAINTAINERS: Add entry for Mellanox Bluefield Soc Liming Sun 2018-10-31 18:09 ` Liming Sun 2018-10-31 18:09 ` [PATCH v5 5/5] soc: mellanox: Add host side drivers to support Mellanox BlueField SoCs Liming Sun 2018-11-01 16:23 ` [PATCH v6 1/9] soc: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2018-11-01 16:23 ` Liming Sun 2018-12-12 23:07 ` Matthias Brugger 2018-12-12 23:07 ` Matthias Brugger 2019-01-03 19:20 ` Liming Sun 2019-01-03 19:20 ` Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 2/9] arm64: Add Mellanox BlueField SoC config option Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 3/9] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 4/9] MAINTAINERS: Add entry for Mellanox Bluefield Soc Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 5/9] soc: mellanox: host: Add the common host side Rshim driver Liming Sun 2018-11-01 16:25 ` Liming Sun 2019-01-18 16:02 ` Arnd Bergmann 2019-01-18 16:02 ` Arnd Bergmann 2019-01-18 16:02 ` Arnd Bergmann 2019-01-21 19:22 ` Liming Sun 2019-01-21 19:22 ` Liming Sun 2019-01-21 19:22 ` Liming Sun 2019-01-22 12:20 ` Vincent Whitchurch 2019-01-22 12:20 ` Vincent Whitchurch 2019-01-22 12:20 ` Vincent Whitchurch 2019-01-22 13:27 ` Liming Sun 2019-01-22 13:36 ` Liming Sun 2019-01-22 13:36 ` Liming Sun 2019-01-22 13:36 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 6/9] soc: mellanox: host: Add networking support over Rshim Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 7/9] soc: mellanox: host: Add the Rshim USB backend driver Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 8/9] soc: mellanox: host: Add the Rshim PCIe " Liming Sun 2018-11-01 16:25 ` Liming Sun 2018-11-01 16:25 ` [PATCH v6 9/9] soc: mellanox: host: Add the Rshim PCIe live-fish " Liming Sun 2018-11-01 16:25 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 1/9] soc: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-03-15 13:18 ` Matthias Brugger 2019-03-15 13:18 ` Matthias Brugger 2019-01-03 19:17 ` [PATCH v7 2/9] arm64: Add Mellanox BlueField SoC config option Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 3/9] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 4/9] MAINTAINERS: Add entry for Mellanox Bluefield Soc Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 5/9] soc: mellanox: host: Add the common host side Rshim driver Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 6/9] soc: mellanox: host: Add networking support over Rshim Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 7/9] soc: mellanox: host: Add the Rshim USB backend driver Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 8/9] soc: mellanox: host: Add the Rshim PCIe " Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-03 19:17 ` [PATCH v7 9/9] soc: mellanox: host: Add the Rshim PCIe live-fish " Liming Sun 2019-01-03 19:17 ` Liming Sun 2019-01-21 19:17 ` [PATCH v7 0/9] Mellanox BlueField ARM SoC Rshim driver Liming Sun 2019-01-21 19:17 ` Liming Sun 2019-02-18 13:24 ` Arnd Bergmann 2019-02-18 13:24 ` Arnd Bergmann 2019-01-28 17:28 ` [PATCH v8 0/2] TmFifo platform driver for Mellanox BlueField SoC Liming Sun 2019-01-28 17:28 ` [PATCH v8 1/2] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2019-01-29 22:06 ` Andy Shevchenko 2019-02-13 13:34 ` Liming Sun 2019-02-13 16:33 ` Liming Sun 2019-01-30 6:24 ` Vadim Pasternak 2019-01-30 6:24 ` Vadim Pasternak 2019-02-13 13:42 ` Liming Sun 2019-01-28 17:28 ` [PATCH v8 2/2] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC Liming Sun 2019-02-13 13:27 ` [PATCH v9] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc Liming Sun 2019-02-13 18:11 ` Andy Shevchenko 2019-02-13 18:34 ` Liming Sun 2019-02-14 16:25 ` Liming Sun 2019-02-28 15:51 ` Liming Sun 2019-02-28 15:51 ` [PATCH v10] " Liming Sun 2019-03-05 15:34 ` Andy Shevchenko 2019-03-06 20:00 ` Liming Sun 2019-03-08 14:44 ` Liming Sun 2019-03-08 14:41 ` [PATCH v11] " Liming Sun 2019-03-26 21:13 ` Liming Sun 2019-03-28 19:56 ` [PATCH v12] " Liming Sun 2019-04-04 19:36 ` [PATCH v13] " Liming Sun 2019-04-05 15:44 ` Andy Shevchenko 2019-04-05 19:10 ` Liming Sun 2019-04-07 2:05 ` Liming Sun 2019-04-11 14:13 ` Andy Shevchenko 2019-04-12 16:15 ` Liming Sun 2019-04-07 2:03 ` [PATCH v14] " Liming Sun 2019-04-11 14:09 ` Andy Shevchenko 2019-04-12 14:23 ` Liming Sun 2019-04-12 17:30 ` [PATCH v15] " Liming Sun 2019-05-03 13:49 ` [PATCH v16] " Liming Sun 2019-05-06 9:13 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM4PR05MB3220F4E5EEB673F0CC97C11DA1F00@AM4PR05MB3220.eurprd05.prod.outlook.com \ --to=lsun@mellanox.com \ --cc=arm@kernel.org \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=dwoods@mellanox.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=olof@lixom.net \ --cc=robin.murphy@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.