RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

From: Anson Huang <anson.huang@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Dong Aisheng <dongas86@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Abel Vesa <abel.vesa@nxp.com>, YueHaibing <yuehaibing@huawei.com>,
	Russell King <linux@armlinux.org.uk>,
	Allison Randal <allison@lohutok.net>,
	dl-linux-imx <linux-imx@nxp.com>,
	Stefan Agner <stefan.agner@toradex.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	ARM/FREESCALE IMX / MXC ARM ARCHITECTURE 
	<linux-arm-kernel@lists.infradead.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Andy Duan <fugang.duan@nxp.com>,
	gregkh <gregkh@linuxfoundation.org>,
	open list <linux-kernel@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Enrico Weigelt <info@metux.net>
Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module
Date: Thu, 2 Jul 2020 06:15:05 +0000	[thread overview]
Message-ID: <AM6PR0402MB391135EDF34C7207AC37D42DF56D0@AM6PR0402MB3911.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <159346473301.62212.686512161256425690@swboyd.mtv.corp.google.com>

Hi, Arnd/Stephen

> Subject: Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as
> module
> 
> Quoting Arnd Bergmann (2020-06-29 01:19:44)
> > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng <dongas86@gmail.com>
> wrote:
> > > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd <sboyd@kernel.org>
> wrote:
> > > > Quoting Aisheng Dong (2020-06-23 19:59:09) Why aren't there
> > > > options to enable clk-imx6q and clk-imx6sl in the clk/imx/Kconfig
> > > > file? Those can be bool or tristate depending on if the SoC
> > > > drivers use CLK_OF_DECLARE or not and depend on the mxc-clk
> > > > library and SoC config we have in the makefile today.
> > >
> > > Yes, we can do that in clk/imx/Kconfig as follows theoretically.
> > > config CLK_IMX6Q
> > >         bool
> > >         def_bool ARCH_MXC && ARM
> > >         select MXC_CLK
> > >
> > > But we have totally 15 platforms that need to change.
> >
> > I would make that
> >
> > config CLK_IMX6Q
> >          bool "Clock driver for NXP i.MX6Q"
> >          depends on SOC_IMX6Q || COMPILE_TEST
> >          default SOC_IMX6Q
> >          select MXC_CLK
> 
> Yes, do this.

The COMPILE_TEST existing on the config will introduce some build error
on other ARCH's allyesconfig build on i.MX2/3 platforms, I received some build error report.
So in next patch series, I will drop the COMPILE_TEST for these new added clock configurations,
as I think it is NOT worth to support the COMPILE_TEST for these old legacy platforms which are
NOT supported before.

Thanks,
Anson