From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: 'Dave Jiang' <dave.jiang@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: RE: [PATCH] mm: disallow mapping that conflict for devm_memremap_pages()
Date: Thu, 14 Jun 2018 19:37:08 +0000 [thread overview]
Message-ID: <AT5PR8401MB11698094C482D26E172B8E41AB7D0@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <152900070339.49084.2958083852988708457.stgit@djiang5-desk3.ch.intel.com>
> -----Original Message-----
> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of
> Dave Jiang
> Sent: Thursday, June 14, 2018 1:25 PM
> Subject: [PATCH] mm: disallow mapping that conflict for
> devm_memremap_pages()
...
> + conflict_pgmap = get_dev_pagemap(PHYS_PFN(align_start), NULL);
> + if (conflict_pgmap) {
> + dev_warn(dev, "Conflicting mapping in same section\n");
> + put_dev_pagemap(conflict_pgmap);
> + return ERR_PTR(-ENOMEM);
> + }
> +
> + conflict_pgmap = get_dev_pagemap(PHYS_PFN(align_end), NULL);
> + if (conflict_pgmap) {
> + dev_warn(dev, "Conflicting mapping in same section\n");
> + put_dev_pagemap(conflict_pgmap);
> + return ERR_PTR(-ENOMEM);
> + }
Unique warning messages would help narrow down the problem.
dev_WARN is one way to make them unique, if a backtrace is also appropriate.
---
Robert Elliott, HPE Persistent Memory
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: 'Dave Jiang' <dave.jiang@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: RE: [PATCH] mm: disallow mapping that conflict for devm_memremap_pages()
Date: Thu, 14 Jun 2018 19:37:08 +0000 [thread overview]
Message-ID: <AT5PR8401MB11698094C482D26E172B8E41AB7D0@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <152900070339.49084.2958083852988708457.stgit@djiang5-desk3.ch.intel.com>
> -----Original Message-----
> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of
> Dave Jiang
> Sent: Thursday, June 14, 2018 1:25 PM
> Subject: [PATCH] mm: disallow mapping that conflict for
> devm_memremap_pages()
...
> + conflict_pgmap = get_dev_pagemap(PHYS_PFN(align_start), NULL);
> + if (conflict_pgmap) {
> + dev_warn(dev, "Conflicting mapping in same section\n");
> + put_dev_pagemap(conflict_pgmap);
> + return ERR_PTR(-ENOMEM);
> + }
> +
> + conflict_pgmap = get_dev_pagemap(PHYS_PFN(align_end), NULL);
> + if (conflict_pgmap) {
> + dev_warn(dev, "Conflicting mapping in same section\n");
> + put_dev_pagemap(conflict_pgmap);
> + return ERR_PTR(-ENOMEM);
> + }
Unique warning messages would help narrow down the problem.
dev_WARN is one way to make them unique, if a backtrace is also appropriate.
---
Robert Elliott, HPE Persistent Memory
next prev parent reply other threads:[~2018-06-14 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 18:25 [PATCH] mm: disallow mapping that conflict for devm_memremap_pages() Dave Jiang
2018-06-14 18:25 ` Dave Jiang
2018-06-14 19:37 ` Elliott, Robert (Persistent Memory) [this message]
2018-06-14 19:37 ` Elliott, Robert (Persistent Memory)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AT5PR8401MB11698094C482D26E172B8E41AB7D0@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=dave.jiang@intel.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.