From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 0/8] net: stmmac: Fixes for -net
Date: Mon, 16 Dec 2019 09:26:22 +0000 [thread overview]
Message-ID: <BN8PR12MB326639325F465266DEACAA64D3510@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20191213162216.2dc8a108@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Dec/14/2019, 00:22:16 (UTC+00:00)
> On Tue, 10 Dec 2019 20:33:52 +0100, Jose Abreu wrote:
> > Fixes for stmmac.
> >
> > 1) Fixes the filtering selftests (again) for cases when the number of multicast
> > filters are not enough.
> >
> > 2) Fixes SPH feature for MTU > default.
> >
> > 3) Fixes the behavior of accepting invalid MTU values.
> >
> > 4) Fixes FCS stripping for multi-descriptor packets.
> >
> > 5) Fixes the change of RX buffer size in XGMAC.
> >
> > 6) Fixes RX buffer size alignment.
> >
> > 7) Fixes the 16KB buffer alignment.
> >
> > 8) Fixes the enabling of 16KB buffer size feature.
>
> Hi Jose!
>
> Patches directed at net should have a Fixes tag identifying the commit
> which introduced the problem. The commit messages should also describe
> user-visible outcomes of the bugs. Without those two its hard to judge
> which patches are important for stable backports.
>
> Could you please repost with appropriate Fixes tags?
I agree with you Jakub but although these are bugs they are either for
recently introduced features (such as SPH and selftests), or for
features that are not commonly used. I can dig into the GIT history and
provide fixes tag for them all or I can always provide a backport fix if
any user requires so. Can you please comment on which one you prefer ?
---
Thanks,
Jose Miguel Abreu
WARNING: multiple messages have this Message-ID (diff)
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH net 0/8] net: stmmac: Fixes for -net
Date: Mon, 16 Dec 2019 09:26:22 +0000 [thread overview]
Message-ID: <BN8PR12MB326639325F465266DEACAA64D3510@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20191213162216.2dc8a108@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Dec/14/2019, 00:22:16 (UTC+00:00)
> On Tue, 10 Dec 2019 20:33:52 +0100, Jose Abreu wrote:
> > Fixes for stmmac.
> >
> > 1) Fixes the filtering selftests (again) for cases when the number of multicast
> > filters are not enough.
> >
> > 2) Fixes SPH feature for MTU > default.
> >
> > 3) Fixes the behavior of accepting invalid MTU values.
> >
> > 4) Fixes FCS stripping for multi-descriptor packets.
> >
> > 5) Fixes the change of RX buffer size in XGMAC.
> >
> > 6) Fixes RX buffer size alignment.
> >
> > 7) Fixes the 16KB buffer alignment.
> >
> > 8) Fixes the enabling of 16KB buffer size feature.
>
> Hi Jose!
>
> Patches directed at net should have a Fixes tag identifying the commit
> which introduced the problem. The commit messages should also describe
> user-visible outcomes of the bugs. Without those two its hard to judge
> which patches are important for stable backports.
>
> Could you please repost with appropriate Fixes tags?
I agree with you Jakub but although these are bugs they are either for
recently introduced features (such as SPH and selftests), or for
features that are not commonly used. I can dig into the GIT history and
provide fixes tag for them all or I can always provide a backport fix if
any user requires so. Can you please comment on which one you prefer ?
---
Thanks,
Jose Miguel Abreu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-16 9:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 19:33 [PATCH net 0/8] net: stmmac: Fixes for -net Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:33 ` [PATCH net 1/8] net: stmmac: selftests: Needs to check the number of Multicast regs Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:33 ` [PATCH net 2/8] net: stmmac: Determine earlier the size of RX buffer Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:33 ` [PATCH net 3/8] net: stmmac: Do not accept invalid MTU values Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:33 ` [PATCH net 4/8] net: stmmac: Only the last buffer has the FCS field Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:33 ` [PATCH net 5/8] net: stmmac: xgmac: Clear previous RX buffer size Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:33 ` [PATCH net 6/8] net: stmmac: RX buffer size must be 16 byte aligned Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:33 ` [PATCH net 7/8] net: stmmac: 16KB buffer " Jose Abreu
2019-12-10 19:33 ` Jose Abreu
2019-12-10 19:34 ` [PATCH net 8/8] net: stmmac: Enable 16KB buffer size Jose Abreu
2019-12-10 19:34 ` Jose Abreu
2019-12-14 0:22 ` [PATCH net 0/8] net: stmmac: Fixes for -net Jakub Kicinski
2019-12-14 0:22 ` Jakub Kicinski
2019-12-16 9:26 ` Jose Abreu [this message]
2019-12-16 9:26 ` Jose Abreu
2019-12-16 20:21 ` Jakub Kicinski
2019-12-16 20:21 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2019-09-27 7:48 Jose Abreu
2019-09-27 7:48 ` Jose Abreu
2019-09-28 9:01 ` Jose Abreu
2019-09-28 9:01 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB326639325F465266DEACAA64D3510@BN8PR12MB3266.namprd12.prod.outlook.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.