From: Avri Altman <Avri.Altman@wdc.com>
To: Stanley Chu <stanley.chu@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Cc: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"andy.teng@mediatek.com" <andy.teng@mediatek.com>,
"chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
"cc.chou@mediatek.com" <cc.chou@mediatek.com>
Subject: RE: [PATCH 4/4] scsi: ufs-mediatek: Add host reset mechanism
Date: Tue, 29 Sep 2020 11:54:31 +0000 [thread overview]
Message-ID: <BY5PR04MB6705873E1F5DBCE7C97D12AEFC320@BY5PR04MB6705.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20200908064507.30774-5-stanley.chu@mediatek.com>
>
>
> Add host reset mechanism to try to recover host-side errors
> during recovery flow.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by Avri Altman <avri.altman@wdc.com>
See some nit below as well.
Thanks,
Avri
> +static void ufs_mtk_init_reset_control(struct ufs_hba *hba,
> + struct reset_control **rc,
> + char *str)
> +{
> + *rc = devm_reset_control_get(hba->dev, str);
> + if (IS_ERR(*rc)) {
How about verifying that the line is not shared as well?
Although this might not be an issue on your current platforms,
it might save you aggravation in the future..
> + dev_info(hba->dev, "Failed to get reset control %s: %d\n",
> + str, PTR_ERR(*rc));
> + *rc = NULL;
> + }
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Avri Altman <Avri.Altman@wdc.com>
To: Stanley Chu <stanley.chu@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Cc: "bvanassche@acm.org" <bvanassche@acm.org>,
"andy.teng@mediatek.com" <andy.teng@mediatek.com>,
"cc.chou@mediatek.com" <cc.chou@mediatek.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 4/4] scsi: ufs-mediatek: Add host reset mechanism
Date: Tue, 29 Sep 2020 11:54:31 +0000 [thread overview]
Message-ID: <BY5PR04MB6705873E1F5DBCE7C97D12AEFC320@BY5PR04MB6705.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20200908064507.30774-5-stanley.chu@mediatek.com>
>
>
> Add host reset mechanism to try to recover host-side errors
> during recovery flow.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by Avri Altman <avri.altman@wdc.com>
See some nit below as well.
Thanks,
Avri
> +static void ufs_mtk_init_reset_control(struct ufs_hba *hba,
> + struct reset_control **rc,
> + char *str)
> +{
> + *rc = devm_reset_control_get(hba->dev, str);
> + if (IS_ERR(*rc)) {
How about verifying that the line is not shared as well?
Although this might not be an issue on your current platforms,
it might save you aggravation in the future..
> + dev_info(hba->dev, "Failed to get reset control %s: %d\n",
> + str, PTR_ERR(*rc));
> + *rc = NULL;
> + }
> +}
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Avri Altman <Avri.Altman@wdc.com>
To: Stanley Chu <stanley.chu@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Cc: "bvanassche@acm.org" <bvanassche@acm.org>,
"andy.teng@mediatek.com" <andy.teng@mediatek.com>,
"cc.chou@mediatek.com" <cc.chou@mediatek.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 4/4] scsi: ufs-mediatek: Add host reset mechanism
Date: Tue, 29 Sep 2020 11:54:31 +0000 [thread overview]
Message-ID: <BY5PR04MB6705873E1F5DBCE7C97D12AEFC320@BY5PR04MB6705.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20200908064507.30774-5-stanley.chu@mediatek.com>
>
>
> Add host reset mechanism to try to recover host-side errors
> during recovery flow.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by Avri Altman <avri.altman@wdc.com>
See some nit below as well.
Thanks,
Avri
> +static void ufs_mtk_init_reset_control(struct ufs_hba *hba,
> + struct reset_control **rc,
> + char *str)
> +{
> + *rc = devm_reset_control_get(hba->dev, str);
> + if (IS_ERR(*rc)) {
How about verifying that the line is not shared as well?
Although this might not be an issue on your current platforms,
it might save you aggravation in the future..
> + dev_info(hba->dev, "Failed to get reset control %s: %d\n",
> + str, PTR_ERR(*rc));
> + *rc = NULL;
> + }
> +}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-29 11:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 6:45 [PATCH 0/4] scsi: ufs-mediatek: Fixes for kernel v5.10 Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-08 6:45 ` [PATCH 1/4] scsi: ufs-mediatek: Eliminate error message for unbound mphy Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-19 7:31 ` Avri Altman
2020-09-19 7:31 ` Avri Altman
2020-09-19 7:31 ` Avri Altman
2020-09-08 6:45 ` [PATCH 2/4] scsi: ufs-mediatek: Fix HOST_PA_TACTIVATE quirk Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-19 7:53 ` Avri Altman
2020-09-19 7:53 ` Avri Altman
2020-09-19 7:53 ` Avri Altman
2020-09-08 6:45 ` [PATCH 3/4] scsi: ufs-mediatek: Fix flag of unipro low-power mode Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-19 8:08 ` Avri Altman
2020-09-19 8:08 ` Avri Altman
2020-09-19 8:08 ` Avri Altman
2020-10-27 9:52 ` Stanley Chu
2020-10-27 9:52 ` Stanley Chu
2020-10-27 9:52 ` Stanley Chu
2020-09-08 6:45 ` [PATCH 4/4] scsi: ufs-mediatek: Add host reset mechanism Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-08 6:45 ` Stanley Chu
2020-09-29 11:54 ` Avri Altman [this message]
2020-09-29 11:54 ` Avri Altman
2020-09-29 11:54 ` Avri Altman
2020-09-09 2:50 ` [PATCH 0/4] scsi: ufs-mediatek: Fixes for kernel v5.10 Martin K. Petersen
2020-09-09 2:50 ` Martin K. Petersen
2020-09-09 2:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR04MB6705873E1F5DBCE7C97D12AEFC320@BY5PR04MB6705.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.