From: Parav Pandit <parav@nvidia.com> To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com> Cc: Leon Romanovsky <leon@kernel.org>, "Ertman, David M" <david.m.ertman@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "parav@mellanox.com" <parav@mellanox.com>, "tiwai@suse.de" <tiwai@suse.de>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "ranjani.sridharan@linux.intel.com" <ranjani.sridharan@linux.intel.com>, "fred.oh@linux.intel.com" <fred.oh@linux.intel.com>, "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>, "dledford@redhat.com" <dledford@redhat.com>, "broonie@kernel.org" <broonie@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>, "kuba@kernel.org" <kuba@kernel.org>, "Saleem, Shiraz" <shiraz.saleem@intel.com>, "davem@davemloft.net" <davem@davemloft.net>, "Patil, Kiran" <kiran.patil@intel.com> Subject: RE: [PATCH v2 1/6] Add ancillary bus support Date: Thu, 8 Oct 2020 11:10:25 +0000 [thread overview] Message-ID: <BY5PR12MB432291F0683A2295170C2F3BDC0B0@BY5PR12MB4322.namprd12.prod.outlook.com> (raw) In-Reply-To: <20201008075048.GA254837@kroah.com> > From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> > Sent: Thursday, October 8, 2020 1:21 PM > > On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote: > > On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky <leon@kernel.org> > wrote: > > [..] > > > All stated above is my opinion, it can be different from yours. > > > > Yes, but we need to converge to move this forward. Jason was involved > > in the current organization for registration, Greg was angling for > > this to be core functionality. I have use cases outside of RDMA and > > netdev. Parav was ok with the current organization. The SOF folks > > already have a proposed incorporation of it. The argument I am hearing > > is that "this registration api seems hard for driver writers" when we > > have several driver writers who have already taken a look and can make > > it work. If you want to follow on with a simpler wrappers for your use > > case, great, but I do not yet see anyone concurring with your opinion > > that the current organization is irretrievably broken or too obscure > > to use. > > That's kind of because I tuned out of this thread a long time ago :) > > I do agree with Leon that I think the current patch is not the correct way to > do this the easiest, but don't have a competing proposal to show what I > mean. > > Yet. Please consider the approach of ib_alloc_device(), ib_dealloc_device() and ib_register_register()/unregister(). (a) It avoids driver calling put_device() on error unwinding path. (b) still achieves container_of(). > > Let's see what happens after 5.10-rc1 is out, it's too late now for any of this > for this next merge window so we can not worry about it for a few weeks. > Ok. INHO giving direction to Dave and others to either refine current APIs or follow ib_alloc_device() approach will be a helpful input. ancillary bus can do better APIs than the newly (march 2020 !) introduced vdpa bus [1] and its drivers which follows put_device() pattern in [2] and [3] in error unwinding path. [1] https://elixir.bootlin.com/linux/v5.9-rc8/source/drivers/vdpa/vdpa.c [2] https://elixir.bootlin.com/linux/v5.9-rc8/source/drivers/vdpa/ifcvf/ifcvf_main.c#L475 [3] https://elixir.bootlin.com/linux/v5.9-rc8/source/drivers/vdpa/mlx5/net/mlx5_vnet.c#L1967 > thanks, > > greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com> To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com> Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "parav@mellanox.com" <parav@mellanox.com>, Leon Romanovsky <leon@kernel.org>, "tiwai@suse.de" <tiwai@suse.de>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, "ranjani.sridharan@linux.intel.com" <ranjani.sridharan@linux.intel.com>, "fred.oh@linux.intel.com" <fred.oh@linux.intel.com>, "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>, "dledford@redhat.com" <dledford@redhat.com>, "broonie@kernel.org" <broonie@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>, "kuba@kernel.org" <kuba@kernel.org>, "Ertman, David M" <david.m.ertman@intel.com>, "Saleem, Shiraz" <shiraz.saleem@intel.com>, "davem@davemloft.net" <davem@davemloft.net>, "Patil, Kiran" <kiran.patil@intel.com> Subject: RE: [PATCH v2 1/6] Add ancillary bus support Date: Thu, 8 Oct 2020 11:10:25 +0000 [thread overview] Message-ID: <BY5PR12MB432291F0683A2295170C2F3BDC0B0@BY5PR12MB4322.namprd12.prod.outlook.com> (raw) In-Reply-To: <20201008075048.GA254837@kroah.com> > From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> > Sent: Thursday, October 8, 2020 1:21 PM > > On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote: > > On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky <leon@kernel.org> > wrote: > > [..] > > > All stated above is my opinion, it can be different from yours. > > > > Yes, but we need to converge to move this forward. Jason was involved > > in the current organization for registration, Greg was angling for > > this to be core functionality. I have use cases outside of RDMA and > > netdev. Parav was ok with the current organization. The SOF folks > > already have a proposed incorporation of it. The argument I am hearing > > is that "this registration api seems hard for driver writers" when we > > have several driver writers who have already taken a look and can make > > it work. If you want to follow on with a simpler wrappers for your use > > case, great, but I do not yet see anyone concurring with your opinion > > that the current organization is irretrievably broken or too obscure > > to use. > > That's kind of because I tuned out of this thread a long time ago :) > > I do agree with Leon that I think the current patch is not the correct way to > do this the easiest, but don't have a competing proposal to show what I > mean. > > Yet. Please consider the approach of ib_alloc_device(), ib_dealloc_device() and ib_register_register()/unregister(). (a) It avoids driver calling put_device() on error unwinding path. (b) still achieves container_of(). > > Let's see what happens after 5.10-rc1 is out, it's too late now for any of this > for this next merge window so we can not worry about it for a few weeks. > Ok. INHO giving direction to Dave and others to either refine current APIs or follow ib_alloc_device() approach will be a helpful input. ancillary bus can do better APIs than the newly (march 2020 !) introduced vdpa bus [1] and its drivers which follows put_device() pattern in [2] and [3] in error unwinding path. [1] https://elixir.bootlin.com/linux/v5.9-rc8/source/drivers/vdpa/vdpa.c [2] https://elixir.bootlin.com/linux/v5.9-rc8/source/drivers/vdpa/ifcvf/ifcvf_main.c#L475 [3] https://elixir.bootlin.com/linux/v5.9-rc8/source/drivers/vdpa/mlx5/net/mlx5_vnet.c#L1967 > thanks, > > greg k-h
next prev parent reply other threads:[~2020-10-08 11:10 UTC|newest] Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 18:24 [PATCH v2 0/6] Ancillary bus implementation and SOF multi-client support Dave Ertman 2020-10-05 18:24 ` Dave Ertman 2020-10-05 18:24 ` [PATCH v2 1/6] Add ancillary bus support Dave Ertman 2020-10-05 18:24 ` Dave Ertman 2020-10-06 7:18 ` Leon Romanovsky 2020-10-06 7:18 ` Leon Romanovsky 2020-10-06 15:18 ` Pierre-Louis Bossart 2020-10-06 17:02 ` Leon Romanovsky 2020-10-06 17:02 ` Leon Romanovsky 2020-10-06 17:09 ` Parav Pandit 2020-10-06 17:09 ` Parav Pandit 2020-10-06 17:26 ` Leon Romanovsky 2020-10-06 17:26 ` Leon Romanovsky 2020-10-06 17:41 ` Saleem, Shiraz 2020-10-06 17:41 ` Saleem, Shiraz 2020-10-06 19:20 ` Leon Romanovsky 2020-10-06 19:20 ` Leon Romanovsky 2020-10-07 2:49 ` Dan Williams 2020-10-07 2:49 ` Dan Williams 2020-10-07 13:09 ` Saleem, Shiraz 2020-10-07 13:09 ` Saleem, Shiraz 2020-10-07 13:36 ` Leon Romanovsky 2020-10-07 13:36 ` Leon Romanovsky 2020-10-07 18:55 ` Dan Williams 2020-10-07 18:55 ` Dan Williams 2020-10-07 20:01 ` Ertman, David M 2020-10-07 20:01 ` Ertman, David M 2020-10-06 18:35 ` Ranjani Sridharan 2020-10-06 18:35 ` Ranjani Sridharan 2020-10-06 17:50 ` Saleem, Shiraz 2020-10-06 17:50 ` Saleem, Shiraz 2020-10-07 18:06 ` Ertman, David M 2020-10-07 18:06 ` Ertman, David M 2020-10-07 19:26 ` Leon Romanovsky 2020-10-07 19:26 ` Leon Romanovsky 2020-10-07 19:53 ` Ertman, David M 2020-10-07 19:53 ` Ertman, David M 2020-10-07 19:57 ` Ertman, David M 2020-10-07 19:57 ` Ertman, David M 2020-10-07 20:17 ` Parav Pandit 2020-10-07 20:17 ` Parav Pandit 2020-10-07 20:46 ` Ertman, David M 2020-10-07 20:46 ` Ertman, David M 2020-10-07 20:59 ` Pierre-Louis Bossart 2020-10-07 20:59 ` Pierre-Louis Bossart 2020-10-07 21:22 ` Ertman, David M 2020-10-07 21:22 ` Ertman, David M 2020-10-07 21:49 ` Pierre-Louis Bossart 2020-10-07 21:49 ` Pierre-Louis Bossart 2020-10-08 4:56 ` Parav Pandit 2020-10-08 4:56 ` Parav Pandit 2020-10-08 5:26 ` Leon Romanovsky 2020-10-08 5:26 ` Leon Romanovsky 2020-10-08 7:14 ` Parav Pandit 2020-10-08 7:14 ` Parav Pandit 2020-10-08 7:45 ` Leon Romanovsky 2020-10-08 7:45 ` Leon Romanovsky 2020-10-08 9:45 ` Parav Pandit 2020-10-08 9:45 ` Parav Pandit 2020-10-08 10:17 ` Leon Romanovsky 2020-10-08 10:17 ` Leon Romanovsky 2020-10-08 13:29 ` Pierre-Louis Bossart 2020-10-08 13:29 ` Pierre-Louis Bossart 2020-10-09 11:40 ` Leon Romanovsky 2020-10-09 11:40 ` Leon Romanovsky 2020-10-08 16:54 ` Ertman, David M 2020-10-08 16:54 ` Ertman, David M 2020-10-08 17:35 ` Parav Pandit 2020-10-08 17:35 ` Parav Pandit 2020-10-08 18:13 ` Ertman, David M 2020-10-08 18:13 ` Ertman, David M 2020-10-08 5:21 ` Leon Romanovsky 2020-10-08 5:21 ` Leon Romanovsky 2020-10-08 6:32 ` Dan Williams 2020-10-08 6:32 ` Dan Williams 2020-10-08 7:00 ` Leon Romanovsky 2020-10-08 7:00 ` Leon Romanovsky 2020-10-08 7:38 ` Dan Williams 2020-10-08 7:38 ` Dan Williams 2020-10-08 7:50 ` gregkh 2020-10-08 7:50 ` gregkh 2020-10-08 11:10 ` Parav Pandit [this message] 2020-10-08 11:10 ` Parav Pandit 2020-10-08 16:39 ` Ertman, David M 2020-10-08 16:39 ` Ertman, David M 2020-10-08 8:00 ` Leon Romanovsky 2020-10-08 8:00 ` Leon Romanovsky 2020-10-08 8:09 ` Dan Williams 2020-10-08 8:09 ` Dan Williams 2020-10-08 16:42 ` Ertman, David M 2020-10-08 16:42 ` Ertman, David M 2020-10-08 17:21 ` Leon Romanovsky 2020-10-08 17:21 ` Leon Romanovsky 2020-10-08 18:25 ` Ertman, David M 2020-10-08 18:25 ` Ertman, David M 2020-10-07 20:30 ` Ertman, David M 2020-10-07 20:30 ` Ertman, David M 2020-10-07 20:18 ` Ertman, David M 2020-10-07 20:18 ` Ertman, David M 2020-10-06 17:23 ` Leon Romanovsky 2020-10-06 17:23 ` Leon Romanovsky 2020-10-06 17:45 ` Saleem, Shiraz 2020-10-06 17:45 ` Saleem, Shiraz 2020-10-08 22:04 ` Ertman, David M 2020-10-08 22:04 ` Ertman, David M 2020-10-08 22:41 ` Dan Williams 2020-10-08 22:41 ` Dan Williams 2020-10-09 14:26 ` Pierre-Louis Bossart 2020-10-09 14:26 ` Pierre-Louis Bossart 2020-10-09 19:22 ` Dan Williams 2020-10-09 19:22 ` Dan Williams 2020-10-09 19:39 ` Pierre-Louis Bossart 2020-10-09 19:39 ` Pierre-Louis Bossart 2020-10-12 18:34 ` Ertman, David M 2020-10-12 18:34 ` Ertman, David M 2020-10-08 17:20 ` Leon Romanovsky 2020-10-08 17:20 ` Leon Romanovsky 2020-10-08 17:28 ` Ertman, David M 2020-10-08 17:28 ` Ertman, David M 2020-10-05 18:24 ` [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client Dave Ertman 2020-10-05 18:24 ` Dave Ertman 2020-10-13 1:05 ` Randy Dunlap 2020-10-13 1:05 ` Randy Dunlap 2020-10-13 1:31 ` Pierre-Louis Bossart 2020-10-13 1:31 ` Pierre-Louis Bossart 2020-10-13 1:55 ` Randy Dunlap 2020-10-13 1:55 ` Randy Dunlap 2020-10-13 1:56 ` Randy Dunlap 2020-10-13 1:56 ` Randy Dunlap 2020-10-13 15:08 ` Pierre-Louis Bossart 2020-10-13 19:35 ` Randy Dunlap 2020-10-13 19:57 ` Pierre-Louis Bossart 2020-10-05 18:24 ` [PATCH v2 3/6] ASoC: SOF: Create client driver for IPC test Dave Ertman 2020-10-05 18:24 ` Dave Ertman 2020-10-05 18:24 ` [PATCH v2 4/6] ASoC: SOF: ops: Add ops for client registration Dave Ertman 2020-10-05 18:24 ` Dave Ertman 2020-10-05 18:24 ` [PATCH v2 5/6] ASoC: SOF: Intel: Define " Dave Ertman 2020-10-05 18:24 ` Dave Ertman 2020-10-05 18:24 ` [PATCH v2 6/6] ASoC: SOF: debug: Remove IPC flood test support in SOF core Dave Ertman 2020-10-05 18:24 ` Dave Ertman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BY5PR12MB432291F0683A2295170C2F3BDC0B0@BY5PR12MB4322.namprd12.prod.outlook.com \ --to=parav@nvidia.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=davem@davemloft.net \ --cc=david.m.ertman@intel.com \ --cc=dledford@redhat.com \ --cc=fred.oh@linux.intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=jgg@nvidia.com \ --cc=kiran.patil@intel.com \ --cc=kuba@kernel.org \ --cc=leon@kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=parav@mellanox.com \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=shiraz.saleem@intel.com \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.