RE: [PATCH 22/23] gpio: xilinx: Convert to platform remove callback returning void

From: "Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: "Neeli, Srinivas" <srinivas.neeli@amd.com>,
	"Simek, Michal" <michal.simek@amd.com>,
	Andy Shevchenko <andy@kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 22/23] gpio: xilinx: Convert to platform remove callback returning void
Date: Thu, 28 Sep 2023 08:32:39 +0000	[thread overview]
Message-ID: <BY5PR12MB49022A125E22C62E4BE1B2BB81C1A@BY5PR12MB4902.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230928070706.2290137-23-u.kleine-koenig@pengutronix.de>

[AMD Official Use Only - General]

Hi ,
Thanks for the patch

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Sent: Thursday, September 28, 2023 12:37 PM
> To: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski
> <brgl@bgdev.pl>
> Cc: Datta, Shubhrajyoti <shubhrajyoti.datta@amd.com>; Neeli, Srinivas
> <srinivas.neeli@amd.com>; Simek, Michal <michal.simek@amd.com>; Andy
> Shevchenko <andy@kernel.org>; linux-gpio@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 22/23] gpio: xilinx: Convert to platform remove callback
> returning void
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> The .remove() callback for a platform driver returns an int which makes many
> driver authors wrongly assume it's possible to do error handling by returning
> an error code. However the value returned is ignored (apart from emitting a
> warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return void. In
> the first step of this quest all drivers are converted to .remove_new(), which
> already returns void. Eventually after all drivers are converted, .remove_new()
> will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove callback
> to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>