From: Radhey Shyam Pandey <radheys@xilinx.com>
To: Sebastian von Ohr <vonohr@smaract.com>,
Vinod Koul <vkoul@kernel.org>,
Appana Durga Kedareswara Rao <appanad@xilinx.com>,
Michal Simek <michals@xilinx.com>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: RE: [PATCH] dmaengine: xilinx_dma: Add missing check for empty list
Date: Tue, 7 Apr 2020 16:03:53 +0000 [thread overview]
Message-ID: <BYAPR02MB5638F1A9A1B68C0FA534E07DC7C30@BYAPR02MB5638.namprd02.prod.outlook.com> (raw)
In-Reply-To: <c12c2321f9d5407698b9992b9a375966@smaract.com>
> -----Original Message-----
> From: Sebastian von Ohr <vonohr@smaract.com>
> Sent: Tuesday, April 7, 2020 1:22 PM
> To: Radhey Shyam Pandey <radheys@xilinx.com>; Vinod Koul
> <vkoul@kernel.org>; Appana Durga Kedareswara Rao
> <appanad@xilinx.com>; Michal Simek <michals@xilinx.com>
> Cc: dmaengine@vger.kernel.org
> Subject: RE: [PATCH] dmaengine: xilinx_dma: Add missing check for empty
> list
>
> > -----Original Message-----
> > From: Radhey Shyam Pandey [mailto:radheys@xilinx.com]
> > Sent: Friday, March 6, 2020 2:57 PM
> > To: Vinod Koul <vkoul@kernel.org>; Sebastian von Ohr
> > <vonohr@smaract.com>; Appana Durga Kedareswara Rao
> > <appanad@xilinx.com>; Michal Simek <michals@xilinx.com>
> > Cc: dmaengine@vger.kernel.org
> > Subject: RE: [PATCH] dmaengine: xilinx_dma: Add missing check for
> > empty list
> >
> > Sure, we will test it. Changes look fine. Though had a question in
> > mind, for a generic fix to this problem, should we make locking
> > mandatory for all cookie helper functions? Or is there any limitation?
>
> Any progress on the testing? If you need help reproducing the issue please
> let me know.
Thanks for reminding me. Somehow I missed it. You mentioned in one
of earlier thread that this bug is introduced it using dma_sync_wait to
wait for DMA completion. So to reproduce the issue in xilinx axidma
test client I have to replace issue_pending with sync_wait API?
next prev parent reply other threads:[~2020-04-07 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 13:05 [PATCH] dmaengine: xilinx_dma: Add missing check for empty list Sebastian von Ohr
2020-03-06 13:34 ` Vinod Koul
2020-03-06 13:57 ` Radhey Shyam Pandey
2020-03-11 9:16 ` Vinod Koul
2020-04-07 7:52 ` Sebastian von Ohr
2020-04-07 16:03 ` Radhey Shyam Pandey [this message]
2020-04-08 7:12 ` Sebastian von Ohr
2020-04-08 14:06 ` Radhey Shyam Pandey
2020-04-08 15:19 ` Sebastian von Ohr
2020-04-09 7:40 ` Radhey Shyam Pandey
2020-04-15 16:12 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR02MB5638F1A9A1B68C0FA534E07DC7C30@BYAPR02MB5638.namprd02.prod.outlook.com \
--to=radheys@xilinx.com \
--cc=appanad@xilinx.com \
--cc=dmaengine@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=vkoul@kernel.org \
--cc=vonohr@smaract.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.