From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"colyli@suse.de" <colyli@suse.de>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"linux-btrace@vger.kernel.org" <linux-btrace@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"kent.overstreet@gmail.com" <kent.overstreet@gmail.com>,
"yuchao0@huawei.com" <yuchao0@huawei.com>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH V4 1/9] block: add a helper function to read nr_setcs
Date: Fri, 12 Jul 2019 16:09:56 +0000 [thread overview]
Message-ID: <BYAPR04MB5749AF90A9E9C81B4A6857F386F20@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: yq18st457yb.fsf@oracle.com
On 7/11/19 6:59 PM, Martin K. Petersen wrote:
> Hi Chaitanya,
>
>> +static inline sector_t bdev_nr_sects(struct block_device *bdev)
>> +{
>> + return part_nr_sects_read(bdev->bd_part);
>> +}
> Can bdev end up being NULL in any of the call sites?
>
> Otherwise no objections.
>
Thanks for mentioning that. Initial version which was not posted had
that check.
This series just replaces the existing accesses without changing anything.
So if any of the exiting code has that bug then it will blow up nicely.
For future callers I don't mind adding a new check and resend the series.
Would you prefer adding a check ?
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-btrace@vger.kernel.org" <linux-btrace@vger.kernel.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"yuchao0@huawei.com" <yuchao0@huawei.com>,
"colyli@suse.de" <colyli@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"kent.overstreet@gmail.com" <kent.overstreet@gmail.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [PATCH V4 1/9] block: add a helper function to read nr_setcs
Date: Fri, 12 Jul 2019 16:09:56 +0000 [thread overview]
Message-ID: <BYAPR04MB5749AF90A9E9C81B4A6857F386F20@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: yq18st457yb.fsf@oracle.com
On 7/11/19 6:59 PM, Martin K. Petersen wrote:
> Hi Chaitanya,
>
>> +static inline sector_t bdev_nr_sects(struct block_device *bdev)
>> +{
>> + return part_nr_sects_read(bdev->bd_part);
>> +}
> Can bdev end up being NULL in any of the call sites?
>
> Otherwise no objections.
>
Thanks for mentioning that. Initial version which was not posted had
that check.
This series just replaces the existing accesses without changing anything.
So if any of the exiting code has that bug then it will blow up nicely.
For future callers I don't mind adding a new check and resend the series.
Would you prefer adding a check ?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-btrace@vger.kernel.org" <linux-btrace@vger.kernel.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"yuchao0@huawei.com" <yuchao0@huawei.com>,
"colyli@suse.de" <colyli@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"kent.overstreet@gmail.com" <kent.overstreet@gmail.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH V4 1/9] block: add a helper function to read nr_setcs
Date: Fri, 12 Jul 2019 16:09:56 +0000 [thread overview]
Message-ID: <BYAPR04MB5749AF90A9E9C81B4A6857F386F20@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: yq18st457yb.fsf@oracle.com
On 7/11/19 6:59 PM, Martin K. Petersen wrote:
> Hi Chaitanya,
>
>> +static inline sector_t bdev_nr_sects(struct block_device *bdev)
>> +{
>> + return part_nr_sects_read(bdev->bd_part);
>> +}
> Can bdev end up being NULL in any of the call sites?
>
> Otherwise no objections.
>
Thanks for mentioning that. Initial version which was not posted had
that check.
This series just replaces the existing accesses without changing anything.
So if any of the exiting code has that bug then it will blow up nicely.
For future callers I don't mind adding a new check and resend the series.
Would you prefer adding a check ?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-12 16:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 18:47 [PATCH V4 0/9] block: use right accessor to read nr_sects Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 1/9] block: add a helper function to read nr_setcs Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-12 1:59 ` Martin K. Petersen
2019-07-12 1:59 ` Martin K. Petersen
2019-07-12 1:59 ` [Xen-devel] " Martin K. Petersen
2019-07-12 1:59 ` Martin K. Petersen
2019-07-12 16:09 ` Chaitanya Kulkarni [this message]
2019-07-12 16:09 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-12 16:09 ` Chaitanya Kulkarni
2019-07-17 2:28 ` Martin K. Petersen
2019-07-17 2:28 ` Martin K. Petersen
2019-07-17 2:28 ` [Xen-devel] " Martin K. Petersen
2019-07-17 2:28 ` Martin K. Petersen
2019-07-08 18:47 ` [PATCH V4 2/9] blk-zoned: update blkdev_nr_zones() with helper Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 3/9] blk-zoned: update blkdev_report_zone() " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 4/9] blk-zoned: update blkdev_reset_zones() " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 5/9] bcache: update cached_dev_init() " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 6/9] f2fs: use helper in init_blkz_info() Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 7/9] blktrace: use helper in blk_trace_setup_lba() Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 8/9] target/pscsi: use helper in pscsi_get_blocks() Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 9/9] xen/blkback: use helper in vbd_sz() Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-08 18:47 ` [Xen-devel] " Chaitanya Kulkarni
2019-07-08 18:47 ` Chaitanya Kulkarni
2019-07-15 10:36 ` Roger Pau Monné
2019-07-15 10:36 ` Roger Pau Monné
2019-07-15 10:36 ` [Xen-devel] " Roger Pau Monné
2019-07-15 10:36 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB5749AF90A9E9C81B4A6857F386F20@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=bvanassche@acm.org \
--cc=colyli@suse.de \
--cc=jaegeuk@kernel.org \
--cc=kent.overstreet@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.