From: Linus Torvalds <torvalds@linux-foundation.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()
Date: Tue, 8 Mar 2016 12:05:22 -0800 [thread overview]
Message-ID: <CA+55aFy=V-esUXZa2AogS685k+r9PyyNStkZrrUUkWSKvLFUGQ@mail.gmail.com> (raw)
In-Reply-To: <1457460530-17959-1-git-send-email-toshi.kani@hpe.com>
On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
>
> Add device-managed implementaions of insert_resource() and
> remove_resouce() functions.
Can we get an example of the users and show how much this would actually help?
insert_resource() is fairly unusual to begin with, and it should
basically *never* be used by a driver at all (it's more of a bus
thing).
The patch doesn't look _wrong_, but it does look potentially largely
pointless. Adding new interfaces to do things that aren't common
enough to worry about is counter-productive, imho.
Linus
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()
Date: Tue, 8 Mar 2016 12:05:22 -0800 [thread overview]
Message-ID: <CA+55aFy=V-esUXZa2AogS685k+r9PyyNStkZrrUUkWSKvLFUGQ@mail.gmail.com> (raw)
In-Reply-To: <1457460530-17959-1-git-send-email-toshi.kani@hpe.com>
On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
>
> Add device-managed implementaions of insert_resource() and
> remove_resouce() functions.
Can we get an example of the users and show how much this would actually help?
insert_resource() is fairly unusual to begin with, and it should
basically *never* be used by a driver at all (it's more of a bus
thing).
The patch doesn't look _wrong_, but it does look potentially largely
pointless. Adding new interfaces to do things that aren't common
enough to worry about is counter-productive, imho.
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()
Date: Tue, 8 Mar 2016 12:05:22 -0800 [thread overview]
Message-ID: <CA+55aFy=V-esUXZa2AogS685k+r9PyyNStkZrrUUkWSKvLFUGQ@mail.gmail.com> (raw)
In-Reply-To: <1457460530-17959-1-git-send-email-toshi.kani@hpe.com>
On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
>
> Add device-managed implementaions of insert_resource() and
> remove_resouce() functions.
Can we get an example of the users and show how much this would actually help?
insert_resource() is fairly unusual to begin with, and it should
basically *never* be used by a driver at all (it's more of a bus
thing).
The patch doesn't look _wrong_, but it does look potentially largely
pointless. Adding new interfaces to do things that aren't common
enough to worry about is counter-productive, imho.
Linus
next prev parent reply other threads:[~2016-03-08 20:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 18:08 [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource() Toshi Kani
2016-03-08 18:08 ` Toshi Kani
2016-03-08 18:08 ` Toshi Kani
2016-03-08 17:33 ` Ingo Molnar
2016-03-08 17:33 ` Ingo Molnar
2016-03-08 17:33 ` Ingo Molnar
2016-03-08 20:05 ` Linus Torvalds [this message]
2016-03-08 20:05 ` Linus Torvalds
2016-03-08 20:05 ` Linus Torvalds
2016-03-08 20:59 ` Dan Williams
2016-03-08 20:59 ` Dan Williams
2016-03-08 20:59 ` Dan Williams
2016-03-08 22:23 ` Linus Torvalds
2016-03-08 22:23 ` Linus Torvalds
2016-03-08 22:23 ` Linus Torvalds
2016-03-08 22:44 ` Dan Williams
2016-03-08 22:44 ` Dan Williams
2016-03-08 22:44 ` Dan Williams
2016-03-09 0:04 ` Toshi Kani
2016-03-09 0:04 ` Toshi Kani
2016-03-09 0:04 ` Toshi Kani
2016-03-08 23:31 ` Linus Torvalds
2016-03-08 23:31 ` Linus Torvalds
2016-03-08 23:31 ` Linus Torvalds
2016-03-09 1:00 ` Toshi Kani
2016-03-09 1:00 ` Toshi Kani
2016-03-09 1:00 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFy=V-esUXZa2AogS685k+r9PyyNStkZrrUUkWSKvLFUGQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mingo@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.