From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
wei.w.wang@intel.com
Subject: Re: [PULL] vhost: cleanups and fixes
Date: Mon, 11 Jun 2018 11:32:41 -0700 [thread overview]
Message-ID: <CA+55aFzrPgnd7hRPrkeV+jX-MSwOZf7T4wKxz66Lk4oub3PZsw@mail.gmail.com> (raw)
In-Reply-To: <20180611192353-mutt-send-email-mst@kernel.org>
On Mon, Jun 11, 2018 at 9:24 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
Is this really a good idea?
Plus it seems entirely broken.
The report_pfn_range() callback is done under the zone lock, but
virtio_balloon_send_free_pages() (which is the only callback used that
I can find) does add_one_sg(), which does virtqueue_add_inbuf(vq, &sg,
1, vq, GFP_KERNEL);
So now we apparently do a GFP_KERNEL allocation insider the mm zone
lock, which is broken on just _so_ many levels.
Pulled and then unpulled again.
Either somebody needs to explain why I'm wrong and you can re-submit
this, or this kind of garbage needs to go away.
I do *not* want to be in the situation where I pull stuff from the
virtio people that adds completely broken core VM functionality.
Because if I'm in that situation, I will stop pulling from you guys.
Seriously. You have *no* place sending me broken shit that is outside
the virtio layer.
Subsystems that break code MM will get shunned. You just aren't
important enough to allow you breaking code VM.
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PULL] vhost: cleanups and fixes
Date: Mon, 11 Jun 2018 11:32:41 -0700 [thread overview]
Message-ID: <CA+55aFzrPgnd7hRPrkeV+jX-MSwOZf7T4wKxz66Lk4oub3PZsw@mail.gmail.com> (raw)
In-Reply-To: <20180611192353-mutt-send-email-mst@kernel.org>
On Mon, Jun 11, 2018 at 9:24 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
Is this really a good idea?
Plus it seems entirely broken.
The report_pfn_range() callback is done under the zone lock, but
virtio_balloon_send_free_pages() (which is the only callback used that
I can find) does add_one_sg(), which does virtqueue_add_inbuf(vq, &sg,
1, vq, GFP_KERNEL);
So now we apparently do a GFP_KERNEL allocation insider the mm zone
lock, which is broken on just _so_ many levels.
Pulled and then unpulled again.
Either somebody needs to explain why I'm wrong and you can re-submit
this, or this kind of garbage needs to go away.
I do *not* want to be in the situation where I pull stuff from the
virtio people that adds completely broken core VM functionality.
Because if I'm in that situation, I will stop pulling from you guys.
Seriously. You have *no* place sending me broken shit that is outside
the virtio layer.
Subsystems that break code MM will get shunned. You just aren't
important enough to allow you breaking code VM.
Linus
next prev parent reply other threads:[~2018-06-11 18:32 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 16:23 [PULL] vhost: cleanups and fixes Michael S. Tsirkin
2018-06-11 16:23 ` Michael S. Tsirkin
2018-06-11 18:32 ` Linus Torvalds [this message]
2018-06-11 18:32 ` Linus Torvalds
2018-06-11 18:44 ` Linus Torvalds
2018-06-11 18:44 ` Linus Torvalds
2018-06-12 1:36 ` Michael S. Tsirkin
2018-06-12 1:36 ` Michael S. Tsirkin
2018-06-12 1:59 ` Linus Torvalds
2018-06-12 1:59 ` Linus Torvalds
2018-06-12 11:05 ` Wei Wang
2018-06-12 11:05 ` Wei Wang
2018-06-14 15:01 ` Nitesh Narayan Lal
2018-06-15 3:53 ` Wei Wang
2018-06-15 3:53 ` Wei Wang
2018-06-12 1:57 ` Michael S. Tsirkin
2018-06-12 1:57 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2020-02-10 6:02 Michael S. Tsirkin
2020-02-11 2:07 ` Linus Torvalds
2020-02-11 2:07 ` Linus Torvalds
2020-02-07 7:39 Michael S. Tsirkin
2019-10-28 8:29 Michael S. Tsirkin
2019-10-15 21:19 Michael S. Tsirkin
2019-10-15 21:19 Michael S. Tsirkin
2019-10-15 22:25 ` pr-tracker-bot
2019-10-15 22:25 ` pr-tracker-bot
2019-06-03 14:30 Michael S. Tsirkin
2019-05-14 21:11 Michael S. Tsirkin
2019-05-14 21:11 Michael S. Tsirkin
2019-05-14 21:20 ` pr-tracker-bot
2019-05-14 21:20 ` pr-tracker-bot
2018-11-01 21:19 Michael S. Tsirkin
2018-11-01 21:19 ` Michael S. Tsirkin
2018-11-01 21:19 ` Michael S. Tsirkin
2018-11-01 21:44 ` Linus Torvalds
2018-11-01 21:44 ` Linus Torvalds
2018-11-01 23:00 ` Kees Cook
2018-11-01 23:00 ` Kees Cook
2018-11-01 23:00 ` Kees Cook
2018-11-01 23:06 ` Linus Torvalds
2018-11-01 23:55 ` Michael S. Tsirkin
2018-11-01 23:55 ` Michael S. Tsirkin
2018-11-02 11:46 ` Mark Rutland
2018-11-02 11:46 ` Mark Rutland
2018-11-02 13:04 ` Michael S. Tsirkin
2018-11-02 16:14 ` Linus Torvalds
2018-11-02 16:59 ` Michael S. Tsirkin
2018-11-02 16:59 ` Michael S. Tsirkin
2018-11-02 17:10 ` Linus Torvalds
2018-11-02 17:10 ` Linus Torvalds
2018-11-02 17:15 ` Linus Torvalds
2018-11-02 17:15 ` Linus Torvalds
2018-11-02 19:01 ` Al Viro
2018-11-02 19:01 ` Al Viro
2018-11-02 17:21 ` Michael S. Tsirkin
2018-11-02 17:21 ` Michael S. Tsirkin
2018-11-02 18:02 ` Linus Torvalds
2018-11-02 18:02 ` Linus Torvalds
2018-11-02 18:12 ` Michael S. Tsirkin
2018-11-02 18:12 ` Michael S. Tsirkin
2018-11-02 16:14 ` Linus Torvalds
2018-11-02 13:04 ` Michael S. Tsirkin
2018-11-30 13:44 ` Michael S. Tsirkin
2018-11-30 13:44 ` Michael S. Tsirkin
2018-11-30 19:01 ` Bijan Mottahedeh
2018-11-30 19:55 ` Michael S. Tsirkin
2018-11-30 19:55 ` Michael S. Tsirkin
2018-11-01 23:06 ` Linus Torvalds
2018-11-01 23:38 ` Michael S. Tsirkin
2018-11-01 23:38 ` Michael S. Tsirkin
2017-12-08 15:47 Michael S. Tsirkin
2017-12-08 15:47 Michael S. Tsirkin
2017-12-04 13:25 Michael S. Tsirkin
2017-08-25 18:47 Michael S. Tsirkin
2017-04-10 21:36 Michael S. Tsirkin
2017-04-10 21:36 ` Michael S. Tsirkin
2017-03-02 5:49 Michael S. Tsirkin
2017-03-02 5:49 ` Michael S. Tsirkin
2017-02-03 21:43 Michael S. Tsirkin
2017-02-03 21:43 ` Michael S. Tsirkin
2017-01-23 15:05 Michael S. Tsirkin
2017-01-23 15:05 ` Michael S. Tsirkin
2017-01-23 21:50 ` Linus Torvalds
2017-01-24 2:45 ` Michael S. Tsirkin
2017-01-24 2:45 ` Michael S. Tsirkin
2017-01-23 21:50 ` Linus Torvalds
2016-05-24 11:57 Michael S. Tsirkin
2016-05-24 11:57 ` Michael S. Tsirkin
2015-12-21 7:58 Michael S. Tsirkin
2015-12-21 7:58 ` Michael S. Tsirkin
2015-12-07 17:07 Michael S. Tsirkin
2015-09-18 10:42 Michael S. Tsirkin
2015-09-18 10:42 Michael S. Tsirkin
2015-09-09 9:15 Michael S. Tsirkin
2015-09-09 9:15 Michael S. Tsirkin
2015-07-28 10:00 Michael S. Tsirkin
2015-07-15 10:50 Michael S. Tsirkin
2015-07-15 10:50 ` Michael S. Tsirkin
2015-07-15 11:26 ` Michael S. Tsirkin
2015-07-15 11:26 ` Michael S. Tsirkin
2015-06-01 19:18 Michael S. Tsirkin
2015-06-01 19:18 Michael S. Tsirkin
2015-06-01 19:45 ` Michael S. Tsirkin
2015-06-01 19:45 ` Michael S. Tsirkin
2015-01-08 7:51 Michael S. Tsirkin
2015-01-01 12:26 Michael S. Tsirkin
2015-01-01 12:26 Michael S. Tsirkin
2014-12-18 10:46 Michael S. Tsirkin
2014-12-18 10:46 ` Michael S. Tsirkin
2014-11-13 21:22 Michael S. Tsirkin
2014-11-13 21:22 ` Michael S. Tsirkin
2014-06-25 11:05 Michael S. Tsirkin
2014-06-25 11:05 ` Michael S. Tsirkin
2013-07-15 18:31 Michael S. Tsirkin
2013-07-15 18:31 ` Michael S. Tsirkin
2013-07-22 8:07 ` Michael S. Tsirkin
2013-07-22 8:07 ` Michael S. Tsirkin
2013-07-08 11:45 Michael S. Tsirkin
2013-07-08 11:45 ` Michael S. Tsirkin
2013-05-02 10:53 Michael S. Tsirkin
2013-05-02 10:53 ` Michael S. Tsirkin
2013-05-02 18:55 ` Nicholas A. Bellinger
2013-05-02 19:33 ` Michael S. Tsirkin
2013-05-02 19:49 ` Linus Torvalds
2013-06-05 15:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFzrPgnd7hRPrkeV+jX-MSwOZf7T4wKxz66Lk4oub3PZsw@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bjorn.andersson@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.