From: Michal Kazior <michal.kazior@tieto.com> To: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>, linux-wireless <linux-wireless@vger.kernel.org> Subject: Re: [PATCH 2/4] ath10k: Add provision for Rx descriptor abstraction Date: Wed, 27 Jul 2016 14:43:09 +0200 [thread overview] Message-ID: <CA+BoTQ=kUP-Qtw1EWKKfM_aGtJS_4oQdz4tqD5tiJkF_k3-vOA@mail.gmail.com> (raw) In-Reply-To: <1469623006-13178-3-git-send-email-vthiagar@qti.qualcomm.com> On 27 July 2016 at 14:36, Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> wrote: > There are slight differences in Rx hw descriptor information > among different chips. So far driver does not use those new > information for any functionalities, but there is one important > information which is available from QCA99X0 onwards to indicate > the number of bytes that hw padded at the begining of the rx > payload and this information is needed to undecap the rx > packet. Add an abstraction for Rx desc to make use of the > new desc information available. The callback that this patch > defines to retrieve the padding bytes will be used in follow-up > patch. > > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/core.c | 12 ++++++++++++ > drivers/net/wireless/ath/ath10k/hw.c | 13 +++++++++++++ > drivers/net/wireless/ath/ath10k/hw.h | 12 ++++++++++++ > 3 files changed, 37 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > index e889829..9c5e93b 100644 > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -68,6 +68,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { > .board_size = QCA988X_BOARD_DATA_SZ, > .board_ext_size = QCA988X_BOARD_EXT_DATA_SZ, > }, > + .hw_rx_desc_ops = &qca988x_rx_desc_ops, [...] > +struct ath10k_hw_rx_desc_ops { > + int (*rx_desc_get_l3_pad_bytes)(struct htt_rx_desc *rxd); > +}; Benjamin is trying to implement coverage class by poking hw registers over firmware's head [1]. I'm thinking the hw_rx_desc_ops could be generalized to hw_ops so it can be used for doing hw-specific hacks as well. What do you think? [1]: http://lists.infradead.org/pipermail/ath10k/2016-July/008107.html Michał
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com> To: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> Cc: linux-wireless <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [PATCH 2/4] ath10k: Add provision for Rx descriptor abstraction Date: Wed, 27 Jul 2016 14:43:09 +0200 [thread overview] Message-ID: <CA+BoTQ=kUP-Qtw1EWKKfM_aGtJS_4oQdz4tqD5tiJkF_k3-vOA@mail.gmail.com> (raw) In-Reply-To: <1469623006-13178-3-git-send-email-vthiagar@qti.qualcomm.com> On 27 July 2016 at 14:36, Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> wrote: > There are slight differences in Rx hw descriptor information > among different chips. So far driver does not use those new > information for any functionalities, but there is one important > information which is available from QCA99X0 onwards to indicate > the number of bytes that hw padded at the begining of the rx > payload and this information is needed to undecap the rx > packet. Add an abstraction for Rx desc to make use of the > new desc information available. The callback that this patch > defines to retrieve the padding bytes will be used in follow-up > patch. > > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/core.c | 12 ++++++++++++ > drivers/net/wireless/ath/ath10k/hw.c | 13 +++++++++++++ > drivers/net/wireless/ath/ath10k/hw.h | 12 ++++++++++++ > 3 files changed, 37 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > index e889829..9c5e93b 100644 > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -68,6 +68,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { > .board_size = QCA988X_BOARD_DATA_SZ, > .board_ext_size = QCA988X_BOARD_EXT_DATA_SZ, > }, > + .hw_rx_desc_ops = &qca988x_rx_desc_ops, [...] > +struct ath10k_hw_rx_desc_ops { > + int (*rx_desc_get_l3_pad_bytes)(struct htt_rx_desc *rxd); > +}; Benjamin is trying to implement coverage class by poking hw registers over firmware's head [1]. I'm thinking the hw_rx_desc_ops could be generalized to hw_ops so it can be used for doing hw-specific hacks as well. What do you think? [1]: http://lists.infradead.org/pipermail/ath10k/2016-July/008107.html Michał _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-07-27 12:43 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-27 12:36 [PATCH 0/4] ath10k: Padding related clean ups in rx Vasanthakumar Thiagarajan 2016-07-27 12:36 ` Vasanthakumar Thiagarajan 2016-07-27 12:36 ` [PATCH 1/4] ath10k: Move ath10k_hw_params definition to hw.h Vasanthakumar Thiagarajan 2016-07-27 12:36 ` Vasanthakumar Thiagarajan 2016-07-27 12:36 ` [PATCH 2/4] ath10k: Add provision for Rx descriptor abstraction Vasanthakumar Thiagarajan 2016-07-27 12:36 ` Vasanthakumar Thiagarajan 2016-07-27 12:43 ` Michal Kazior [this message] 2016-07-27 12:43 ` Michal Kazior 2016-07-27 12:59 ` Thiagarajan, Vasanthakumar 2016-07-27 12:59 ` Thiagarajan, Vasanthakumar 2016-07-27 13:12 ` Michal Kazior 2016-07-27 13:12 ` Michal Kazior 2016-07-27 12:36 ` [PATCH 3/4] ath10k: Properly remove padding from the start of rx payload Vasanthakumar Thiagarajan 2016-07-27 12:36 ` Vasanthakumar Thiagarajan 2016-07-27 12:36 ` [PATCH 4/4] ath10k: Remove 4-addr padding related hw_param configuration Vasanthakumar Thiagarajan 2016-07-27 12:36 ` Vasanthakumar Thiagarajan 2016-09-09 14:29 ` [PATCH 0/4] ath10k: Padding related clean ups in rx Valo, Kalle 2016-09-09 14:29 ` Valo, Kalle
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+BoTQ=kUP-Qtw1EWKKfM_aGtJS_4oQdz4tqD5tiJkF_k3-vOA@mail.gmail.com' \ --to=michal.kazior@tieto.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=vthiagar@qti.qualcomm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.