From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Will Deacon <will@kernel.org>
Cc: Tyler Hicks <tyhicks@linux.microsoft.com>,
James Morris <jmorris@namei.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Mike Rapoport <rppt@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
Ard Biesheuvel <ardb@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH v3 1/1] arm64: mm: correct the inside linear map range during hotplug check
Date: Fri, 19 Feb 2021 14:44:49 -0500 [thread overview]
Message-ID: <CA+CK2bB13G4wTm6P_hdkwi2cbu=774GnpwBV7giy77-fEHDKow@mail.gmail.com> (raw)
In-Reply-To: <20210219191807.GB6683@willie-the-truck>
On Fri, Feb 19, 2021 at 2:18 PM Will Deacon <will@kernel.org> wrote:
>
> On Tue, Feb 16, 2021 at 10:03:51AM -0500, Pavel Tatashin wrote:
> > Memory hotplug may fail on systems with CONFIG_RANDOMIZE_BASE because the
> > linear map range is not checked correctly.
> >
> > The start physical address that linear map covers can be actually at the
> > end of the range because of randomization. Check that and if so reduce it
> > to 0.
> >
> > This can be verified on QEMU with setting kaslr-seed to ~0ul:
> >
> > memstart_offset_seed = 0xffff
> > START: __pa(_PAGE_OFFSET(vabits_actual)) = ffff9000c0000000
> > END: __pa(PAGE_END - 1) = 1000bfffffff
> >
> > Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> > Fixes: 58284a901b42 ("arm64/mm: Validate hotplug range before creating linear mapping")
> > Tested-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> > ---
> > arch/arm64/mm/mmu.c | 21 +++++++++++++++++++--
> > 1 file changed, 19 insertions(+), 2 deletions(-)
>
> I tried to queue this as a fix, but unfortunately it doesn't apply.
> Please can you send a v4 based on the arm64 for-next/fixes branch?
Hi Will,
The previous version, that is not built against linux-next would still
applies against current mainlein/for-next/fixes
https://lore.kernel.org/lkml/20210215192237.362706-2-pasha.tatashin@soleen.com/
I just tried it. I think it would make sense to take v2 fix, so it
could also be backported to stables.
Thank you,
Pasha
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Will Deacon <will@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
James Morris <jmorris@namei.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Tyler Hicks <tyhicks@linux.microsoft.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Logan Gunthorpe <logang@deltatee.com>,
Ard Biesheuvel <ardb@kernel.org>, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v3 1/1] arm64: mm: correct the inside linear map range during hotplug check
Date: Fri, 19 Feb 2021 14:44:49 -0500 [thread overview]
Message-ID: <CA+CK2bB13G4wTm6P_hdkwi2cbu=774GnpwBV7giy77-fEHDKow@mail.gmail.com> (raw)
In-Reply-To: <20210219191807.GB6683@willie-the-truck>
On Fri, Feb 19, 2021 at 2:18 PM Will Deacon <will@kernel.org> wrote:
>
> On Tue, Feb 16, 2021 at 10:03:51AM -0500, Pavel Tatashin wrote:
> > Memory hotplug may fail on systems with CONFIG_RANDOMIZE_BASE because the
> > linear map range is not checked correctly.
> >
> > The start physical address that linear map covers can be actually at the
> > end of the range because of randomization. Check that and if so reduce it
> > to 0.
> >
> > This can be verified on QEMU with setting kaslr-seed to ~0ul:
> >
> > memstart_offset_seed = 0xffff
> > START: __pa(_PAGE_OFFSET(vabits_actual)) = ffff9000c0000000
> > END: __pa(PAGE_END - 1) = 1000bfffffff
> >
> > Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> > Fixes: 58284a901b42 ("arm64/mm: Validate hotplug range before creating linear mapping")
> > Tested-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> > ---
> > arch/arm64/mm/mmu.c | 21 +++++++++++++++++++--
> > 1 file changed, 19 insertions(+), 2 deletions(-)
>
> I tried to queue this as a fix, but unfortunately it doesn't apply.
> Please can you send a v4 based on the arm64 for-next/fixes branch?
Hi Will,
The previous version, that is not built against linux-next would still
applies against current mainlein/for-next/fixes
https://lore.kernel.org/lkml/20210215192237.362706-2-pasha.tatashin@soleen.com/
I just tried it. I think it would make sense to take v2 fix, so it
could also be backported to stables.
Thank you,
Pasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-19 19:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 15:03 [PATCH v3 0/1] correct the inside linear map range during hotplug check Pavel Tatashin
2021-02-16 15:03 ` Pavel Tatashin
2021-02-16 15:03 ` [PATCH v3 1/1] arm64: mm: " Pavel Tatashin
2021-02-16 15:03 ` Pavel Tatashin
2021-02-19 19:18 ` Will Deacon
2021-02-19 19:18 ` Will Deacon
2021-02-19 19:44 ` Pavel Tatashin [this message]
2021-02-19 19:44 ` Pavel Tatashin
2021-02-19 19:44 ` Pavel Tatashin
2021-02-22 12:25 ` Will Deacon
2021-02-22 12:25 ` Will Deacon
2021-02-22 14:17 ` Pavel Tatashin
2021-02-22 14:17 ` Pavel Tatashin
2021-02-22 14:17 ` Pavel Tatashin
2021-03-19 15:43 ` Pavel Tatashin
2021-03-19 15:43 ` Pavel Tatashin
2021-03-19 15:43 ` Pavel Tatashin
2021-02-24 7:12 ` Anshuman Khandual
2021-02-24 7:12 ` Anshuman Khandual
2021-03-22 13:19 ` [PATCH v3 0/1] " Will Deacon
2021-03-22 13:19 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bB13G4wTm6P_hdkwi2cbu=774GnpwBV7giy77-fEHDKow@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jmorris@namei.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=tyhicks@linux.microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.